From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E960C3DA49 for ; Fri, 19 Jul 2024 02:56:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 398936B0088; Thu, 18 Jul 2024 22:56:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3478A6B0089; Thu, 18 Jul 2024 22:56:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2368C6B008C; Thu, 18 Jul 2024 22:56:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 009686B0088 for ; Thu, 18 Jul 2024 22:56:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 71F6E1A035A for ; Fri, 19 Jul 2024 02:56:54 +0000 (UTC) X-FDA: 82354989948.01.31E9471 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 899DA180004 for ; Fri, 19 Jul 2024 02:56:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=UzRBpl4k; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf24.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721357778; a=rsa-sha256; cv=none; b=oa+lYdUJDD8rduIeOz6GNpzZJjcidKFdQsRyVmQETCxH2phSwZR2Mf+hj17S96fGVmxed7 Al2y7cSQ0wRpFuRneZNMaNp9g6aEAtAqbc6mjupwxjKw84jB4Yp5zzF9/tXWBV4ScKRNDr U9Vj/hhY5RO5Z5w6PiRiRqw3droU3ZM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=UzRBpl4k; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf24.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721357778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jg8amgsqBxJEisE5Ex24Edv12WNot2unJdqz7eY+lBs=; b=ome/+e+mAaksfjKGTMMFk8UTgWtNJij7DvdIevyT7rcO/G6RkKLE5fhq9o8KVQpf/JFMsJ bCI5Cn/NzVR9WgaeIWS3IJw4gxsOfB3b0b1bYbQ+UdM83EhU8YZeRgEcWV4UOt1nOW+44l 3qTYWENIeMowJV/i/pzzfrair/L2s+E= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-44931f038f9so7705321cf.0 for ; Thu, 18 Jul 2024 19:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1721357811; x=1721962611; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jg8amgsqBxJEisE5Ex24Edv12WNot2unJdqz7eY+lBs=; b=UzRBpl4kjzsgb+bYNiu2BzEgu/dv8UbMS0D5AJibyUrj7201x/0cL344VcZR7wvFO3 6co9yrR0aEu2TvBIq33KWhFp6BRG2+SO3EVrEdEYAnH20Nayxetmt5L5s9wjb1sm9LfA x+KLXT9ZanDt68YsbPIQEfoQdG06tmUy2eai4INdVsvMhB3HF3X7e+TPzrYt3/HJtfmX sbeVu5bmXq1/O59vvcpTiHs4beMgr+fXlpvxh6BdFbTBNgSeJUvK+1MAjupd28chCk+M iRa0iCByBDslDB9T3bM054TL7/Ou4cOfX4p4QSRs01aTQq5mM1U2u1XGNH1WHAXL0jxC isWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721357811; x=1721962611; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jg8amgsqBxJEisE5Ex24Edv12WNot2unJdqz7eY+lBs=; b=EQI3Z/xf4u4uusFgtX1AsI1wShS+/JRlD6HmYiYGLnUQym4i/dL2JIss0smld9neOi i0hVr3tuAPj164yd37IkXmkidyk0nOiHEXjoduGauIR679aiPK+01NFuSXBsdLzJQ0ks i3Qe8VOsqlQunGVtUvaiGE00gzkraQwwRotZptpMAq/iyEH8w8j5OcYIfPocGCfAY3Jf iJ6816neruQUBVPZTLfEIrmt8fH6UGXnewp7Fk9ATivImnhbBJffhTuTvDRH0M/6JhML XCb5V9JUmUvv5RrlWGASq+UdXweVDll24rSnSAq/mU6vNLHTcZQkAB5EFRE013IbGoxi +Dug== X-Forwarded-Encrypted: i=1; AJvYcCVDWxiybrnXCAdfYtM7CT89/khwsH/tTOpEZ7enBdAX8jUacyD/8oBK8PmfE5sUoDO3zwb2DtBldP3YeA6oZ/G748k= X-Gm-Message-State: AOJu0YzFVccqQCvM7gdnTGXW0ZpCDZVGJrGN/N7riLKEZ60ocB1O1Z5E fdTxai6VQ29y1nzbYRl6WXdDx0gE/48MgkfFFF2Uj67QLBwZ0wzPov9MKw3GmgbCC1e6H+WwPO6 XbN66tV1rGgrgo722c4pbSvC6AatiJAhaO6WMxA== X-Google-Smtp-Source: AGHT+IHDYSY1eEWlCkMlOjWqhFRE+smxx4jkS72e66X+P6QkOxFFEn6nUns7K7tfje4IuetMmXBjcF7nLqyNYpTu8+s= X-Received: by 2002:ac8:574e:0:b0:447:f87c:6b9f with SMTP id d75a77b69052e-44f96aa07b0mr45218021cf.17.1721357811654; Thu, 18 Jul 2024 19:56:51 -0700 (PDT) MIME-Version: 1.0 References: <20240530170259.852088-1-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 18 Jul 2024 22:56:14 -0400 Message-ID: Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram To: Shakeel Butt Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 899DA180004 X-Stat-Signature: 7gx8b3k84x6idni73jtczh4o3ekrynp8 X-Rspam-User: X-HE-Tag: 1721357812-756722 X-HE-Meta: U2FsdGVkX19L4VRqINC6Gu0NO15RPnyV0q0aiAb9E1mggOx/lPJItQEU77fVLU8wwN4eme9broJVEdQXMw0oaZ1B+hiA0OqZiW6AoX+4VLUCva/eTRmOfITGFxcMXpJNG5fkLFzTdEFI+SWHh8rIgmqHVk8oGTcjR/ZYWgCzlFRoCNe2ckN/eEDzj7KfhdDfwDUkk8MPcKw7n92IHG5Bf1eaIB2v+biwFwAbcYGew6o3lRSmvkdOIONoGR58+VDS5eGd7S84VUN6sDhN+bfEhsYGqNxh1zVlfs56pDAZmdWmYHl/rhj4EVvmtTdm6Odr0Nj+dwnkv5OUAnRitbJpzci617PCPZiHWGWouKpDBebhGRmQNvnVn6UiHiCbFj06RxCpeGpzFHJzEoJ25YronQS2WRHWvDDio3rBidIPNZRk6l1KVc+bJnuk1M2SjsC2Xh2tibAli2Odu4EK/UUTORNsznHmIxlCDuXY2sjEKKSjYTRCQzoNt+s364fadiBHtwCiE87IF9SlDRPZnYOD8B7Jr32SZIYCQVQnj2Jp6LZmVIwHskqX8kikxlelMFzAsIv2GidYkEQFR7OV5Jy0A3crJRRAu5dsLBVKbsP2GH48MZR3I8w0xzrTw3GT1/MWwDwTFOhSGRqYXbd5C2nszUclFgR6oGf4HjPhS/zUFvVpxjRJSGjHohGXtfi254RT6OztuRyvMtJeYcz/qXwdW6x98HCRMCasMuQwf/HoCEIMCxDCVe5ntYMV9HHMBFEFRCZ45YLlrnSZWbL5tw/sUXKwI3fSYVc3Z5G6yZYUCVxcKndmf3RXaF8e8P4KGo6jhFfHKYKUjbqwyU8sp6PRyxp0SeTCaCInuFBLBaAqVMUV4OOUzQaQqRXdCCAgUUn7UXL02/nSViBpZhk5N1/+0xTLz57b9Tr+VleMPUVScIu1TpG8GQljUOvvkCHLH6Mc7Y5lAfwQ6yXBpIA/sEt 6EENsgCD 7pP75hUwE0w8BsM9FKdP25Ik8QBMUSFevitl+4mgf7AF/zWNIaaGOzUHGdPcFEN7YB9SPgmgNdJME016x+HdzBJF4fsxUGYYhWXR6eoZWEMkmuBVEWya6d1lFCW/E2rv0QVEMeJejlSOv5I8BzE6xFSf9GQ1nz+YHuSBSLjq7TRDbtQGlg9uYzbOsLfmv0khm3FZnlzwYUHfBqGmC51sza02HQbBud9SUcS41 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000200, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 18, 2024 at 7:19=E2=80=AFPM Shakeel Butt wrote: > > Hi Pasha, > > On Wed, Jul 17, 2024 at 12:50:00PM GMT, Pasha Tatashin wrote: > > On Wed, Jun 12, 2024 at 2:50=E2=80=AFPM Shakeel Butt wrote: > > > > [...] > > > > > > > > One more question: Is there any concern in making > > > > CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default > > > > kernels instead of just debug kernels? > > > > We enabled it in Google ProdKernel. There is some overhead when > > threads are exiting, because we are looking for the first non-zero > > byte, but that is minimal. We haven't observed any performance impact > > on our fleet. > > > > So, you would support making CONFIG_DEBUG_STACK_USAGE enabled by > default, right? Right, I see nothing wrong with having this enabled by default. Pasha