From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04953C4167B for ; Wed, 6 Dec 2023 02:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70EAB6B007D; Tue, 5 Dec 2023 21:58:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE4D6B007E; Tue, 5 Dec 2023 21:58:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AD406B0080; Tue, 5 Dec 2023 21:58:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4A9D36B007D for ; Tue, 5 Dec 2023 21:58:15 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 142681A0345 for ; Wed, 6 Dec 2023 02:58:15 +0000 (UTC) X-FDA: 81534884550.01.249C7A7 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf20.hostedemail.com (Postfix) with ESMTP id 4AA501C0015 for ; Wed, 6 Dec 2023 02:58:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=k+zwfY51; spf=pass (imf20.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701831493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E+W/qJKZ4cbrJ9KJlY0HysuZCkaE03MWjevhyEtd/+k=; b=0pFRAmHkxDBoTKUAAXI7moadQ5F5ItldszMVyQLJAjAkuNXERtzzP//zDKqCuxlrtFRLQO cF1JA4NYhNVzipmmm1lb0qr5oWszFptKeR8SpHXWbzqKadNjlgAkE0Bqe9oBVKxTH/vmiI vtNC0ro6mJu+zWCVEPZJUggw+xfpBec= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701831493; a=rsa-sha256; cv=none; b=KiFjxFJcFwH6+/+/jOJfIIVRKRp4uPNAA8+fmROLRoMl77BX3rCS51Q6YKErK8878cHZTe nu7QxSf+WA+/cAYnTY8l6SolqoxZtQHmUSJPiw47yUSgOP49mvOfMs01jYLEoN5BnwyxHI Hk9Eu+cNrIb+dY3qEopw7iSjNZzMQFk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=k+zwfY51; spf=pass (imf20.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-42573090000so2668901cf.0 for ; Tue, 05 Dec 2023 18:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1701831492; x=1702436292; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E+W/qJKZ4cbrJ9KJlY0HysuZCkaE03MWjevhyEtd/+k=; b=k+zwfY519tVj36BUZA0D0EMguK6XUol9xwBtv/imeAcRD8DBLqUNrbuyZwtu7XsR4j Hy6+BNBo3Mgjq71WaDoWTU2eEMXp6909VEG8x2M+ArlNWBvrgUal5KNb6weDKE3iG2Q8 JYETc8eWt83dzzxQTTny1ThgRQ0u718JVxkXoHqQMWRUzpqrvwDn96TIOCQ4VNozx039 NPm72rycQswG3DbXyqDMApEuGeuAIV5X58K73vG3xiS2eIn0G24goZYjXdBp/lh7R1I2 5fSlkFNCHleqiHRH/9rnqkV6laUirZoVQykbeVypkSCoXHWlTHb3BvJIIOw+H3QurVRg gIlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701831492; x=1702436292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E+W/qJKZ4cbrJ9KJlY0HysuZCkaE03MWjevhyEtd/+k=; b=hGDQREE0S5TlhECYEoS/aP1Cb7r7U2f8PqG5z5POyihrBjLqF9vIBeiO9DfyfCYRdz i77ySttEv0oXkaKCxW7CjPgInqZi3/Wtr6GI03vDoAAClqC9dXHWoHR2P2Za1JvXaPgK kupjet6nv4S+ttYkcIffJFmbin2h4Ey06rmh/dL8/eQbcTW9vPwziVEBqw9MXzjCYRhQ RPT1t7tjWkppGYLoFzVnOkt9nlMlI2yznKUbR+WGCfuqWp2L/pDV0U5BfBsr3kovoo5S iPWTaKU6zTO0BP4GXqTnANIpvEWQih9WBgJvWiHQg+j23lpHoGvD021iWq2lJkFsZP36 kCkQ== X-Gm-Message-State: AOJu0YzDXF5rWroZ3cf4FDkDRkwilShYs+0XdA96rX23KFiYLpPmah2w Cfx9skDJSofziba6rKb+ZsCSW2ccg4FVYKNIIvAUVQ== X-Google-Smtp-Source: AGHT+IF/PbeDPHGTwTbaA2pV4mOFvfRBSKmJB7XTO8IsjUWL5YNJ6TW8QV1NfT/POdd4ka0OvkcYQJe1EpzjjtkHa0g= X-Received: by 2002:a05:622a:1315:b0:425:4420:c176 with SMTP id v21-20020a05622a131500b004254420c176mr3223260qtk.27.1701831492370; Tue, 05 Dec 2023 18:58:12 -0800 (PST) MIME-Version: 1.0 References: <20231205223118.3575485-1-souravpanda@google.com> <2023120648-droplet-slit-0e31@gregkh> In-Reply-To: <2023120648-droplet-slit-0e31@gregkh> From: Pasha Tatashin Date: Tue, 5 Dec 2023 21:57:36 -0500 Message-ID: Subject: Re: [PATCH v6 0/1] mm: report per-page metadata information To: Greg KH Cc: Sourav Panda , corbet@lwn.net, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, weixugc@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4AA501C0015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8q9cxiogrqysekiaqofpb9j5pn5hs113 X-HE-Tag: 1701831493-798767 X-HE-Meta: U2FsdGVkX18EywibXthM9c9Tm5pzTW0oiKZ0t2duWBUsy19vUgG2qHsDWw3VwyKDjCwIY4U38VEgDiZK1fdGK+Z3JWnfcmxG9QhNv+B85IdRSGSCQ0+08QSPgJN0pWLbate+ZCwAcMCEkj6K6ruP5fZRBPCkMdOIZNUptjQiDor9/78Oeb+WzxoTL1ECSjMRfFhK5Dt7hVxTmNNni03PiFmYN+kgxNwX0JwNh6lQSeMLTuVse0R+a5H/0MvnG/kZuArTiFxFuepQESYTK07WHJDTVHpNXrhBFFPrTU/xNOL3gurCwA/HJIDdznTCWt38TShi44yu/O5xukDDxSE8kEyT3k1D8gwbC5U8pI+IJvgPTORj9o1nwVAFwIvSXyFXmKyQPjfmi4Rto/0MJHWNCe0f7fZdoMkSZKqssqCO4L+xqU5qB/SZDFiO3JCs8ta+q/DpPD2fSiV6a6Ugew5mN8HWwb3xsKTOjPQmF6ICNJvs8zotmTG1qwOK1pbfYpYrLo3f43UxVJeVEpXphM04ZO5ESjIuWXExz2z4SLXj/KGKyAoqaR9o3dbwpG0g9jMe/Uq31MeUL89eezYzrNMDzRwYSQCK60d+Y1FJSDCwnMmcsm8qUVCQU00RENfAHd95A+QiSBTOW/sNO8UNT2jdFbtP6XC1nj1bR1zp47b/ReBfDKB929nNp0UBFTx0ErF9irZ9+CoGI+43kOjmutlLvUR71PsGCBwO4wJgrvUzO7qAw/Vl1sigDvGsJYDTlinB40HZaal0uuyOEgahBcaoagXL+FabG9gdAKq9aBHyWgQtTKN4jGVn32iL+WHLr1GIcE7j87fm0nYl8hiTtdrOkQZOnAJESH+ARwRtijZk2UBJpxTQNHkx4A2MsuS3T/vcYlgHkbyosjliHitW6bWScvRka/Q+u8lQ8X0WCoT35hQ516lNaGwxxkSuVWbM2nqKnRCBZ2PQNyEOdJ2sDg8 y0XW0yXO lLKSGG1kTl19uzwDP8CELsxcOWf/5cYpoA3ekVw9SZ3sWwf0LIQMaH2rZ/Usd0R6H9IOzqCL4cAcpNkF/yC7/xIHg6Rzd5jbsg5fpUUigBAXtUsvxM+9fh+HRBjy/71f6UT5wQ0+/DO1oi/BFjcI4tyNHdU4HM42qZxU9sRX0Fcn8CrthrEcHdLfsqIUSrPQuBLYb4bgbDMPvo7WXrkFE+WFebE+7wIrPJApZb0HIzQMKILe57bVnx/YrAXjpYQR5EKCEHUOOCKbgXcSvyIs2GFG8Ch8h1mKZeI/V4Zt7sCk1ALmHJME7kvpzOaeZWHojGIqX3n3Bjfi9COYbyuXdD/W0dXCqVCBuE/IMrhgc4qJDfM8FQE4LO/QaL7mrCBUfZjm2vh1/kcpYfpieY9kIOMrKIljjeRZs15Irw8iHI40MYUF6Vg46GvYUBnsuoDxG7uwV X-Bogosity: Ham, tests=bogofilter, spamicity=0.018801, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Greg, Sourav removed the new field from sys/device../nodeN/meminfo as you requested; however, in nodeN/vmstat fields still get appended, as there is code that displays every item in zone_stat_item, node_stat_item without option to opt-out. I mentioned it to you at LPC. In my IOMMU [1] series, there are also fields that are added to node_stat_item that as result are appended to nodeN/vmstat. Pasha [1] https://lore.kernel.org/all/20231130201504.2322355-1-pasha.tatashin@sol= een.com On Tue, Dec 5, 2023 at 9:36=E2=80=AFPM Greg KH = wrote: > > On Tue, Dec 05, 2023 at 02:31:17PM -0800, Sourav Panda wrote: > > Changelog: > > v6: > > - Interface changes > > - Added per-node nr_page_metadata and > > nr_page_metadata_boot fields that are exported > > in /sys/devices/system/node/nodeN/vmstat > > Again, please do not add any new fields to existing sysfs files, that's > not going to work well. You can add a new sysfs file, that's file, but > do not continue the abuse of the sysfs api in this file. > > thanks, > > greg k-h