From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C44C433F5 for ; Wed, 20 Apr 2022 16:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DA866B0071; Wed, 20 Apr 2022 12:54:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4892D6B0073; Wed, 20 Apr 2022 12:54:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3524A6B0074; Wed, 20 Apr 2022 12:54:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 252D36B0071 for ; Wed, 20 Apr 2022 12:54:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB608261AE for ; Wed, 20 Apr 2022 16:54:45 +0000 (UTC) X-FDA: 79377856530.22.20577FA Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf29.hostedemail.com (Postfix) with ESMTP id BFC3312001B for ; Wed, 20 Apr 2022 16:54:44 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id y10so4761346ejw.8 for ; Wed, 20 Apr 2022 09:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gfb0eyjgolqCkEqXLQdbBxhQjEK6tSD6hROI1ouv4Mo=; b=ed1XJUWXEKCWmhD+JR9f0O+9SweJMH0appcTJ14UiBN3RxWsSivFSQ5KGAEJ98Fi+N 590F5tX5gBVe4QuMuax+YzgCe46XJvMNUmzp9K3TXiSeuhLe32FFfPBSwvpIDY6RYdx7 8wikqUKk5L4OG2HOz6Gcu2FUq8oGqxnrGelMVn9IJW1ZY/upwlLSPioTSbpsffBzEwm9 h7oJnIfun3x5iRxcufGQ5EZFnh4WeXQMzZ9RuVT+xyQELlmG/pZGYwmMkGzvs+qAz0Sv z7rJrkNxx/cXzTJRTAuQXrIQtJbMwzthYpGWuregJRWrgDBAUIexHK9LgfiROdBwG2+p Qsxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gfb0eyjgolqCkEqXLQdbBxhQjEK6tSD6hROI1ouv4Mo=; b=dmfUdPKHw+bpTIUY3h/USFFFc0Psxh0tI+nQVZv1mOEgwQIhInh08THcOxPUSmVkaQ GWnCVQtNDtHAujo+b9YllCul3D/fE1wJa59uG6IHNjgRNzUooTu4PT5mD60BJPBy0fIA Y+ZBH+Rx0io7v09JAQwpHF88JKGGpKUeCyo5IfVDC9IheA92kVxRXi4P6d028ShLRMqB fvFECrgPtAxyDcd4ocenrh6ZMlR/YRp0XAa03BJuoN/a0uME8teqPh9SfOwss21sLUaa 5OWWsJeuVS6emiyZQpQ+yF5fFPUS+aGCqwtTN9y0KaabzGT15ZFls9FqufpELAM32vNH yU6A== X-Gm-Message-State: AOAM531p0ZNqYgIkqnwIkfjkQeTuiFe3Z6M19n4+w5qJf06VffxxunCB ZXda68sYrBWHkWq+0MJ2nownfHilkIEt9+OVBz4gDg== X-Google-Smtp-Source: ABdhPJx0Ve/WR/hieYcsMF1iBeBubzUupE0rJDQPdKddB2ET3tedAmCKBRlepVLhSDPltABkTqw0QgHvvAD3Y0wW/ZI= X-Received: by 2002:a17:906:1841:b0:6e8:872d:8999 with SMTP id w1-20020a170906184100b006e8872d8999mr19046949eje.492.1650473684276; Wed, 20 Apr 2022 09:54:44 -0700 (PDT) MIME-Version: 1.0 References: <20220420060221.1107736-1-anshuman.khandual@arm.com> In-Reply-To: <20220420060221.1107736-1-anshuman.khandual@arm.com> From: Pasha Tatashin Date: Wed, 20 Apr 2022 12:54:08 -0400 Message-ID: Subject: Re: [PATCH] mm/page_table_check: Drop all redundant EXPORT_SYMBOL() To: Anshuman Khandual Cc: linux-mm , Andrew Morton , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BFC3312001B X-Stat-Signature: rgw58sew6digmi9633na5maf6bj7t4s5 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=ed1XJUWX; spf=pass (imf29.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-Rspam-User: X-HE-Tag: 1650473684-705966 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 20, 2022 at 2:01 AM Anshuman Khandual wrote: > > Function definitions need not be exported via EXPORT_SYMBOL() mechanism. In > this case these functions just get called only inside their wrappers. Even > __page_table_check_zero() gets called without such an export. Just drop all > these redundant EXPORT_SYMBOL(). > > Cc: Pasha Tatashin > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > This applies on v5.18-rc3 > > mm/page_table_check.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 2458281bff89..5c2a96159832 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -167,7 +167,6 @@ void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr, > PAGE_SIZE >> PAGE_SHIFT); > } > } > -EXPORT_SYMBOL(__page_table_check_pte_clear); > > void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, > pmd_t pmd) > @@ -180,7 +179,6 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, > PMD_PAGE_SIZE >> PAGE_SHIFT); > } > } > -EXPORT_SYMBOL(__page_table_check_pmd_clear); > > void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > pud_t pud) > @@ -193,7 +191,6 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > PUD_PAGE_SIZE >> PAGE_SHIFT); > } > } > -EXPORT_SYMBOL(__page_table_check_pud_clear); > > void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte) > @@ -208,7 +205,6 @@ void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, > pte_write(pte)); > } > } > -EXPORT_SYMBOL(__page_table_check_pte_set); Hi Anshuman, See this: https://lore.kernel.org/all/20211124234754.l5co34dUK%25akpm@linux-foundation.org/ The rest of EXPORTs were added to be symmetric, and allow other drivers to use set_*p**()/clear_p** calls. Pasha