From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D80EC54E67 for ; Sun, 17 Mar 2024 15:15:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 786AA6B0087; Sun, 17 Mar 2024 11:15:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70FEE6B0088; Sun, 17 Mar 2024 11:15:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1256B008A; Sun, 17 Mar 2024 11:15:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 46A746B0087 for ; Sun, 17 Mar 2024 11:15:20 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C7CB5160498 for ; Sun, 17 Mar 2024 15:15:19 +0000 (UTC) X-FDA: 81906879558.20.B0E2C20 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 0D65FC000A for ; Sun, 17 Mar 2024 15:15:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=Lg6uLvVq; spf=pass (imf22.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710688518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x8Bq8ricK7SpfnlrwZMSGXpOWpIDbDpoqdg8e9TW9uQ=; b=3bkZvMpMeQ6eF/zEoNZVtqzh5OQmiHaTdGQQZ/lztAqNHANjY9lLAjkpnztNFeQyEtjHsQ c6HvtrFNSY2qKb9JN6iFDtMIy/PgEBfc/g6BZPxLtv+lFt6ebgLNb7IkOn0VYeBnMav6DJ ZvfUf+j4B0YYql0LFIG3r+nzQuAqsLU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710688518; a=rsa-sha256; cv=none; b=w7d7vEuCoHkkI6+8unbzgpz0Io3EaNt6A4jJV9R3P9XxBvP+nWo5d/cGqKXoQOwiVsdi+C x0DE7PkFvid4IM1RW3ETtt1+aaqr4hoe8gdaoOJrTgWuQDGiVZ+Vsld1A2+GAsvKEcqSvo TzXHEYjDImTQ5FDF89pVStSKYQaBbxw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=Lg6uLvVq; spf=pass (imf22.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-42ee23c64e3so14998671cf.2 for ; Sun, 17 Mar 2024 08:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1710688517; x=1711293317; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x8Bq8ricK7SpfnlrwZMSGXpOWpIDbDpoqdg8e9TW9uQ=; b=Lg6uLvVqQS1PRNRIkY7nSMRgOwG5xOXR8Gh0yxqixSdOLvILsh/YPLoGKmwOhh0bNh GRnTJogrmqID7XD8ye87ZWcZlRIr6t0xXv683boDWr5Z6LNjwZqLgw54iAf59fDbBD0C j45s4bRVZJa75qJxZ7sROWaKlyTXfR8iXIFD8ozrp7O3idZz9WOImgj/tr01PG1YkkW7 IGhRhrC8F2K2Moi18RfAy/SyDaAi9hYCcQBdP64Jm1DwKc/eu53Q2vD4+5bQ33hcT2dA zMB4IgnRVusXlKQpLcc6822PdACZjMDbpWRSF0VNe9NoNoimA0AwsrcPXB+29a4xCsyv LhbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710688517; x=1711293317; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x8Bq8ricK7SpfnlrwZMSGXpOWpIDbDpoqdg8e9TW9uQ=; b=YasNeq5tskdo1Vqf/IaokKSjJfKAn3TBD0EJJp8wP0QJVlzMNXpZPHSfP7OeU4+Oj5 /CD+fGwrcA9/MRX/o8oj9QVqXBGcthOqDiDUywsnZbEz7shpMz1VGYsnRCm6yicnAkLQ Eat0yCzSowlkmmvGvSjzNvWbBDDwn61iP7LHEaRadTShkL2PB9/6KBB/Czo6/4x2iVZn lc/RmThJvZ63cWAtn47JlaxWN6bV05/G9Gce8gYhrbgM2fqz2O3dA5iSlvjqH9f37KGO UA4clKLIyySvmia/JJigABboNU8YKK1HPA2MLfwBpVk9CwDRA7cbEtGLJR2rU/I2EcLa gGGQ== X-Forwarded-Encrypted: i=1; AJvYcCUYsPQyYpD4f46IBodeMoyODp9LXufvw1gbYcmMluiydabhC8BV+z3TZxBUaP7udKzHU/W4PGtlrE+OBpJCkMReiRo= X-Gm-Message-State: AOJu0YzrJ9/TDJXrg00xXsD0fQ5kE5mJeRDSOuFjHob2QAI+R1J6W8i1 IXbnk/+Qsnzv7KP5PEg4eqZkZNd5LpprsBR+LeWKxXtTwMeZ5Mg8aIc4AT2kdhhcqw5qZ7go6iG Q97sqbjSujS0DnrO8W8QakI60XLuNZLx/YeGzVQ== X-Google-Smtp-Source: AGHT+IHRAPcydBRpMUFgj5XZjiHwDEp09zHAlmm3AVMyNFl3KpX/jkVv43SatvVAp1AB+6jpq5N7cgzHOWpDQKo/lD0= X-Received: by 2002:a05:622a:47cd:b0:430:c139:ba12 with SMTP id dp13-20020a05622a47cd00b00430c139ba12mr5702897qtb.1.1710688517145; Sun, 17 Mar 2024 08:15:17 -0700 (PDT) MIME-Version: 1.0 References: <20240311164638.2015063-1-pasha.tatashin@soleen.com> <20240311164638.2015063-5-pasha.tatashin@soleen.com> <0c6974b4-ba1f-474c-aed4-6c06d26ddb0a@wanadoo.fr> In-Reply-To: <0c6974b4-ba1f-474c-aed4-6c06d26ddb0a@wanadoo.fr> From: Pasha Tatashin Date: Sun, 17 Mar 2024 11:14:41 -0400 Message-ID: Subject: Re: [RFC 04/14] fork: Remove assumption that vm_area->nr_pages equals to THREAD_SIZE To: Christophe JAILLET Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, bp@alien8.de, brauner@kernel.org, bristot@redhat.com, bsegall@google.com, dave.hansen@linux.intel.com, dianders@chromium.org, dietmar.eggemann@arm.com, eric.devolder@oracle.com, hca@linux.ibm.com, hch@infradead.org, hpa@zytor.com, jacob.jun.pan@linux.intel.com, jgg@ziepe.ca, jpoimboe@kernel.org, jroedel@suse.de, juri.lelli@redhat.com, kent.overstreet@linux.dev, kinseyho@google.com, kirill.shutemov@linux.intel.com, lstoakes@gmail.com, luto@kernel.org, mgorman@suse.de, mic@digikod.net, michael.christie@oracle.com, mingo@redhat.com, mjguzik@gmail.com, mst@redhat.com, npiggin@gmail.com, peterz@infradead.org, pmladek@suse.com, rick.p.edgecombe@intel.com, rostedt@goodmis.org, surenb@google.com, tglx@linutronix.de, urezki@gmail.com, vincent.guittot@linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0D65FC000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qb96de8em8zccug1gptq1gudti643fj6 X-HE-Tag: 1710688517-218845 X-HE-Meta: U2FsdGVkX1/evnKAqZSNsTnNrr8xddNa1cJSE+1ocmek22j6vm/+OAg3YCMvmbDbUnlJHjC7dSF/sAgmkqL3eUBNumqJTpg6uQNbY/XMZr1FzXBkiQPdWMzAVKCSybZDVBKbCpQ55U/uBmgTXjcP/v0ZzZoMcSePNJfvHuGSOfOuJ8Xc27kHGsSNTc97wbzZ8139LQIt5DLdA2XJDf7L7zJB/RKNl03H8mc2U+9w8IVzbkGc7voYzyfgSXIGg+4xx3Pzlw2Sbd2uWbh+2aQL6sXyWuNA5oPreZGoELk628L8rOKkQkNtXpcvJgW9WzSAMBcUoH2B27eDRlyvQGlD5K3kSwPXLEA1VLYLbFZ8hEwcJI0hnYep0ZImmQfgyMLEuhnB1VMAtTWF+23sexzkWEvhSjxW0kghYkQy031VktU6WGSBPWe63FxQprEJxDEBrtPme0V63K7B4Xurxx75/tSz8tDUZps/Kbf6AZwv/LhfpL2x14joEgPA6ODzjZ7OFcyhaltWY3D0Mj2ipL4/3R2BUFjidXzGQ/c2DuETMIo5HLSqBWL/R2Exj6QhzW1viZ49jB5p0ZJwTDBM64BVZjaOtGRhaXrywynFgHtGf71JZpD/f37riHO0sDvunkmRcy8cb7npAUTgBJY8gNAZcWVaXw6mJL9zo7Tj/XLzJvVwd+okHuiF2QkMKjPezpPHmERK/tvv2IW8IJodWD6NhhhdPiSY4tjLuE8nIIPRyt45TRsFDwyrIkx4VqjzPxbc8FBFgh4qvnEhqmVj64w8TR/kfJhtTvDKOS9VsWGE7ee420WE/CIigvs/oml+mXCnLa+ey4dgGF8nqUueLfBWXbyKVPnrpl/uQdFv4T09pGHKukp1dS2LOVXbNaiGF7/i8ldqTGEbJRuyULUssxW0glTkaz9CmkhdiZw5xTL5PsRPT4GB6HRUPHVfaPSxeR4p7LCusyxU5MQBbbvAlVg hfTQrwRw glEeVBmGaBQ21o6Fdmf+jJUkyHvmum22xVf/k4/FKFwIlHdxh2noHZ2a/3nN9cbRkiMN++8K9WpI060cnSQ++GjLWPYnL89ZqDjwsXdU60M5qtjkqXz3dmieKTu5SxX5UsHieoIB6r6/PnbW3GesnLXYxAKVjsokLWb/4MrdTGw2Gr/C4IgjBt6WrhwnfYVSaEJ21igh7+6vGYkiHNkWJalikjDElGLEYi/hOg1oTAncwaCkDbThGLoDOIosGGoPZF1qO2gMvz2yzdqxu1Lphmyzj2Jj5kz2UQQFSjAsAOOjOBLYJeBPzZHR5/88KU4ktaz23CKNfP2CzD/GlGp0HtV4dsCKG5zS2qjiYhs0vj+LfLfqSaOzIIdwnzDrtHrZmGGGUutXVnFPOyeh4QLSjaBA8jEACr9+l8JRWWfnIN/aVL10= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Mar 17, 2024 at 10:45=E2=80=AFAM Christophe JAILLET wrote: > > Le 11/03/2024 =C3=A0 17:46, Pasha Tatashin a =C3=A9crit : > > In many places number of pages in the stack is detremined via > > (THREAD_SIZE / PAGE_SIZE). There is also a BUG_ON() that ensures that > > (THREAD_SIZE / PAGE_SIZE) is indeed equals to vm_area->nr_pages. > > > > However, with dynamic stacks, the number of pages in vm_area will grow > > with stack, therefore, use vm_area->nr_pages to determine the actual > > number of pages allocated in stack. > > > > Signed-off-by: Pasha Tatashin > > --- > > kernel/fork.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 60e812825a7a..a35f4008afa0 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -243,13 +243,11 @@ static int free_vm_stack_cache(unsigned int cpu) > > > > static int memcg_charge_kernel_stack(struct vm_struct *vm) > > Maybe s/vm/vm_area/ as done in 03/14? Yes, I will add it to 03/14. Thank you, Pasha > > CJ > > > { > > - int i; > > - int ret; > > + int i, ret, nr_pages; > > int nr_charged =3D 0; > > > > - BUG_ON(vm->nr_pages !=3D THREAD_SIZE / PAGE_SIZE); > > - > > - for (i =3D 0; i < THREAD_SIZE / PAGE_SIZE; i++) { > > + nr_pages =3D vm->nr_pages; > > + for (i =3D 0; i < nr_pages; i++) { > > ret =3D memcg_kmem_charge_page(vm->pages[i], GFP_KERNEL, = 0); > > if (ret) > > goto err; > > @@ -531,9 +529,10 @@ static void account_kernel_stack(struct task_struc= t *tsk, int account) > > { > > if (IS_ENABLED(CONFIG_VMAP_STACK)) { > > struct vm_struct *vm =3D task_stack_vm_area(tsk); > > - int i; > > + int i, nr_pages; > > > > - for (i =3D 0; i < THREAD_SIZE / PAGE_SIZE; i++) > > + nr_pages =3D vm->nr_pages; > > + for (i =3D 0; i < nr_pages; i++) > > mod_lruvec_page_state(vm->pages[i], NR_KERNEL_STA= CK_KB, > > account * (PAGE_SIZE / 1024= )); > > } else { > > @@ -551,10 +550,11 @@ void exit_task_stack_account(struct task_struct *= tsk) > > > > if (IS_ENABLED(CONFIG_VMAP_STACK)) { > > struct vm_struct *vm; > > - int i; > > + int i, nr_pages; > > > > vm =3D task_stack_vm_area(tsk); > > - for (i =3D 0; i < THREAD_SIZE / PAGE_SIZE; i++) > > + nr_pages =3D vm->nr_pages; > > + for (i =3D 0; i < nr_pages; i++) > > memcg_kmem_uncharge_page(vm->pages[i], 0); > > } > > } >