From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9352C3DA4A for ; Thu, 8 Aug 2024 17:38:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 635056B0082; Thu, 8 Aug 2024 13:38:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E58A6B0083; Thu, 8 Aug 2024 13:38:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AC856B0088; Thu, 8 Aug 2024 13:38:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2DF8F6B0082 for ; Thu, 8 Aug 2024 13:38:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E1D2A1C3B3D for ; Thu, 8 Aug 2024 17:38:23 +0000 (UTC) X-FDA: 82429787286.27.AD5D505 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 27AD7C002C for ; Thu, 8 Aug 2024 17:38:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=tA+3so1b; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf10.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723138654; a=rsa-sha256; cv=none; b=rSLqlWt6rtBLy8h2bLdFyHsX5EcYRADGke+NMwsIQsNYPB3bJD5PlMwnUzVij5v0HUzkkQ 3dpcqk1cxetH/2lPmIKL1HS57BabdwbqReH4TJAR0tl8iDFLIrsM+6QiJkJNG47Nq1DYOz UBF2EfzQim3Dcm1PCIiG4KW2vxn03rU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=tA+3so1b; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf10.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723138654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ocAJDrTQkqPtVrAouvpO6jBQST6L6jBb7w2tfCG05PE=; b=HDCxNd7t7AsBa7N5Htq/LMTbmaSoYMTpbF9jLLU7Cv1PKvZHfuwOhGrQIYuMxhAqvy4Ifl BipPdnbInz2axLUQUhBCeAz7mZ0QDQjAoLvCuhy5pJSsZf0ARBtEf2zDREoCmjkT0ewkgQ vVSwausLQolexUP1ygH2BvXpFJb7mvo= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-44fee8813c3so7605491cf.2 for ; Thu, 08 Aug 2024 10:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1723138701; x=1723743501; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ocAJDrTQkqPtVrAouvpO6jBQST6L6jBb7w2tfCG05PE=; b=tA+3so1be+lDcvKQoKSlpa3iKXFSZazxCmwWnjvxt6Ddvg0kv0mUMryHLfR9sMIJyJ Z95pqwkzREtRi9ChPVq5P8jeUTh2nUiEEmUS/Xu7vwI+riSBjJXQNoKnMFCzzACuA64v Gxw2RuFRc/99B1KSA+wPm9fkmuSmvGHtBGZvcfqQNlrkMhPzhW0Gv/+eL0/SNH2vSyTr c7NkpB+/s1+WUsCr+3O1b5ZxpEWqEygZ/vosx0tt8cksMMMf6DzTVJyoIa2lhwuclKEk xuS3hhVId6Qoe9Ya6CbORmAdd3sADvftCnYKRx7v69OMtnuZi//kufWpdtrh4Pw+8632 l2Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723138701; x=1723743501; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ocAJDrTQkqPtVrAouvpO6jBQST6L6jBb7w2tfCG05PE=; b=GcHiuhUZfAQ/XJGBT2U2Dhha+1JlIitkyBuSgt+L7E9TAPvjyD6YW0e+MrHgrYU9aa VWbYXORwmUmRE9jPBckrOQNlf8BKvXc75oG8KfxpKtONgzEh0Tl5aJ844CgaQFfsuN9E wN6B2kaaVo/KDdZMwQVHR4ytFrSnzoG303goFSvKCdvC651Klq1gbD01nM+0rpGMZgI2 hiIIonfoVkzQV0SQ/eB6PJkP+k/f91Yn2/B/2xYx2WvOP6E2M4NoYabSyRs0hhG1arh8 JadckBXitPFW8NPbr9QYAR0VQ4Cy11wLA0Fbdz0dLbO6PYgO4uOChA8T0WC2FRf600xD OB2w== X-Forwarded-Encrypted: i=1; AJvYcCWOV228cNPFtVjfjuIWPL5FsxGdcpjXXOQ+LSQQIcI05lyTgovIdwiafDg3s8vszXN01wIWX/mAt2ddycJFi0WAeW0= X-Gm-Message-State: AOJu0YwYU3mdf/EsbEVWwH3xsCB4jWlcC9HXsSYfatRJybb0b4AMCB3t ghfzlZPuloPITL5vOdWD4pLa5k3KzZWybKkPw9xQd7iBUSBM/QIwN3XGpVaHSEWDGx1GB+XR48P AaSJ460nf0gbS+kfZZ97sifVCokX4Q3WPCjWnBg== X-Google-Smtp-Source: AGHT+IE6o0qf7cNLixVlu3yVupxhxh/ptXeCvvwc+dwwETtd7M4Sg8SqgxhhW/X7CIyOeHv/Ao1yGWqyQOb5skvlEoQ= X-Received: by 2002:a05:622a:5509:b0:447:ebc3:bdaa with SMTP id d75a77b69052e-451d41fc177mr34125541cf.9.1723138701270; Thu, 08 Aug 2024 10:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-2-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 8 Aug 2024 13:37:44 -0400 Message-ID: Subject: Re: [PATCH v3 1/4] mm: update the memmap stat before page is freed To: Yosry Ahmed Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, david@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 27AD7C002C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: e9bpp9ik85f3co76ng4go9kas75iqpun X-HE-Tag: 1723138701-116300 X-HE-Meta: U2FsdGVkX18Dw3kdQqmwx4vIKTHqq5Gb+BM1BtmL3tB8QvrRbWzYjBCbCmz4aY63hB2jD7Cg6SBBhw/d1IuOVN1Y1RCH/WUyMCedGiY2Rqk4FrMi82SdHZfHS0vzECtFK/NbKfA8yyAolJmMa3NbBDcRx819R8FNTjx4DvvV3Luj8N5NoB+ucAVnhxWDt3ClmCQ0eRfwxSHNri4rkA9IShnCOMpQ8m/xZpJ5Ip6QHSQiX3JlgRZnD5YFZfw6DoKaP+FCjMZTzeNzsA9LY4n4a9S8bVbn6VNCNI5WMPxoMYw1QT2W60h/zPIticBJCfFwXAMZyVUlnQgukxQ2VSXi1TjORJ3Tz80jbevkYUVEZ58ALNR5Ht1XGMTx4/EFe/dvBiBPlSNXQ8+fXRS++y148sqF4UkDsxsv7gj32X+dAOv6bNZ39e3QI5EfRmJEmHyC+A9CHrHKxiEhlInWjY0pdgi3V4S6xwoRPB8uSNglptKOBlPi7esag4Lmtku5WAdLRyRkuO/0tlwRlm+1h68glOOyKUs2SaNoRRmBAE4XUan3ciLeElUmgNp9JmYZMnxbMtRAReev/ga2QB5iUtxWnKb+spExMDgn4jYX4k6IXs97AHu3vnFWcLT4sFubcZy4o7RA/mRM+FlP8wxGPZ9pPmLn52LRSevyVoyxlXfbcTGpH3b4pET3H42j+MdNJm+BU4H6s1kaZReJp4cP3ZKTqYVSOUozfMuaw4IK3H2W/1sHk9qxoHmtNLkH0yOmFJS+RYB9Buufm8xynlj3+47RuJIyUm43dV2G1G0x2bdsFOXLCwxYc4bj18eiSMfjY+l5dHmy1gWKHDCELHXWLv+wG8tDzulwEFa3WUS4AcT8ldWLtKCp0+jo3yCPm9xSbP2EfXst8sLQEs4kRGdhQZd8KoE0cPh2LVxFjX0WyKrK5eSdYm9JYq/UJyvkI5OELy6owccMtDxXC9A8+EM1Vbv cK8IVZjI /R+puFrx7GAJz5NigZ9YFJ0JKKG4+Xssz4OXls+TKIKaRMYcPCZ65OVnTWK0iKv9nkc9M3VFq+y7nm5yTyHz6y5cjyvnlQj42crTiVzqthZSN263S5QwPkPB3PIIrT7Ow+IBtn6FdgEFe3Z7JD7yZSvC7fV3c5X/bLQF8baPlxIgBlx8F5mGAnb/URDyGHX1c16e5onGximwzvXcs8EJLEcNWX6mJJW+U8WTDkgvWW7HZrqCS38BchkgzLlwiDwoYX0A203AtPZyV/j4iKXAs3PvLqzMW5+cfhkbTpMHJli9qK4DOoYLLyyWn/9HOpIaeAMDoziop+BAhAPFv4/tirs7AD42kM6rCPemDyPI8YvN4y4U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 8, 2024 at 1:21=E2=80=AFPM Yosry Ahmed = wrote: > > On Thu, Aug 8, 2024 at 10:17=E2=80=AFAM Yosry Ahmed wrote: > > > > On Thu, Aug 8, 2024 at 8:42=E2=80=AFAM Pasha Tatashin wrote: > > > > > > It is more logical to update the stat before the page is freed, to av= oid > > > use after free scenarios. > > > > > > Fixes: 15995a352474 ("mm: report per-page metadata information") > > > Signed-off-by: Pasha Tatashin > > > Reviewed-by: David Hildenbrand > > > > Reviewed-by: Yosry Ahmed > > Actually although I think this patch is correct, it shouldn't be > needed after patch 4 because we no longer use the page or pgdat to > update the stats. Good point, also there is a warning that pgdat is not used anymore. I will remove this patch from the series, and clean-up free_page_ext() by removing pgdat, once patches 3/4 and 4/4 are reviewed. Pasha Pasha