From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C2D8C64E7C for ; Wed, 2 Dec 2020 18:17:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 891AD2173E for ; Wed, 2 Dec 2020 18:17:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 891AD2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ABC706B0036; Wed, 2 Dec 2020 13:17:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A46266B005C; Wed, 2 Dec 2020 13:17:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90D8F6B005D; Wed, 2 Dec 2020 13:17:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 768936B0036 for ; Wed, 2 Dec 2020 13:17:35 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 356738249980 for ; Wed, 2 Dec 2020 18:17:35 +0000 (UTC) X-FDA: 77549150070.01.hall57_3302051273b5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 027B81004ED8F for ; Wed, 2 Dec 2020 18:17:34 +0000 (UTC) X-HE-Tag: hall57_3302051273b5 X-Filterd-Recvd-Size: 4166 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 18:17:34 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id d17so5775917ejy.9 for ; Wed, 02 Dec 2020 10:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UbYrYnF+KurepKINrBSoJHW5saproNT9jRib5mamPqA=; b=ltHzeqRtIlnnIborJfCkzJ22Oat0zUZd0BiN89Z/qIOVJPyPs0Yy1BU0tFkZt/vmV2 fr5o43od8Q8LCNDhCJjsdpiwnzKqbqQ+1uMayEaLVkXvpCqqsvq0jpSPmrCKEpUzo1Gm XSjN0l4/M9lSvX5zXw8X2y65/IdwxG9cWMNdhRkUb4RCeSzS3WIi9d1bKD11nRx3Gxu/ wXscvhBm8RFf/8xmUsy2tFFSK5q14niGiJOmTb+YxgqC22n4+TXU1H3rYCf2NFRt+Mbq kRlGCfAh0q+1okflQS//yQCOuFjVl6bYdUx6943oB8CHJ1hL72kPzMa4jbvKVGoZfkdy ouYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UbYrYnF+KurepKINrBSoJHW5saproNT9jRib5mamPqA=; b=Vn8/6zF3r+O3hW2XD7727deEgoNTNf+0aX+WBiRdr15lwH58sPQp4Cf4+rVeRCECzQ o9ifRbmom4d9/zuE1GK5o4znR9+diarbvojdf5AMfwsX6uzHTNm6EM1Jf3J64AkLSmIb UPubJrqCfyntBgxKMI2ITb7o8UBt72tkXmUpCHIHkIX56Fc7IgJKhACm+Q46+VFV1oNv 0Tz3xerY79nll1rEbJjTsDGrSAg580hkMWa4itbwXnvgpv00Q5PCJBiIpMbZUEhzF3/Z juYgvdVsg+VGiz78nvp8RNpPIaWa/OGnk2zOOcw9aVTAGO4+sfJvXS2PemUt5pqaVydv 568A== X-Gm-Message-State: AOAM532isTfz8lssZGLRT8+bcJ6WiL+jfyXizPFPp/NKCWmX4kSwfF0D GQ/J1ZQZeSvA/po2LpbSvvTzBU7d0KbsmHWZipdQEg== X-Google-Smtp-Source: ABdhPJyL8/Gl6aIiQMnUmPn+lq01BUWHv3MIMEyR/bYpSxrGLu/Ujt+d1e8CE783UdjpbSFMXIcQMlzIeQS8U+zwF+Q= X-Received: by 2002:a17:907:9d0:: with SMTP id bx16mr1061095ejc.426.1606933053277; Wed, 02 Dec 2020 10:17:33 -0800 (PST) MIME-Version: 1.0 References: <20201202052330.474592-1-pasha.tatashin@soleen.com> <20201202052330.474592-2-pasha.tatashin@soleen.com> <20201202162958.GK5487@ziepe.ca> In-Reply-To: <20201202162958.GK5487@ziepe.ca> From: Pavel Tatashin Date: Wed, 2 Dec 2020 13:16:57 -0500 Message-ID: Subject: Re: [PATCH 1/6] mm/gup: perform check_dax_vmas only when FS_DAX is enabled To: Jason Gunthorpe Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 2, 2020 at 11:30 AM Jason Gunthorpe wrote: > > On Wed, Dec 02, 2020 at 12:23:25AM -0500, Pavel Tatashin wrote: > > There is no need to check_dax_vmas() and run through the npage loop of > > pinned pages if FS_DAX is not enabled. > > > > Add a stub check_dax_vmas() function for no-FS_DAX case. > > > > Signed-off-by: Pavel Tatashin > > --- > > mm/gup.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > I have a patch to delete check_dax_vmas that is just waiting on me to > figure out how to test with dax. That makes all this ifdefery much > simpler Hi Jason, Yeap, that would be nice. I made this change as a preparation for moving __gup_longterm_locked into common code, so when you send your patch it can remove both versions of check_dax_vmas. Thank you, Pasha > > Jason