From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67088C3DA49 for ; Thu, 25 Jul 2024 14:25:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D89B36B0089; Thu, 25 Jul 2024 10:25:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D38276B0092; Thu, 25 Jul 2024 10:25:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFF9E6B0093; Thu, 25 Jul 2024 10:25:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A312A6B0089 for ; Thu, 25 Jul 2024 10:25:58 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0DAEF1610E7 for ; Thu, 25 Jul 2024 14:25:58 +0000 (UTC) X-FDA: 82378499196.10.C921CFB Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf13.hostedemail.com (Postfix) with ESMTP id 427D420027 for ; Thu, 25 Jul 2024 14:25:56 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=m8Jdiq2i; spf=pass (imf13.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721917508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v4BFn3DT43cgevtotyewIlYg/Ec//Lq/B6vnxLTCmlg=; b=o8RAErPIiM7vQpBjEloAwGEIWEISHp6EAaqQp4FKEq4EzvUfQHuytVO8S3W+W0NpJ29tOd MIMQv0pfKKel++H0aBKl7ag3pGUWi39GZ/vTSqYI5T1c78OqRYBmKtYXqJ2dxnoZILMn8X dVMzHPc+BEYdjZ+mPzArZoLyj+ZDomk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721917508; a=rsa-sha256; cv=none; b=ofGp58FeiVMjk+xNem0EnOZvdFRR/sONTzLF2p0IR9PkR9YorRbqw0zkFsoX73Av3Fq5Nw +dD3e0Ml4oXrklhSMyeUQyEUHac3cU7wnY76qPrJiIq8usasuGbtAWTqfNO6ljOltJZLjn rKOxIkVgU1GzkpCp7ascZRyJWGSjito= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=m8Jdiq2i; spf=pass (imf13.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-44d1eb90522so4601741cf.0 for ; Thu, 25 Jul 2024 07:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1721917555; x=1722522355; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=v4BFn3DT43cgevtotyewIlYg/Ec//Lq/B6vnxLTCmlg=; b=m8Jdiq2icTf9Dj8r+RC8Zd525VyjRKr160QRHmgWSKcmSVfAbhwhgqx0DaclQGnv4m 2ot7/fHq7Jja8Jbg6tujigdzGrrjFw8Sxn4EsQE8KEim52jnsReqejRnOJLlLtj/guni rwvTKoNjaSleaWKPfmuTOfGHv2W6gklcJxxh5XvzNxBbUm5pONT8eCgtLCdzy9EDuFzF V8jXJSKrS9wY1C2R/viZ/mBgG7nO6xEABlTb211Ps4WtlHxgfz2N4YutGZfi7mQPiB/s DrPtK898sssttbohh4WCAiSm2pbPNEfUpoSFifbm/7Y9Vg5NznToB6C8Hhb/Ejktb0Gt TjQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721917555; x=1722522355; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v4BFn3DT43cgevtotyewIlYg/Ec//Lq/B6vnxLTCmlg=; b=Tcg7b+d0GILNmSg9sSmywLlZ/Ycf2gTNrmDM869GzMj4xvVIFa6D47bwu1Gbr0fDWM 6vHkzBiPnfUMURRq6FM1uudU1YpPkdi6wfmdeCYxuLjEfFJz8ToJWhj5hnTzAONGIUr3 JduUCnbp255QJggVsrrLlwtfxnSCrjjbnJfUFWb34PddBaAsLhPBB+2lWbHiRu3GRB6n Te0Jyigrzxe6fMZqtwVIOKMgroMcHSqRJKOA5zsmr0M701ec0ooh7sDQRoo5OMHR/nW2 CkKqQcrNqAubRMYwJ+vL/fLNeSKHiE97ocVohLE8OEGquargMp1m5IJs9lMAQycVSdXx I0qg== X-Forwarded-Encrypted: i=1; AJvYcCWbZ5RezHS1FC3Sqj6BLDLiOBnLZCyOffr6xp0uTgjPFimTzOLw1CWQ8V2NQH9qVdulc9EgMTEX1GwysXmcm76eLGE= X-Gm-Message-State: AOJu0YwH0njTw2TDtQ6qhdztTxdBYaK4OymCBEtU1Aj8g1OgCbAknC/3 yGCvmLoBdsJRVE10udfwXAEu/2KcDsObgJ9i64XoGIrUsCTtVTiZWohNofXEboXw7h88vRrV4bI pY0XLUFBnD7XnH3y0cqKeY0+VuN+eRytts6S+kA== X-Google-Smtp-Source: AGHT+IGAO4P7T0XMvKIOXQVTUEE0Gf1K/l8rsVu08E73s3q41wTcsWaGYT0emRfHfYVA/MAnmP3HtwiaJ16cT0INeDQ= X-Received: by 2002:a05:622a:514:b0:444:b2ae:97ac with SMTP id d75a77b69052e-44fe48a18c1mr38217791cf.50.1721917555177; Thu, 25 Jul 2024 07:25:55 -0700 (PDT) MIME-Version: 1.0 References: <20240724203322.2765486-1-pasha.tatashin@soleen.com> <20240724203322.2765486-2-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 25 Jul 2024 10:25:16 -0400 Message-ID: Subject: Re: [PATCH v5 1/3] memcg: increase the valid index range for memcg stats To: Yosry Ahmed Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, shakeel.butt@linux.dev, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 427D420027 X-Stat-Signature: 6314ok4nux7c1u8u1fzff5mxj6h86siu X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721917556-693569 X-HE-Meta: U2FsdGVkX1/R0c/r1hWgxpBkRPyRDjGhaxwzPe4JMQ6NwmrqTvx8VNt2h7THEEZwG3r3U8IwwAihQVxiPchlXW8IiAUoqAgr++AoliRsgycKzjBfvlrzP6xWpSFSndtqYZ45Ycr0PeUWArpOaj4u4Avh8KTm4/R73KLB9D+mGSPYWgiTAnD4VpcsvORpSLoGEdw0tzAEa3wskT0cjj/Ka6fPi1O9LqwHYfD/xmbr7VWaTCvN5sv3jLYr/tiEi2OSfM1Ln1ecTfrHNgAov42MgXzgxY2dhtyhh+2JjdIWC/ij/AWH/MubBJz9R9KAVMTKuuI/y7ZtO2fDE0Ck7GqdfGUz7hEiV8F3biXgxj5uy98Z9cYGKbhxqPqjMEa52dZl5Nu3dd0xHS9Th59IUEj/DxEPEboyN7WCNHbj6H5uMP493FEcDr8rkH/1nWtOvRJ5xB33RTVzSM7pgdsiYEiOgL+5U9vRo3zS1oAxWe/9OYn7WiitLjN3ooJPCswXp/iFyvtXus/dptW/pAj2e6TuPQAPTpWAMAxCn4+4xMKZFF6Hi994wOIJNC0eowoTBkWl61bh+nlTF6FzHIzQouxjZ+XzA3cJsOY/25+qXzQwR85zi0BtLSD2z+LRLOxminyaGYBO7MPY2jphOF+aUIxNyBIjHbELh/7MAc1FZajYEwuQV3hCZ5jf94Y9IcwuvzQnZJ5BszdsKnLljyFORX0afhnUX/s0rbHRrVe/cAz0XahFb4YP5ymKN21UNtl1c+G7xfs7ISQWd4Es4btLl9XmGtJPwMoSz3hpfrXhvTOTsKlUGqhFMasDT1EY3kqNyUCPwI05VlzQpCYn3ufEhQpYacB2s5e27XudanKnl70TdzSynbgvppiZd+N3hVs0oIzBjSILNUsBDOl8Bnu+kbiCjqQiGe1IE51M3wB6Ed5WvDp4vcTBvfvfMzPJsaSXN4mbJ1486DjuN6FEHhOkH5n RWTR/r1C qoylVJgRAyCRBKOcW7SkWVWgH4GW/32ZkNwA7e0rLudqxqHoyRpopc5z+2aMk71bFwBz4KnFOWnyEMoCnWvHoZw51YYq45+WyzdEMu5CebTYTQde3YKX/8s7cccGH33DtU/Zj6Uo+YafpxM1rvAday2yoCD5ltW1b11jdOXZS2zYI1yXq75HfzJGc7l53i09aeVES8SRDEQm1FOTp3rYQsi2pvcW10JaDq0Z4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001331, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > #define NR_MEMCG_NODE_STAT_ITEMS ARRAY_SIZE(memcg_node_stat_items) > > #define MEMCG_VMSTAT_SIZE (NR_MEMCG_NODE_STAT_ITEMS + \ > > ARRAY_SIZE(memcg_stat_items)) > > -static int8_t mem_cgroup_stats_index[MEMCG_NR_STAT] __read_mostly; > > +#define IS_INVALID(index) ((index) == U8_MAX) > > The use of this macro extends well into this file, should we use a > more specific name (e.g. IS_VALID_STATS_IDX())? I will redefine it like this: #define BAD_STAT_IDX(index) ((u32)(index) >= U8_MAX) 1. A descriptive yet short name. 2. Check if the index is equal or larger than U8_MAX, which feels safer. Pasha