From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7358C43331 for ; Thu, 2 Apr 2020 15:14:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 76E6B2072E for ; Thu, 2 Apr 2020 15:14:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="FmCRcwxM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76E6B2072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2490F8E0009; Thu, 2 Apr 2020 11:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FA628E0007; Thu, 2 Apr 2020 11:14:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10F888E0009; Thu, 2 Apr 2020 11:14:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id ED8D78E0007 for ; Thu, 2 Apr 2020 11:14:01 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B5EB32C6D for ; Thu, 2 Apr 2020 15:14:01 +0000 (UTC) X-FDA: 76663260282.15.hall38_403ba7fed593c X-HE-Tag: hall38_403ba7fed593c X-Filterd-Recvd-Size: 3710 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 15:14:01 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id dj7so2745249edb.12 for ; Thu, 02 Apr 2020 08:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WKhRMc892s5J3SEByy2exIsvz2J4zE9FBkgS5UdcNJE=; b=FmCRcwxMwa6FxspThwYLZYojVuq5qJR6W9C29g9WnofOMQHwJUxssNKKX53oEmHAaV 7OdwB8vfafKvgUMFFCuShhRA7PHZFZVBKAYEMP8+f13HxsSbUVAAEXhY2tiYh67PDbOZ 5LuKTHcoeahEgyFFv1+nFiDhKkxf5BVEfEKCEW7tyiBDATHP/s3gYbeXNvVgYlG/rb8A jHsfItuTM7S0iliNjYMtOBc3SHBy4JldksWzN9flP/cTqeHtwy5ip/DG/dWHdSaR60do wssrEQLGjrD9H6YBsVHYT5xHBwwN+pt0xtTXgzjhtbM2ERu1zv406ii7/CGZstczEPGB 6pYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WKhRMc892s5J3SEByy2exIsvz2J4zE9FBkgS5UdcNJE=; b=oIafqJBrPm6A+KfSyZh0FRVOYDLfMEPUFLP+NQAWss3721RUqMBioBk5CJkhWS0c3y BvFCgl1t/7buoc/CFNAkhON4J7nkaUVAmMeFBajDlaOb28f1GJFJThfadH13ne+CpKPS UgMgjwB9Koeslav5PONAVlkcsGMaGQyNGNFg4whkQKmR75CgDy21CWmOPbLZhm4uibaw 8iDISn0BP/FNP4t+lxMaH+bcOIPyA+KBc1UdBHsnZHIVSozyOD0tQ4umcbJRuh14+yZo SqHPfBE2lFfhOQQaqLDUYXaPJEfZRhew5t5RiFAYD8DeLgptdiEUWn9GtdyDMXF80zTd AIqA== X-Gm-Message-State: AGi0PubW5xzQHka4Snx/rxHVIXutS5uOmEV20PVestHeWTeRkgWU4xKr vRsOhjqr2Twt/7ThAnQC7N5HQeO8VcFLRlDEYGO4tg== X-Google-Smtp-Source: APiQypIrP4nwSL50Fx9MmDml9Al1/4dW/gWr+/pgpcAvkiRW8A4rj1dc8hvwXkVGJsIDrKHc39PIXcfdYR+KEBS60g4= X-Received: by 2002:a50:d0c3:: with SMTP id g3mr2968963edf.85.1585840440103; Thu, 02 Apr 2020 08:14:00 -0700 (PDT) MIME-Version: 1.0 References: <20200401225723.14164-1-pasha.tatashin@soleen.com> <20200401225723.14164-3-pasha.tatashin@soleen.com> <20200402074732.GJ22681@dhcp22.suse.cz> In-Reply-To: <20200402074732.GJ22681@dhcp22.suse.cz> From: Pavel Tatashin Date: Thu, 2 Apr 2020 11:13:49 -0400 Message-ID: Subject: Re: [PATCH v2 2/2] mm: initialize deferred pages with interrupts enabled To: Michal Hocko Cc: David Hildenbrand , LKML , Andrew Morton , linux-mm , Dan Williams , Shile Zhang , Daniel Jordan , Kirill Tkhai , James Morris , Sasha Levin , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > I do wonder if this change is strictly required in this patch (IOW, if > > we could keep calling touch_nmi_watchdog() also without holding a spinlock) > > Exactly. I would go with your patch on top. > > > Anyhow, it's the right thing to do. Michal, The reason I changed it here is because in the original patch that this patch fixes we changed cond_sched() to touch_nmi_watchdog(): $ git show 3a2d7fa8a3d5 | grep -E '(nmi|sched)' - cond_resched(); + touch_nmi_watchdog(); - cond_resched(); + touch_nmi_watchdog(); So, should I move it to a separate patch or is it OK to keep it here? Thank you, Pasha