From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Dan Williams <dan.j.williams@intel.com>,
Shile Zhang <shile.zhang@linux.alibaba.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
James Morris <jmorris@namei.org>,
Sasha Levin <sashal@kernel.org>, Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v2 2/2] mm: initialize deferred pages with interrupts enabled
Date: Thu, 2 Apr 2020 11:13:49 -0400 [thread overview]
Message-ID: <CA+CK2bAFsTJT2zU=+OyHj_-=zTKbw6mLHzrc2VEoGjPQpfhppQ@mail.gmail.com> (raw)
In-Reply-To: <20200402074732.GJ22681@dhcp22.suse.cz>
> > I do wonder if this change is strictly required in this patch (IOW, if
> > we could keep calling touch_nmi_watchdog() also without holding a spinlock)
>
> Exactly. I would go with your patch on top.
>
> > Anyhow, it's the right thing to do.
Michal,
The reason I changed it here is because in the original patch that
this patch fixes we changed cond_sched() to touch_nmi_watchdog():
$ git show 3a2d7fa8a3d5 | grep -E '(nmi|sched)'
- cond_resched();
+ touch_nmi_watchdog();
- cond_resched();
+ touch_nmi_watchdog();
So, should I move it to a separate patch or is it OK to keep it here?
Thank you,
Pasha
next prev parent reply other threads:[~2020-04-02 15:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 22:57 [PATCH v2 0/2] " Pavel Tatashin
2020-04-01 22:57 ` [PATCH v2 1/2] mm: call touch_nmi_watchdog() on max order boundaries in deferred init Pavel Tatashin
2020-04-02 7:23 ` David Hildenbrand
2020-04-02 7:46 ` Michal Hocko
2020-04-02 11:36 ` Vlastimil Babka
2020-04-01 22:57 ` [PATCH v2 2/2] mm: initialize deferred pages with interrupts enabled Pavel Tatashin
2020-04-02 7:14 ` David Hildenbrand
2020-04-02 15:49 ` Pavel Tatashin
2020-04-02 7:38 ` David Hildenbrand
2020-04-02 7:47 ` Michal Hocko
2020-04-02 15:13 ` Pavel Tatashin [this message]
2020-04-02 17:16 ` Michal Hocko
2020-04-02 18:25 ` Pavel Tatashin
2020-04-02 12:09 ` Vlastimil Babka
2020-04-02 15:05 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bAFsTJT2zU=+OyHj_-=zTKbw6mLHzrc2VEoGjPQpfhppQ@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=david@redhat.com \
--cc=jmorris@namei.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=sashal@kernel.org \
--cc=shile.zhang@linux.alibaba.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox