From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04D8C3DA6E for ; Thu, 28 Dec 2023 14:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F9F08D0013; Thu, 28 Dec 2023 09:48:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A9448D0012; Thu, 28 Dec 2023 09:48:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 472618D0013; Thu, 28 Dec 2023 09:48:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 375158D0012 for ; Thu, 28 Dec 2023 09:48:48 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0E3894089E for ; Thu, 28 Dec 2023 14:48:48 +0000 (UTC) X-FDA: 81616508736.01.3046365 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf29.hostedemail.com (Postfix) with ESMTP id 4BEC612000D for ; Thu, 28 Dec 2023 14:48:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=npl6hdSL; dmarc=none; spf=pass (imf29.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703774926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u0zhsoc7zLEWUspquC1xbxifv5WBj4GBVb2SAg7HeYA=; b=yW+ir2uzhAEf3yEg91og4YeYUUuoxbmTYAjgiRsiobutB5UB3L8uXRm/eCW46us2pP0yFb NOY6MfLflSo9GICT6SydXNzmYsyqPDP4qom9f/sunE+joFEYWtE4AqSL6TuYRcM2DoEm9o ijY2yZpPZ7QFlR7f9BZDFXDgdvnRR+Y= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=npl6hdSL; dmarc=none; spf=pass (imf29.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703774926; a=rsa-sha256; cv=none; b=Yw5OFkGe+M6s4LBVaDFJpQNSVsu5f7BB0JkK89OjOrcb1ZNjMrFTSpM8kd1FbdLTYDGBbX l7TdFIjzRtCCD6+eP/txqZ0TOHzNMFmdQ51TW8hxHKIHgiO7wMARNrL/XLwaBD37FKhvRZ j0pT17lFaDujXBnsmK/kBJEZE0UqLlM= Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-7cc7d0cc419so1037797241.2 for ; Thu, 28 Dec 2023 06:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1703774925; x=1704379725; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u0zhsoc7zLEWUspquC1xbxifv5WBj4GBVb2SAg7HeYA=; b=npl6hdSLjtpUt2okEkGHD/HaatrPJ503VpaYbnHSCgJuX28qoYsJSFB4e/2gdqhr6c f6EwKBOQmmA4KPdj/6f2FsRc18P42PsVQsIw+uJ5gCw+x5ehbAmSGBxT9rSxEwSDsQQu jiJubV0+0g6d2/OXtgflXwInnQnmyehe20rAbmNZt+IqOj+Co9KSHbrMg3Ho0QJcORLc xX2jE0Xsjb4zPrXT5MIqr95nyn3g/ujXNQ6CA+wOiwkgOv3DRGt60p7zUTRHWC5JMvi/ /xV9DIvyy+WSLVR4kKp6RmcmF0juaw8gjaYd9+e/b6cEMK+XSur3Iqcn+tiLCUR9mcf7 78yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703774925; x=1704379725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u0zhsoc7zLEWUspquC1xbxifv5WBj4GBVb2SAg7HeYA=; b=JoaOJMBJ9tDsGJS7wXcLYfxGy1kX8I+nnyUCP/ryHcyq1OdEFpMqxSBX0vErwOJDeS QF2TOG/7KT8VU74lm89mcATjZ462eDKEXNNMLfMKrTjT2r7LfOGw9clc1g3vii3ElYiM eqi8DmPRTM8rtT7d69Vzoaqy15mqHoQ1rHss665gCxUKGhCZHaiJxGYLNnq3dxgO+tut w1rip+lWtuyfSjzyjkvBJEg4FR/n8t78aesBCR1nrb9kLtyxqNeY9txdMGbvzf6yU9ec NOMDKbNn9jiJmRF732dj9P3jbWPvc9rk6Xu85bett5QfEgcWp1gkguvdQPrG4j2D6h7+ PnwQ== X-Gm-Message-State: AOJu0YxqWjFAgK3aPDlhnhjV6dGb4Rj0E3qxj8Lt8uu09xv1fWXO8XQR vsYnO+HcUTb03VLq9lalvNq86zux9SCnOtyg1ZXqRsBqdQMP0Q== X-Google-Smtp-Source: AGHT+IG1OslSF2rqep3xU7q5DR6zY2q2AThUtHZXryNBrOdQOuAmmf/X4lKxUxSAnVnfIy4v9Rc7Im0O+qb15ZaPM3k= X-Received: by 2002:a05:6102:1514:b0:466:59a3:4461 with SMTP id f20-20020a056102151400b0046659a34461mr5074746vsv.32.1703774925370; Thu, 28 Dec 2023 06:48:45 -0800 (PST) MIME-Version: 1.0 References: <20231211154644.4103495-1-pasha.tatashin@soleen.com> <3d415ab4-e8c7-7e72-0379-952370612bdd@google.com> <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com> <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org> In-Reply-To: <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org> From: Pasha Tatashin Date: Thu, 28 Dec 2023 09:48:08 -0500 Message-ID: Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files) To: Andrew Morton Cc: David Rientjes , Linus Torvalds , Greg Kroah-Hartman , rafael@kernel.org, surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, souravpanda@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4BEC612000D X-Stat-Signature: h8chrw1ig4b5qt6d13ry4tnwo96iquro X-Rspam-User: X-HE-Tag: 1703774926-209201 X-HE-Meta: U2FsdGVkX18ZpfVnudG9jnKGRQIpxO/Z5y+VdXgv7eFsE6aBUC762tL6fuW9N3rVfvUpgRAQZ7yZFBBoIDfe2UBy98ERoHrGLhoZJ4Ifs5LTDT1QvB3NddPxzX/F08000DWDSDysPFQVk4B/crWhKOUNyZvHA6XQr3abtxbgo8VxyF7lds7Rc4PEvOh/NYCqRQezT9pYlikWifG9N83pinWvh5hQ9K8hGzZxh6/TdB8sCoJ9ZnWjnSpKVv8B/8dXoT6qOke5ZHT57Jsc/R4emH8m3PefE9jwE/nhr9snNSdbJFyD/62AmwRRUbomwI8kWBNyOqHSwCzRkPkBa6Rnm3Lm0plGvuNXZqQ8WtxLw8uUbei7TTZubHMejGAYG2xPUwf9DqQibbSr8R/Je8xUIzrY1fu6KaWWIJonlQgi1+VoFFUedTF49S/TXdjGjTCiFAdKQHUT/9YR3xs0TxjrOCxEhcsyiwpHj+s51GD2XtREo2wVhd8hrC47Ixeq3KEcToq8vGDoFvduUs5N6OY4OJ3Obzs7lF8X+UueReTZkV1HMGoam0N2a2g/05EYR6j5ZTw2znlB/pOvtfWowRr1bAkKIaB+OEal2JbQ/CiI5ls62CXxvJnojRrFFlgVdN6rntEfeci2EwzqO4PLJIe+VlIY//wKTNTlssTdOEHSXE7JZhJOThoUKQTgXYyAascb5jpO/mRg7M73K2l7p+kfkO3bpP0tcAeGbsipMo4zfIyr9GCQimAeMEhHBCJRbCbxzm5WUelQ+Dq0Wr4UI+//Qzlpi/nwbzZxLOVLovF0bKPbmQNrR7HujlbP0DeHAIL5SAqH7giwhQ6jgreJkPU5I75+AOOZ+13M504+4FmukwRYd1An0QhNeRtltiLobRSK08/s5v/HfmFZBooPF5i43zr9Ddsv/apXHPSldulR5NMpYptdewXbN5RPsM/BTEQSQf2VD7HxTLW9XRTScNu Mt2j01vP 0vzRKBFEO1WwURHU4yBqTXZiPTcvSwZdmSPVXl2NELDyKlVpUjqVc13gK7NiuFwyAN5w8ja6cJA485JEldG5BV9Joc9jy1EuRBZzEo83gSGqdZ4iVhLJ6aGYJ2fmoTmg4MuTNVTZmNbVK818jQZtdtnfIMtBmGj47emijT8ffzRK568cp4p5ezTofGaP7YKrntiGe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 27, 2023 at 1:42=E2=80=AFPM Andrew Morton wrote: > > On Tue, 26 Dec 2023 16:53:31 -0800 (PST) David Rientjes wrote: > > > But for existing files and conventions, I think we should settle it as > > "keep doing what you've been doing for 13+ years" and don't force this > > argument every time a kernel developer wants to just add one more stat. > > Absolutely. Let's do what makes most sense. For new things, one value > per file. For stats which logically group with other existing stats, > do whatever the existing other stats are currently doing. The intent of "[PATCH] vmstat: don't auto expand the sysfs files" is to do exactly this: keep the current fields in /sys/devices/system/node/node*/vmstat as-is, but prevent future fields added to node_stat, numa_stat, zone_stat from showing in vmstat. Potentially, we could also extend checkpatch.pl to warn when VMSTAT_SHOW_SYSFS is used in the future patches. Pasha