From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rafael@kernel.org, surenb@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
souravpanda@google.com
Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files)
Date: Thu, 28 Dec 2023 09:48:08 -0500 [thread overview]
Message-ID: <CA+CK2bAARPNHwZB9tkd6miKr8GWrZ_L6h1oiUM0qWu6pJqh3Wg@mail.gmail.com> (raw)
In-Reply-To: <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org>
On Wed, Dec 27, 2023 at 1:42 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 26 Dec 2023 16:53:31 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
>
> > But for existing files and conventions, I think we should settle it as
> > "keep doing what you've been doing for 13+ years" and don't force this
> > argument every time a kernel developer wants to just add one more stat.
>
> Absolutely. Let's do what makes most sense. For new things, one value
> per file. For stats which logically group with other existing stats,
> do whatever the existing other stats are currently doing.
The intent of "[PATCH] vmstat: don't auto expand the sysfs files" is
to do exactly this: keep the current fields in
/sys/devices/system/node/node*/vmstat as-is, but prevent future fields
added to node_stat, numa_stat, zone_stat from showing in vmstat.
Potentially, we could also extend checkpatch.pl to warn when
VMSTAT_SHOW_SYSFS is used in the future patches.
Pasha
next prev parent reply other threads:[~2023-12-28 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 15:46 [PATCH] vmstat: don't auto expand the sysfs files Pasha Tatashin
2023-12-11 17:00 ` Matthew Wilcox
2023-12-11 17:09 ` Pasha Tatashin
2023-12-14 17:52 ` David Rientjes
2023-12-14 18:57 ` Pasha Tatashin
2023-12-24 21:26 ` David Rientjes
2023-12-26 17:26 ` Pasha Tatashin
2023-12-27 0:53 ` Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files) David Rientjes
2023-12-27 18:42 ` Andrew Morton
2023-12-28 14:48 ` Pasha Tatashin [this message]
2023-12-28 20:43 ` David Rientjes
2023-12-28 20:50 ` Pasha Tatashin
2023-12-28 10:17 ` Greg Kroah-Hartman
2023-12-28 20:52 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+CK2bAARPNHwZB9tkd6miKr8GWrZ_L6h1oiUM0qWu6pJqh3Wg@mail.gmail.com \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
--cc=rientjes@google.com \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox