From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D362C433EF for ; Thu, 30 Sep 2021 04:13:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F36C8613DA for ; Thu, 30 Sep 2021 04:13:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F36C8613DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 81E20940084; Thu, 30 Sep 2021 00:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD7194003A; Thu, 30 Sep 2021 00:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BC25940084; Thu, 30 Sep 2021 00:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 5A34194003A for ; Thu, 30 Sep 2021 00:13:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1ABCE1803E8FF for ; Thu, 30 Sep 2021 04:13:07 +0000 (UTC) X-FDA: 78642919614.28.567063A Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf20.hostedemail.com (Postfix) with ESMTP id C9AC1D000455 for ; Thu, 30 Sep 2021 04:13:06 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id y26so19659737lfa.11 for ; Wed, 29 Sep 2021 21:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ybfITpBm22sJ0qTITfKzloHH9OFhLMtm0iBbulL70uA=; b=nohrJOKCNseu7b2ywiwiPYsNcAU3IVfpwDH/QVFad5KG+wSXmD46gE18mecw3bgkcL hK7cgWBfzzfceFD/1gzeYPliWuhsY54PK5eMYEFi3XTyFR3Ejcbk0QZTkBZqSXsEhpnT M+lF4KKFDYUqLlFGHw1+cpfqKDMRFPHE5b4S72w/mu5T1QtvKOoLZsJl2nNuERQrA2HE iRFL1QkHR+/a9+IuAvTW1TTKC8vIY96QIjMPkz4aAsF2YWED01PU4XIJOai+VQvRuFRf x+U84hnWPEMEd27/V4FYhnaA3hqM6fwg2uOwUcM2pj31MpMW7Qaib+0isSRvu0ivPwSP vLZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ybfITpBm22sJ0qTITfKzloHH9OFhLMtm0iBbulL70uA=; b=IHebl6TufImi9OOcopXOHL4mZgMC8LJchqe4T/rFD+HAZZ64ejxfwl4TJumjP/Eb80 0ezZKMHurskA89Mj0PNA+DwruM+25Rx2YhcP6EMa1US2a+rt2XI6YOns77weWiEP7Qlw MzMe2isl0pMNNnrQIdxjWCMNH2k1kgNzlqTneDM1dUbKRqD7+WROGY1ZPpH7CvRA6lei v5I5qpESkFiDF2SkBS9gw2YUj9Rm5g1NbKvLtHxjwLDoNe7Th47MjSdPE/q8VIMVedPS jFvzI4dbwTJS4OUmDFy0qCQiP1VPHyPWyvK9eqrSOivFB0Q+6qivwdeIKzOWeH9J0Gou ashA== X-Gm-Message-State: AOAM5332ezWXkO6cfh3Nuv9lQe5rpc89nJfu1BL+12vGLn3NLhKtBDTK DpiAhkJGJaJh7fCp3eHmPZSioCgUuFLNrm3/pxKNJQ== X-Google-Smtp-Source: ABdhPJyJqyVL2VZxEOD1okwY27OOhQswijMTr1C9c6QL4wIM651T3RQ3aw3G8KN7j3/jJ+NhdT+QyVWJu/SB9+HVAsE= X-Received: by 2002:ac2:4d10:: with SMTP id r16mr3455494lfi.309.1632975185478; Wed, 29 Sep 2021 21:13:05 -0700 (PDT) MIME-Version: 1.0 References: <20210916231325.125533-1-pasha.tatashin@soleen.com> <20210916231325.125533-16-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 30 Sep 2021 00:12:28 -0400 Message-ID: Subject: Re: [PATCH v17 15/15] arm64: trans_pgd: remove trans_pgd_map_page() To: Catalin Marinas Cc: James Morris , Sasha Levin , "Eric W. Biederman" , kexec mailing list , LKML , Jonathan Corbet , Will Deacon , Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Matthias Brugger , linux-mm , Mark Rutland , steve.capper@arm.com, rfontana@redhat.com, Thomas Gleixner , Selin Dag , Tyler Hicks , Pingfan Liu , Andrew Morton , madvenka@linux.microsoft.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C9AC1D000455 X-Stat-Signature: mpmx94sr6dgj9sk9u77hsjbnnjfxq5af Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b=nohrJOKC; dmarc=none; spf=pass (imf20.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com X-HE-Tag: 1632975186-258212 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 12:43 PM Catalin Marinas wrote: > > On Thu, Sep 16, 2021 at 07:13:25PM -0400, Pasha Tatashin wrote: > > The intend of trans_pgd_map_page() was to map contiguous range of VA > > memory to the memory that is getting relocated during kexec. However, > > since we are now using linear map instead of contiguous range this > > function is not needed > > > > Suggested-by: Pingfan Liu > > Signed-off-by: Pasha Tatashin > > --- > > arch/arm64/include/asm/trans_pgd.h | 5 +-- > > arch/arm64/mm/trans_pgd.c | 57 ------------------------------ > > 2 files changed, 1 insertion(+), 61 deletions(-) > > > > diff --git a/arch/arm64/include/asm/trans_pgd.h b/arch/arm64/include/asm/trans_pgd.h > > index 7b04d32b102c..033d400a4ea4 100644 > > --- a/arch/arm64/include/asm/trans_pgd.h > > +++ b/arch/arm64/include/asm/trans_pgd.h > > @@ -15,7 +15,7 @@ > > /* > > * trans_alloc_page > > * - Allocator that should return exactly one zeroed page, if this > > - * allocator fails, trans_pgd_create_copy() and trans_pgd_map_page() > > + * allocator fails, trans_pgd_create_copy() and trans_pgd_idmap_page() > > * return -ENOMEM error. > > * > > * trans_alloc_arg > > @@ -30,9 +30,6 @@ struct trans_pgd_info { > > int trans_pgd_create_copy(struct trans_pgd_info *info, pgd_t **trans_pgd, > > unsigned long start, unsigned long end); > > > > -int trans_pgd_map_page(struct trans_pgd_info *info, pgd_t *trans_pgd, > > - void *page, unsigned long dst_addr, pgprot_t pgprot); > > So this function never got used in mainline after commit 7018d467ff2d > ("arm64: trans_pgd: hibernate: idmap the single page that holds the copy > page routines"). I guess it's because we merged part of v10 of this > series and in v12 you dropped the contiguous VA range in favour of a > copy of the linear map. This is exactly right. This function was meant for the contiguous-va relocation version of this series. Pasha