From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4103C36008 for ; Wed, 26 Mar 2025 14:48:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AC07280089; Wed, 26 Mar 2025 10:48:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05C79280088; Wed, 26 Mar 2025 10:48:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E65F0280089; Wed, 26 Mar 2025 10:48:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA9E9280088 for ; Wed, 26 Mar 2025 10:48:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 78A191C9E79 for ; Wed, 26 Mar 2025 14:48:48 +0000 (UTC) X-FDA: 83263983936.14.DE2B0E0 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf27.hostedemail.com (Postfix) with ESMTP id 80B8240011 for ; Wed, 26 Mar 2025 14:48:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=TWKg1YI1; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf27.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743000526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s4L90UXo/Eloa6bFLe63wlh9gsUHXreX60bjxNb5DKY=; b=BziY2BETBLsBU+PpQf42hLGQbij+l9CLGut4gjMowE6wKByKSPJjfjOwHXHFGD1YxSNvdz mYU+6x9ilE45Emr5klf40e6dF6vurIUMPorFAcVWxAYjYKtgnhRfoxjq4TyOAU2xO8aaQh lJwbJW8/w6c3qCyc5q9ywDf6Oci4irc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=TWKg1YI1; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf27.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743000526; a=rsa-sha256; cv=none; b=J60KxAVYRr0QiopgnQVpQbXxIvzQku57V4Oi3wCYWuqeqxt/YYCssMwz3Nfll/kI7wwDA1 Y0m8rhqxuNE3Q+3lNIiPNwy2ITAxfycsOp5RIMdt9frLjmCPPfTQ8IYRwG2RJz2pMsWWiQ 9tbAxgRrVpt5/u6kX7mUQiYdVSkOqvE= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4769bbc21b0so72108741cf.2 for ; Wed, 26 Mar 2025 07:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1743000525; x=1743605325; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s4L90UXo/Eloa6bFLe63wlh9gsUHXreX60bjxNb5DKY=; b=TWKg1YI1YsPEA+vzRRjOhHIoOQeT3kyb5/zf1+SlPA3W5JaH0M/gntCTGO+H5vxCR9 nfr8iOLxVdpN1YCbmVMYkT51AcioLONy9nw50UqFiq48NXXpa/maZLqZrvPe0YjC2Owg Sv663MvKRnS0vCiXBkI2o9kx6qyC6ikiNlV33ndv+uRS/9tqI47ueO3PY1UF0w16RmrE dZzjljC9POYhADiPVJJJv7BXCaNn4se6rKYus5LKF4Aw/wqUPKBCJZ73Dl3ctyEHTngN CdR4y4yq/bIgs5NSbSavUCfAsIIDY3SiJZ7WXfRgHrVI1CTtgkHg5peMo5HMoWNxH1Ye iGrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743000525; x=1743605325; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s4L90UXo/Eloa6bFLe63wlh9gsUHXreX60bjxNb5DKY=; b=NBwUoyzBlYmVWmnTmXSEXE/t0Rrl1XpaKKF/9hgZg5xXbZxal9Gj8AIntiAj6rSb66 KgF5/0eIyyj3/Ofg+BTWjFA4+DFwI17KF5DI77QrfUr40BeEqVtYPjozYSZewA7b0Lyh fPag8v+7BMf4ZfeWI46oTS5b5yaXSjdqhCBGRTX+qGX8acfwzd0gU9neVHXHIqBssRTM YMCHGd4CbEYiHSYxMSAu0rJrPuJM5yWsaR/MnrL8RXYSlTi2MWoewr/mspJe7xJQoynU a2T6YaZ7K1aIEuzZ+sHZjZq4ridHoWLf0+WULqHkWRwMGsV9r4tlWQPtX0M49BcXKkCm HgNg== X-Forwarded-Encrypted: i=1; AJvYcCXiVfD0XLg9ReV9p67oItyL408nJDfgiaVMtLtH+5d++2WomsTlfYAvl2pJ0XIJtHT2jTMhf4LGVg==@kvack.org X-Gm-Message-State: AOJu0YwrurmTerIgBeqIP1gGwOKwbzRo7Qg7uApkSokySSd++QJYXSX6 JBb2fa9uyU4kwYkN5UpzDmrCeKS2YC/Yy0HD5ALqUwRypKT6rAHSx/aONlSGVYb5J4q/Iyu/9SZ w90aZXOVvRIpxgdtufEWRbX7EpN2x5mhAbNaZzA== X-Gm-Gg: ASbGncvyoH7j0rrvICf0fFvgGmVBOX+kgsqQHYeGXn2NS3vPdbw2lVpeX+RJ+rs7n9Y IfV5dUJFa0miV9iHR51pezKyVtBp2OUFFHIUjSArZG5eTiz9TP89uhqtS5hPU4zmunmusK/dduH VLzVDE4ErtjJjDcbUrmjI6aPMoirZ7SArc5/w= X-Google-Smtp-Source: AGHT+IE/in8kAs9sUqWx2S+TIM+LTl3sNiBhEhAtSNAuElUMT/X5dBkUTEwjbBFN/tuBh1MnZZanWSfFlEopABMrt2Y= X-Received: by 2002:a05:622a:260f:b0:476:91d8:230e with SMTP id d75a77b69052e-4771de62880mr403362231cf.52.1743000525452; Wed, 26 Mar 2025 07:48:45 -0700 (PDT) MIME-Version: 1.0 References: <20250304150444.3788920-1-ryan.roberts@arm.com> <20250304150444.3788920-4-ryan.roberts@arm.com> In-Reply-To: <20250304150444.3788920-4-ryan.roberts@arm.com> From: Pasha Tatashin Date: Wed, 26 Mar 2025 10:48:08 -0400 X-Gm-Features: AQ5f1JqVDILCP1zyFTP-RFlE3wANS6rYR-F_g2XERE3hhejEgMHeH_4cyMuLPCw Message-ID: Subject: Re: [PATCH v3 03/11] mm/page_table_check: Batch-check pmds/puds just like ptes To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 80B8240011 X-Stat-Signature: 8idpk1giiodbbet31onfodeukb1y5ude X-Rspam-User: X-HE-Tag: 1743000526-945537 X-HE-Meta: U2FsdGVkX1+Mn0y8nT31tWXUZjETPA7c1yq+ABBE0DaaV82rVV7jRwmSuOeyQh0G4eqKCi9ZrkVqIvlnXBFTaUmBIOJdqsyswI0azpFRiDSc6UN3sCjp9Rbwfvh94WaFUilU8bRjsWew5PM5XaD5vBAhpJgE5w7vB3fSkfep+Tg04kz6KpB/sBEFVml+BGohDZoW/QRGpwZN9PYddvyoKDs1zLaTyk5jP57fb/1KkGsepg/Nc55w8e1MhDlUJkt5PC47nhYbiV84X1h/pHseqCLywkq03sMHOUK20sT4zBrC17jxgeF1eJTwTvI2kjU0pXnu5Kv9BXvaLRX6KTZweM3cO1YSepgekoDv5bJHOhkEBciKYSmHHVKADdILMK17hZZSliuM7UDfPA9eyvPlC8J2lM/rAJ8ErUdH/2P7osyR2iFV7fZIrdgax+XY3IMdDXIq11UnGrukf+d0QYt0N0cLv/eUIKko0G5sCU+S4jAu4/fiUSJ+fs4g/aBxnEc3wDunPJuISeb829Rb1+8R4Fg0s7RyV7v5p+58XeVUocsI1yBUE6f8P3U+S+/cQ47a+AX+N/bi7QBOQvigWiGntUIREOb5q9UQ6rA1qbBFs1Ce/ZMfBmNjwX53ATVUJSLHSfpb4H5ijgdF+VAE5CQKgfcEG7KWeo0pm3ICVHFkthkTEeP9qgqg+SvrBwsOMntFqeHKIG8NCDtR4EfxCnJFJAXlTvXvcJ7Yu4Y1eNYMblYM9zVzLV4vkm/IZOLUalRknsppWP3tgzyT9IL+c1zuC8OFzNrK4RcYKH31zbRHprxFFkdpXi7Y/90UMSz3OBNo83aseDPhswNYv/F8QC3MVAsFEhKGm8oOSZ/ffGYOAIM3nugbvTSX9YY8DdbNvW6qmQ2ikm9Vdh9GrTDhRfowTy4Dc127zCdQaRg1hlaz/t5Br056ruYGh7re6931NtQwQcMDIdXN1wVniYu0A9q VBOBCkiR kya40WlHZr41S7q86R/fJ/+8iH/cKJaXi+Hd02r2T4PN88hTqQEq/IGfo7oMw0g06yLyTu2A+3dIScZJ9HlMIggPhyg8uP8KcRcYf3ZH2oK0GHCWfXl6IRTJjpRGrZnIZCq3m95QFiSBzt5PLfj4jgrbUk58zLGLDhPFKRgLKx5LFTOp/hNxIoRGKWE+eSJ3znYp/qE2P4+76tNMX+pFy8JxuFLgQxT3JkFysZpnAn7q+CNtN6fH7jlBBkomM1tszi7cGm31Y3oCOYKM7fcdrv7oSKNmMSIcUTD0aF6vo3uoRcDyPt1szWYE1VH41Y10iRfBEZR86bllNwjESlxCHTN8iBb+R+KbMPj7K1AGI4U6c0fU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -void __page_table_check_pud_set(struct mm_struct *mm, pud_t *pudp, pud_t pud) > +void __page_table_check_puds_set(struct mm_struct *mm, pud_t *pudp, pud_t pud, > + unsigned int nr) > { > + unsigned int i; > + unsigned long stride = PUD_SIZE >> PAGE_SHIFT; nit: please order declarations from longest to shortest, it usually helps with readability. (here and in pmd) Reviewed-by: Pasha Tatashin Pasha