From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE95C5B543 for ; Sat, 7 Jun 2025 23:42:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADE1C6B0088; Sat, 7 Jun 2025 19:42:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8E4A6B0089; Sat, 7 Jun 2025 19:42:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97D376B008A; Sat, 7 Jun 2025 19:42:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7475D6B0088 for ; Sat, 7 Jun 2025 19:42:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DC0251CF33C for ; Sat, 7 Jun 2025 23:42:48 +0000 (UTC) X-FDA: 83530232016.05.C9E9EFB Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf06.hostedemail.com (Postfix) with ESMTP id 1F8BA180006 for ; Sat, 7 Jun 2025 23:42:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=KiaQXmMW; spf=pass (imf06.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749339767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i/syDOAYjJBuSBfzBdkjym5sji/N8QKIGdNQ1zbp8wY=; b=QkX3CAcLz2PfKAXSivaWhNSBfH/DM0AzgWjR9OzVRnvcTS9s33HQ++NFCsBw8IjcXp9n9c y4wNTyz7ytSHFGotKIkJwJqq215WIoRQ3EiTY5t12/LsxUc1/dasDpXUTfHMqpBok9MDZP btvfsN0uOHplSearEpnTd5Bi+M2kr2c= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=KiaQXmMW; spf=pass (imf06.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749339767; a=rsa-sha256; cv=none; b=io+vrogc2EvWaXdA5hsX4DJFm5NHVlNbtkdACOoqEYz9iJXKnKl07A20tmDzfbbeBurOyc SRyZyErXtjL7pm98xYVJZJxfnwuHq6HBAD76csl5dVh+WPau9uRBHVbqS16jZo5Hz57NeT Ia+Q73FW2P4UAKX9NrsXFpptinQglGE= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4a5840ec53dso38558291cf.0 for ; Sat, 07 Jun 2025 16:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1749339766; x=1749944566; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i/syDOAYjJBuSBfzBdkjym5sji/N8QKIGdNQ1zbp8wY=; b=KiaQXmMWGLFa8BMZcTo07VH88FVU5nqAHMH7ucUboF73D6b65pFv2aGpwQGrfNzWZ/ MGEZTyMzjUqJ3vgS9XUBzIbdSk0roRwv8A8Mzyjm9qDjiV77eFeAhmt7kKg2CJcKvkNE g7z+5YQhtXC7nPS5e1fTO0ZIdsY5QX8WI0IhL3Fk+sg4MrzQIIialfifaGcuJtMmC5iA /i4G3ic+1Xseh+yj4kLVnbYY2CBseL8LopwCS/elcEldwFKtxRoVUh87sk1CqDZwbHHo SNK4HMttpiw4cto76w2iiDhxshdfX4Yxill8daCjpNjkXrSSfbnhP4HFXr2bfsFSyLQ6 Lcig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749339766; x=1749944566; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i/syDOAYjJBuSBfzBdkjym5sji/N8QKIGdNQ1zbp8wY=; b=C/kx+eZTnjch3qdTmgESztNDdZ5gdIeDfmftv0BaRAFH8FNXxb/M3XSvBjGTzZfhjv ca1sFtlMfyNLfgXVfFJmquXf79A2vt27flAWBuEAqMo0i2vVssRxwsyUjteV5IhMm2Iv CbAaA3PXfRJLeQ2t7my8K3MyiVXcb0h5ZXfJ3JdLj2m5ZqmJ/p0clImafNBzCY25ra0R 2DM2xZJN1CnjpsQDcIj6tlNFlc9uvlmE+OkuG5/H/dBYSBMfg0Y0DrCrg/xeZQ0Jfu1B efI1N8RBCUWths0TQE1bQ9/3wBdnkjWQwgTs/wFN2j8gtuv6JV1JpdJaApV2apqHNmIW BAwg== X-Forwarded-Encrypted: i=1; AJvYcCXZQa6+giMmVeF8IyoxQpT0asfLRNzhjNoz4xsbDKK81WBdmvexWpf66iRC6ew7pf5dfip/vnJNFQ==@kvack.org X-Gm-Message-State: AOJu0Yy7J5alp6Yl9yZiF57gTjm5rweuv3mRgi/bDWVJIxYsdX+YEMBD mAJLOVE1L/uy6tdD8ARCZBcCGZ6/WQDd59cQoKTl4HBJ+yh/nueTNYTcvsy5snKuh/iouv6v/NF s8jEwB8Hoi10ZEwfO3PTVXsyJ3HyYpy9yF8XTn6Pndw== X-Gm-Gg: ASbGncuzhPB1vr3Z5sxWSb9VLPLBFcR9a5a+jQwfxSPtcFNxskT6pqb+IQFP60SgVlx A9NPnhlIywKeqzjgJygnoF5Pn7lbifkXsAJpihUOymCuXVnKdtTkruellrv2O7wxXJIILsVZkqo A7nX+roFsjBy+KAjmnIB4AfZm27IaS1uwh3XwQqXnFE/hf1p2q1sk= X-Google-Smtp-Source: AGHT+IEAgPxUwkqdPhXxzVG+WhF6yaa5uymBn3HgETs0L4z2bdPRdYUl9jyTZgMqsCE8DJRM23RO19BVIQhP40bO/mk= X-Received: by 2002:a05:622a:2516:b0:4a6:f6fe:a299 with SMTP id d75a77b69052e-4a6f6feb21dmr39697051cf.52.1749339766154; Sat, 07 Jun 2025 16:42:46 -0700 (PDT) MIME-Version: 1.0 References: <20250515182322.117840-1-pasha.tatashin@soleen.com> <20250515182322.117840-7-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Sat, 7 Jun 2025 19:42:08 -0400 X-Gm-Features: AX0GCFsxfnExL9Ei5U3kVAWPNmWzqRql6alttjH_jISct21wFPpAUjl8G2uTgGk Message-ID: Subject: Re: [RFC v2 06/16] luo: luo_subsystems: add subsystem registration To: Mike Rapoport Cc: pratyush@kernel.org, jasonmiu@google.com, graf@amazon.com, changyuanl@google.com, dmatlack@google.com, rientjes@google.com, corbet@lwn.net, rdunlap@infradead.org, ilpo.jarvinen@linux.intel.com, kanie@linux.alibaba.com, ojeda@kernel.org, aliceryhl@google.com, masahiroy@kernel.org, akpm@linux-foundation.org, tj@kernel.org, yoann.congal@smile.fr, mmaurer@google.com, roman.gushchin@linux.dev, chenridong@huawei.com, axboe@kernel.dk, mark.rutland@arm.com, jannh@google.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, dan.j.williams@intel.com, david@redhat.com, joel.granados@kernel.org, rostedt@goodmis.org, anna.schumaker@oracle.com, song@kernel.org, zhangguopeng@kylinos.cn, linux@weissschuh.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, dakr@kernel.org, bartosz.golaszewski@linaro.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, yesanishhere@gmail.com, Jonathan.Cameron@huawei.com, quic_zijuhu@quicinc.com, aleksander.lobakin@intel.com, ira.weiny@intel.com, andriy.shevchenko@linux.intel.com, leon@kernel.org, lukas@wunner.de, bhelgaas@google.com, wagi@kernel.org, djeffery@redhat.com, stuart.w.hayes@gmail.com, ptyadav@amazon.de Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1F8BA180006 X-Stat-Signature: ehuqc8cmqwo1eed3tno9pg9fnm5kh9xb X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749339766-476364 X-HE-Meta: U2FsdGVkX19J61vzJTEJ2ZInGdT5/voX4WLRsWKvAeefSnj2qO0P8Yu6ypZPuqWhg5rijUXSYAyx9ug8dObetSWiN+F9VvSH7VC5W/8yAjFoPXpfZfFYUkrdrcVowQkSZeyzYKXjHZ3t3JJy+nLmnbrM8djjftd0NNCEYZbcp1Wj3sL0i99BnOSLEkI97kGSPpo5Hz/qZjTI8CkPDOlfDVmnrAfbtXcrVfYtsI+ZcMzvb5ULEM5+hzadK+vQTRCb43JjXs5LSCGbbCVBRxFi4lh5+1ZqfcGd/KZ/L8/MPHmNAn4QbDTJ0q/N/j+qkUIKwsR1pLvgbVAsxWNddNZz1K/HQG39OzZZ3dEP/0ZU/ypBE00bOAT9ePBWK8MLECPenuBHNQKUiEQbCe7wU5u7kFJS/tAUnJPqOqG1DR7kNB2ygTzEGr/krqugk7Slz1wXeCxD5Y+bNC36db3D8vopFsl/AtA+XYMq3y/vIAbAVNLHrOhIAsCt2lvkSdtywvR9KrsY+gTPpCiVgiYewPscNTsnsD48Vu5WuQrCiGBv4NCTVDl27+2wHBWq/al25q2QqLoSofWLdQoU6SLQWYxm5DW3MScE31LlvPkXuO7hW3QM5jxvN7GBs2JuStz8Jol01kgg04HlOiEmn1qUnDi1uH7mAkQrk1+KNAZUfk2kC4N0fvVLY32P/jZNRVBkb6x6LyFBy/F62UqULOuST1s7HF2gWTbr8x4togT4p2ufObdgQEKeGDQ0iP6PMogKbR1vMIyoSg/W66WYOqRY5XsGmme1AJju5v2i7kwVunVqOlj/MIqz6f3xSaPTOo0NJhbtvE42AeExzTVa4EkslI+SAgh2TOFRucy23TsOUBySL7PIJuMura1WSbKd4M4kq6N06Zja/sz97gQ6X2bKv0dRU+jpfi/eTzXpEYRja71MRFDNVEwyeArS4OH/a5csk8/nodA2Rlrhq9fknXlQ+or PrMs3if8 c1ZWpAqj+aaKpPFk3VS6nuPSRE+RaWeDRoHZEa0MrlXOJXvC0NRWfHGtLGiRQslaO8bPBYgN0abr+an85LA7hUGuhskYElqsX1DVMJdclmrTl8GbLZN87ONjaFWrV7Woy+bd+/vxRhjLDHMqMeQPgnc1GBQ7gsIEBMt7Zu6JirhPMDvY+TwYFXBGFQPQLV97Xq0yxHfC3My5Hd00Q/S4F2J7iwJcnfkWfVPlRvLa8MUEClE9ZFVTuoI88vqd18x0IuAjjXCK1i7kvvd0/KlIo7t8zZMlSGLudEPcjJy/r/A0o/jRTBDjOsm0HpRKm9pJNLavT7PMoAeDK0IdOZ2hB6hoOftfhEyS23I7Ny8rGDS4hyCoiTLKNLfHlUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > +struct liveupdate_subsystem { > > + int (*prepare)(void *arg, u64 *data); > > + int (*freeze)(void *arg, u64 *data); > > + void (*cancel)(void *arg, u64 data); > > + void (*finish)(void *arg, u64 data); > > What is the intended use of arg in all these? It can be used when multiple instances of the same subsystem want to register. For example, if there is a host device driver registered with LUO directly (i.e. devices that are not referenced through FDs), it might use argument to distinguish between multiple instances of the devices. > > + const char *name; > > + void *arg; > > + struct list_head list; > > + u64 private_data; > > +}; > > I suggest to split callbacks into, say, liveupdate_ops so we could constify > them. > And then it seems that the data in liveupdate_subsystem can be private to > LUO. Let's keep it as is. I do not really see a big advantage, subsystems can still globally declare and set static callbacks in struct liveupdate_subsystem { } > > > + > > #ifdef CONFIG_LIVEUPDATE > > > > /* Return true if live update orchestrator is enabled */ > > @@ -105,6 +138,10 @@ bool liveupdate_state_updated(void); > > */ > > bool liveupdate_state_normal(void); > > > > +int liveupdate_register_subsystem(struct liveupdate_subsystem *h); > > int liveupdate_register_subsystem(name, ops, data) ? > > > +int liveupdate_unregister_subsystem(struct liveupdate_subsystem *h); > > +int liveupdate_get_subsystem_data(struct liveupdate_subsystem *h, u64 *data); > > + > > #else /* CONFIG_LIVEUPDATE */ > > -- > Sincerely yours, > Mike.