From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A3EC4361B for ; Wed, 9 Dec 2020 20:59:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A8C123D21 for ; Wed, 9 Dec 2020 20:59:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A8C123D21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C12F46B0100; Wed, 9 Dec 2020 15:59:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC39D6B0102; Wed, 9 Dec 2020 15:59:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB1EE8D0031; Wed, 9 Dec 2020 15:59:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 91D016B0100 for ; Wed, 9 Dec 2020 15:59:24 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 53C4E180AD804 for ; Wed, 9 Dec 2020 20:59:24 +0000 (UTC) X-FDA: 77574959448.06.back32_0e027d5273f2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 3C23B1003BF68 for ; Wed, 9 Dec 2020 20:59:24 +0000 (UTC) X-HE-Tag: back32_0e027d5273f2 X-Filterd-Recvd-Size: 4036 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Dec 2020 20:59:23 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id o5so2046408pgm.10 for ; Wed, 09 Dec 2020 12:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pYWbWncWHL5hPUtr0/h39G2nFyFj5DZJ+1NpptfUOGE=; b=qT81RrUelSi4/9CGafxmK+ntZGoAphMgJz0lBOeFpN3C60ZLVZglbdD1va6XQWsZlX 2WCX4IBP+W4m0JM3FvevJc050fRyP9kdAUPqRi9p9jkLvWiTA/YVHjLxhI1eHYlIGg6M B+NNGssSvi1qsa54mziU8lbu8JCSuZi/FA3msuK40BX+B9UcqRtHVPEW2imISObDrBV+ BUqB024a9NyQEFiVSvAShjT4gbCCFtH4JqBTOw8i5WnTeeRWHsidllpZ5UckgW/4pmsd dw1DLTaQ5mzOWw+qSee0Ku5S0TXglz06ZHSaUezYzGCrZUxjrXM68rdwn2GTMRaHoH1F AlKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pYWbWncWHL5hPUtr0/h39G2nFyFj5DZJ+1NpptfUOGE=; b=OQVn33HbtvCULpljVm6pNDH58jhL8kUG3kCHiiYbU0e+tZtOlb3SDnPbR8qAUI8VCA o2L27TXkz572um1EGzgwxLRWd14+5sfGl5ZqOm6p6hyaQOiYUcI+27+eruAsBNPYMVHX cX8MbGiiJPE2Zp1qtdC/mbRN804uFk2ElPrwZmOSZWDHU/PsedEejxKnSALMK5GK+qfu FwFKSE3GK9GmUZpoZ4GKad3Mcf4gcmBODkxA8dIpBP6u48RsYVLOK7HH3IcgUu971lLi QrW2sv1cHhv3HCGkcraMru1oU+dlep+zp3JA1KSUSeYKN3GHHY3HE3sf/7wNEPiOFdKd tr0Q== X-Gm-Message-State: AOAM531uFTTidNkNLmDweL8Eb7SW1o7hfsfQ0uF/UtLbGWHxbuJILc9w Gr8z1DAX+Ioi54G/AD0Se/Oi/dGIAGcZ06DNnyU= X-Google-Smtp-Source: ABdhPJwJqp11WPmMBZbUh5oaeLciMyK4cwqSph9CTeKi9zlgKVe4qyo4RcU2rt3kmRYA+yUTAYEjbif1YrqDluzctI8= X-Received: by 2002:a63:e30b:: with SMTP id f11mr3611905pgh.149.1607547562970; Wed, 09 Dec 2020 12:59:22 -0800 (PST) MIME-Version: 1.0 References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> <20201110115037.f6a53faec8d65782ab65d8b4@linux-foundation.org> <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> <20201207225351.2liywqaxxtuezzw3@lion.mk-sys.cz> In-Reply-To: <20201207225351.2liywqaxxtuezzw3@lion.mk-sys.cz> From: Tony Luck Date: Wed, 9 Dec 2020 12:59:12 -0800 Message-ID: Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked To: Michal Kubecek Cc: Alexei Starovoitov , Justin Forbes , bpf , Alex Shi , Andrew Morton , Souptick Joarder , Linux-MM , LKML , Alexei Starovoitov , Daniel Borkmann , Josef Bacik Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 7, 2020 at 4:36 PM Michal Kubecek wrote: > Not removal, commit 3351b16af494 ("mm/filemap: add static for function > __add_to_page_cache_locked") made the function static which breaks the > build in btfids phase - but it seems to happen only on some > architectures. In our case, ppc64, ppc64le and riscv64 are broken, > x86_64, i586 and s390x succeed. (I made a mistake above, aarch64 did not > fail - but only because it was not built at all.) x86_64 fails for me: LD vmlinux BTFIDS vmlinux FAILED unresolved symbol __add_to_page_cache_locked make: *** [Makefile:1170: vmlinux] Error 255