From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by kanga.kvack.org (Postfix) with ESMTP id 6DF60828DE for ; Sat, 9 Jan 2016 12:48:04 -0500 (EST) Received: by mail-wm0-f53.google.com with SMTP id f206so168272423wmf.0 for ; Sat, 09 Jan 2016 09:48:04 -0800 (PST) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com. [2a00:1450:400c:c09::244]) by mx.google.com with ESMTPS id o126si8101034wmb.73.2016.01.09.09.48.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Jan 2016 09:48:03 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id f206so20297579wmf.2 for ; Sat, 09 Jan 2016 09:48:03 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <19f6403f2b04d3448ed2ac958e656645d8b6e70c.1452297867.git.tony.luck@intel.com> Date: Sat, 9 Jan 2016 09:48:02 -0800 Message-ID: Subject: Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() From: Tony Luck Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Andy Lutomirski Cc: linux-nvdimm , Dan Williams , Borislav Petkov , "linux-kernel@vger.kernel.org" , Andrew Morton , Robert , Ingo Molnar , "linux-mm@kvack.org" , X86 ML On Fri, Jan 8, 2016 at 5:49 PM, Andy Lutomirski wrote: > On Jan 8, 2016 4:19 PM, "Tony Luck" wrote: >> >> Make use of the EXTABLE_FAULT exception table entries. This routine >> returns a structure to indicate the result of the copy: > > Perhaps this is silly, but could we make this feature depend on ERMS > and thus make the code a lot simpler? ERMS? > Also, what's the sfence for? You don't seem to be using any > non-temporal operations. Ah - left over from the original function that this was cloned from (which did use non-temporal operations). Will delete. -Tony -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org