From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03279C433DB for ; Fri, 26 Feb 2021 03:27:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C8E764EE4 for ; Fri, 26 Feb 2021 03:27:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C8E764EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 768266B0005; Thu, 25 Feb 2021 22:27:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7177C6B0006; Thu, 25 Feb 2021 22:27:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62E3D6B006C; Thu, 25 Feb 2021 22:27:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 4DAA86B0005 for ; Thu, 25 Feb 2021 22:27:00 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1ABEED237 for ; Fri, 26 Feb 2021 03:27:00 +0000 (UTC) X-FDA: 77858982600.03.3ED2925 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf07.hostedemail.com (Postfix) with ESMTP id 246C5A0000FF for ; Fri, 26 Feb 2021 03:26:59 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id 17so4548346pli.10 for ; Thu, 25 Feb 2021 19:26:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=78pTGGTVx/VDUeMbmDair/QeL261AqryHviFTtBRyxQ=; b=lzD5E2Oep+L+vhd/Q/RENatwuCz++QZ0QwHAhUFQuN+h247ey8hI2Ip3V32+HYHDWG AVADNEmksL6cd5g0x0wgXYkdDBD5g7JrDg8btmO2a3rNaVEUxXqTF38/XgYUMQnc1h6F i/vsAz0n7XkxZx/1x83xCSBpkZTS8JhKfkgjnY1qwY2p9maP5gug2S2mxZmIeWuqF7zi c3NZpbCMpGTbHvJratl4DojAjMf3wcbc74dQ3sYTDTAlMIThl7k02umgA4Aa56MVsfJf qFofPk+NUwJONgTiWwWs7OfALK5WwmhdEz6GMJlBI2J+wuhrDchRU/lkdr8rqHfCbC9n aV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=78pTGGTVx/VDUeMbmDair/QeL261AqryHviFTtBRyxQ=; b=A5HvFfxFaZ5cHF8wz2l0mfju9FGJv3uSTY/DHjESf6BCfpjHZPt/ReAXSDl/SC8LU0 f6VHojX2WH7KxpPBZOdf1nnSFhLtzcOsysCb0I3gN43vDxBMC7nIgzsbTbY1kd1/OzaN PSrS3a40wQMj+u7fKgyWlKto6+xRLe0ZV03nk0t5u2csQvXtcgtgV6iUIh9sTPiE0QVX e7rfpE0xGJWLcEzoO8EutIDrtQYLfd0eaMEemv4RdzAvvw2AjAwc02GfPcGDysdELgd6 LgU622EIxEju8TlU+b8sOl1T8bIU1da5aZHzGH1SK0TmtWerNanbUtMPJWKD+G88JGB6 ukjQ== X-Gm-Message-State: AOAM5312Rr40VpVQ2mFi6cu6m9r58yiAZ5Vidmr+Pnf5u2Q52tXPBX48 QF2ZUcPkfGgz+tU/h1ELIg1xSI8yjr4CAmvKF9U= X-Google-Smtp-Source: ABdhPJzPoyARR7hP06SshIwTt+qf4VOctmLs1N1tfwpTWEpldqn4+rEfXELdgPxKpjR9PICNZJSyoZ2ZcqZHSdsg0To= X-Received: by 2002:a17:90a:cb12:: with SMTP id z18mr1186334pjt.163.1614310018579; Thu, 25 Feb 2021 19:26:58 -0800 (PST) MIME-Version: 1.0 References: <20210224151619.67c29731@alex-virtual-machine> <20210224103105.GA16368@linux> <20210225114329.4e1a41c6@alex-virtual-machine> <20210225112818.GA10141@hori.linux.bs1.fc.nec.co.jp> <20210225113930.GA7227@localhost.localdomain> <20210225123806.GA15006@hori.linux.bs1.fc.nec.co.jp> <20210225181542.GA178925@agluck-desk2.amr.corp.intel.com> <20210226021907.GA27861@hori.linux.bs1.fc.nec.co.jp> In-Reply-To: <20210226021907.GA27861@hori.linux.bs1.fc.nec.co.jp> From: Tony Luck Date: Thu, 25 Feb 2021 19:26:47 -0800 Message-ID: Subject: Re: [PATCH] mm,hwpoison: return -EBUSY when page already poisoned To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: Oscar Salvador , Aili Yao , "david@redhat.com" , "akpm@linux-foundation.org" , "bp@alien8.de" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "inux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "yangfeng1@kingsoft.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 246C5A0000FF X-Stat-Signature: 8hjzjrpwh5ah8tadpsbxcs91c77afqs7 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail-pl1-f177.google.com; client-ip=209.85.214.177 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614310019-189528 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 25, 2021 at 6:23 PM HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80=80= =E7=9B=B4=E4=B9=9F) wrote: > > On Thu, Feb 25, 2021 at 10:15:42AM -0800, Luck, Tony wrote: > > CPU3 reads the poison and starts along same path that CPU2 > > did. > > I think that the MCE loop happening on CPU2 and CPU3 is unexpected > and these threads should immediately kill the current process on > each CPU. force_sig_mceerr() in kill_me_maybe() is supposed to do it, > so Aili's patch would fix this issue too? It would stop the looping. But for the case where the error came from user code we don't have the virtual address that was accessed at this point (normally this address is found during the reverse lokup from the physical address inside memory_failure()). So we can send a generic SIGBUS, but not one with the usual extra information about the location of the error. -Tony