From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx189.postini.com [74.125.245.189]) by kanga.kvack.org (Postfix) with SMTP id B6A9D6B0002 for ; Tue, 16 Apr 2013 08:21:48 -0400 (EDT) Received: by mail-ob0-f172.google.com with SMTP id v19so255211obq.17 for ; Tue, 16 Apr 2013 05:21:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130411185632.GA7569@redhat.com> References: <20130411185632.GA7569@redhat.com> Date: Tue, 16 Apr 2013 08:21:47 -0400 Message-ID: Subject: Re: print out hardware name & modules list when we encounter bad page tables. From: Josh Boyer Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Dave Jones , Linus Torvalds , Linux Kernel , Linux-MM On Thu, Apr 11, 2013 at 2:56 PM, Dave Jones wrote: > Given we have been seeing a lot of reports of page table corruption > for a while now, perhaps if we print out the hardware name, and list > of modules loaded, we might see some patterns emerging. > > Signed-off-by: Dave Jones > > diff -durpN '--exclude-from=/home/davej/.exclude' /home/davej/src/kernel/git-trees/linux/include/asm-generic/bug.h linux-dj/include/asm-generic/bug.h > --- linux/include/asm-generic/bug.h 2013-01-04 18:57:12.604282214 -0500 > +++ linux-dj/include/asm-generic/bug.h 2013-02-28 20:04:37.649304147 -0500 > @@ -55,6 +55,8 @@ struct bug_entry { > #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while(0) > #endif > > +void print_hardware_dmi_name(void); > + > /* > * WARN(), WARN_ON(), WARN_ON_ONCE, and so on can be used to report > * significant issues that need prompt attention if they should ever > diff -durpN '--exclude-from=/home/davej/.exclude' /home/davej/src/kernel/git-trees/linux/kernel/panic.c linux-dj/kernel/panic.c > --- linux/kernel/panic.c 2013-02-26 14:41:18.544116674 -0500 > +++ linux-dj/kernel/panic.c 2013-02-28 20:04:37.666304115 -0500 > @@ -397,16 +397,22 @@ struct slowpath_args { > va_list args; > }; > > -static void warn_slowpath_common(const char *file, int line, void *caller, > - unsigned taint, struct slowpath_args *args) > +void print_hardware_dmi_name(void) > { This fails to build on arches that define __WARN_TAINT. Just move the new function definition above the WANT_WARN_ON_SLOWPATH define and it should be fine. josh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org