linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: raise MemFree by reverting percpu_pagelist_fraction to 0
Date: Fri, 11 May 2012 09:54:18 -0700	[thread overview]
Message-ID: <CA+55aFztbcB1sULup-rCsWmOaC7RFLvuJ=sqGQz=SAKzys02mw@mail.gmail.com> (raw)
In-Reply-To: <CA+1xoqc15HY1rECsJ6Aj1WMzwT12z4DByJhFopyBAiKawEFh3Q@mail.gmail.com>

On Fri, May 11, 2012 at 9:35 AM, Sasha Levin <levinsasha928@gmail.com> wrote:
>
> Once it's on, we reserve 1/x of the pages for the pagelists. I'm not
> sure why 8 was selected in the first place, but I guess it made sense
> that you don't want to reserve 15%+ of your memory for the pagelists.

Why not just accept any number, but turn small numbers into the minimum?

And if it's a per-cpu, then the minimum had better depend on number of
CPU's anyway. 15% of memory on a single-cpu already sounds insanely
high, but if you have several cpu's, it's going to be just totally
crazy.

So a minimum of 8 already sounds broken. Exposing that minimum in a
way that makes it impossible to reset it sounds just insane.

                    Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-05-11 16:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  8:00 Hugh Dickins
2012-05-11  8:30 ` Sasha Levin
2012-05-11  8:38   ` Minchan Kim
2012-05-11  9:01     ` Minchan Kim
2012-05-11 16:27       ` Linus Torvalds
2012-05-11 16:35         ` Sasha Levin
2012-05-11 16:54           ` Linus Torvalds [this message]
2012-05-14  8:51           ` Cong Wang
2012-05-11 14:10     ` Hugh Dickins
2012-05-14  1:51       ` Minchan Kim
2012-05-11 16:26 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFztbcB1sULup-rCsWmOaC7RFLvuJ=sqGQz=SAKzys02mw@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox