From: Linus Torvalds <torvalds@linux-foundation.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Dave Hansen <dave.hansen@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] mremap: fix race between mremap() and page cleanning
Date: Thu, 17 Nov 2016 09:53:21 -0800 [thread overview]
Message-ID: <CA+55aFzHfpZckv8ck19fZSFK+3TmR5eF=BsDzhwVGKrbyEBjEw@mail.gmail.com> (raw)
In-Reply-To: <026b73f6-ca1d-e7bb-766c-4aaeb7071ce6@intel.com>
On Thu, Nov 10, 2016 at 1:16 AM, Aaron Lu <aaron.lu@intel.com> wrote:
> Prior to 3.15, there was a race between zap_pte_range() and
> page_mkclean() where writes to a page could be lost. Dave Hansen
> discovered by inspection that there is a similar race between
> move_ptes() and page_mkclean().
Ok, patch applied.
I'm not entirely happy with the force_flush vs need_flush games, and I
really think this code should be updated to use the same "struct
mmu_gather" that we use for the other TLB flushing cases (no need for
the page freeing batching, but the tlb_flush_mmu_tlbonly() logic
should be the same).
But I guess that's a bigger change, so that wouldn't be approriate for
rc5 or stable back-porting anyway. But it would be lovely if somebody
could look at that. Hint hint.
Hmm?
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-17 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 9:16 Aaron Lu
2016-11-17 7:45 ` Aaron Lu
2016-11-17 17:53 ` Linus Torvalds [this message]
2016-11-18 2:48 ` Aaron Lu
2016-11-28 8:37 ` [PATCH 0/2] use mmu gather logic for tlb flush in mremap Aaron Lu
2016-11-28 8:39 ` [PATCH 1/2] tlb: export tlb_flush_mmu_tlbonly Aaron Lu
2016-11-28 8:40 ` [PATCH 2/2] mremap: use mmu gather logic for tlb flush in mremap Aaron Lu
2016-11-28 17:15 ` Linus Torvalds
2016-11-29 2:57 ` [PATCH] mremap: move_ptes: check pte dirty after its removal Aaron Lu
2016-11-29 3:06 ` Linus Torvalds
2016-11-29 3:22 ` Aaron Lu
2016-11-29 5:27 ` [PATCH update] " Aaron Lu
2016-11-28 17:32 ` [PATCH 2/2] mremap: use mmu gather logic for tlb flush in mremap Dave Hansen
2016-11-28 17:42 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFzHfpZckv8ck19fZSFK+3TmR5eF=BsDzhwVGKrbyEBjEw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox