From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx133.postini.com [74.125.245.133]) by kanga.kvack.org (Postfix) with SMTP id C75FE6B0068 for ; Tue, 30 Oct 2012 21:26:08 -0400 (EDT) Received: by mail-wg0-f45.google.com with SMTP id dq12so528837wgb.26 for ; Tue, 30 Oct 2012 18:26:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1351646186.4004.41.camel@gandalf.local.home> References: <1351622772-16400-1-git-send-email-levinsasha928@gmail.com> <20121030214257.GB2681@htj.dyndns.org> <1351646186.4004.41.camel@gandalf.local.home> From: Linus Torvalds Date: Tue, 30 Oct 2012 18:25:46 -0700 Message-ID: Subject: Re: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Steven Rostedt Cc: Sasha Levin , Tejun Heo , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, paul.gortmaker@windriver.com, davem@davemloft.net, mingo@elte.hu, ebiederm@xmission.com, aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org, josh@joshtriplett.org, eric.dumazet@gmail.com, mathieu.desnoyers@efficios.com, axboe@kernel.dk, agk@redhat.com, dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com, teigland@redhat.com, Trond.Myklebust@netapp.com, bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com, venkat.x.venkatsubra@oracle.com, ejt@redhat.com, snitzer@redhat.com, edumazet@google.com, linux-nfs@vger.kernel.org, dev@openvswitch.org, rds-devel@oss.oracle.com, lw@cn.fujitsu.com On Tue, Oct 30, 2012 at 6:16 PM, Steven Rostedt wrote: > > ({ \ > sizeof(val) <= 4 ? hash_32(val, bits) : hash_long(val, bits); \ > }) > > Is the better way to go. We are C programmers, we like to see the ?: on > a single line if possible. The way you have it, looks like three > statements run consecutively. If we're C programmers, why use the non-standard statement-expression at all? And split it onto three lines when it's just a single one? But whatever. This series has gotten way too much bike-shedding anyway. I think it should just be applied, since it does remove lines of code overall. I'd even possibly apply it to mainline, but it seems to be against linux-next. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org