From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f197.google.com (mail-io0-f197.google.com [209.85.223.197]) by kanga.kvack.org (Postfix) with ESMTP id DA040280395 for ; Tue, 29 Aug 2017 20:11:26 -0400 (EDT) Received: by mail-io0-f197.google.com with SMTP id g33so644762ioj.8 for ; Tue, 29 Aug 2017 17:11:26 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id m100sor2217228iod.20.2017.08.29.17.11.25 for (Google Transport Security); Tue, 29 Aug 2017 17:11:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170829235447.10050-1-jglisse@redhat.com> References: <20170829235447.10050-1-jglisse@redhat.com> From: Linus Torvalds Date: Tue, 29 Aug 2017 17:11:24 -0700 Message-ID: Subject: Re: [PATCH 00/13] mmu_notifier kill invalidate_page callback Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Bernhard Held , Adam Borowski Cc: Linux Kernel Mailing List , linux-mm , "Kirill A . Shutemov" , Andrew Morton , Andrea Arcangeli , Joerg Roedel , Dan Williams , Sudeep Dutt , Ashutosh Dixit , Dimitri Sivanich , Jack Steiner , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , ppc-dev , DRI , amd-gfx@lists.freedesktop.org, "linux-rdma@vger.kernel.org" , "open list:AMD IOMMU (AMD-VI)" , xen-devel , KVM list On Tue, Aug 29, 2017 at 4:54 PM, J=C3=A9r=C3=B4me Glisse wrote: > > Note this is barely tested. I intend to do more testing of next few days > but i do not have access to all hardware that make use of the mmu_notifie= r > API. Thanks for doing this. > First 2 patches convert existing call of mmu_notifier_invalidate_page() > to mmu_notifier_invalidate_range() and bracket those call with call to > mmu_notifier_invalidate_range_start()/end(). Ok, those two patches are a bit more complex than I was hoping for, but not *too* bad. And the final end result certainly looks nice: > 16 files changed, 74 insertions(+), 214 deletions(-) Yeah, removing all those invalidate_page() notifiers certainly makes for a nice patch. And I actually think you missed some more lines that can now be removed: kvm_arch_mmu_notifier_invalidate_page() should no longer be needed either, so you can remove all of those too (most of them are empty inline functions, but x86 has one that actually does something. So there's an added 30 or so dead lines that should be removed in the kvm patch, I think. But from a _very_ quick read-through this looks fine. But it obviously needs testing. People - *especially* the people who saw issues under KVM - can you try out J=C3=A9r=C3=B4me's patch-series? I aded some people to the cc, the = full series is on lkml. J=C3=A9r=C3=B4me - do you have a git branch for people t= o test that they could easily pull and try out? Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org