From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Jones <davej@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: a whole bunch of crashes since todays -mm merge.
Date: Thu, 7 Jun 2012 18:25:45 -0700 [thread overview]
Message-ID: <CA+55aFyxN8vQo7UXwJ0V1jZyE137aX2ZwtXVvGhNFTz4NjxvDg@mail.gmail.com> (raw)
In-Reply-To: <20120608011215.GB7191@redhat.com>
On Thu, Jun 7, 2012 at 6:12 PM, Dave Jones <davej@redhat.com> wrote:
>
> I don't think so ? I have CONFIG_SPLIT_PTLOCK_CPUS=999999,
> so it looks like that never gets defined unless I'm missing something obvious.
Yeah, I think you're right. And in that case I don't think the
sync_mm_rss() patch should matter. Although it does move mm_release()
around, which makes me nervous - that could cause independent issues.
I never got that far in analyzing the patch, because I got hung up on
the obvious problems and decided to revert it as obviously broken and
untested.
Btw, I really wish we didn't do that complicated USE_SPLIT_PTLOCKS ->
SPLIT_RSS_COUNTING stuff hidden in the header files. I suspect we
should do it in the mm/Kconfig file instead, and make them normal
config options. I think that makes it easier to grep for.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-08 1:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 0:24 Dave Jones
2012-06-08 0:52 ` Linus Torvalds
2012-06-08 1:00 ` Dave Jones
2012-06-08 1:06 ` Linus Torvalds
2012-06-08 1:12 ` Dave Jones
2012-06-08 1:25 ` Linus Torvalds [this message]
2012-06-08 1:05 ` Andrew Morton
2012-06-08 1:09 ` Linus Torvalds
2012-06-08 2:22 ` Dave Jones
2012-06-08 1:39 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFyxN8vQo7UXwJ0V1jZyE137aX2ZwtXVvGhNFTz4NjxvDg@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox