From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
greg@suse.cz, Markus Trippelsdorf <markus@trippelsdorf.de>,
Arkadiusz Miskiewicz <a.miskiewicz@gmail.com>,
Ralf-Peter Rohbeck <Ralf-Peter.Rohbeck@quantum.com>,
Jiri Slaby <jslaby@suse.com>, Olaf Hering <olaf@aepfle.de>,
Vlastimil Babka <vbabka@suse.cz>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: OOM detection regressions since 4.7
Date: Tue, 23 Aug 2016 15:08:05 -0400 [thread overview]
Message-ID: <CA+55aFyTnS6Z3UHcJfTO-dsNBS-ZXaDmYU42_fDWPO0qhc2xFg@mail.gmail.com> (raw)
In-Reply-To: <20160823073318.GA23577@dhcp22.suse.cz>
On Tue, Aug 23, 2016 at 3:33 AM, Michal Hocko <mhocko@kernel.org> wrote:
>
> I would argue that CONFIG_COMPACTION=n behaves so arbitrary for high
> order workloads that calling any change in that behavior a regression
> is little bit exaggerated.
Well, the thread info allocations certainly haven't been big problems
before. So regressing those would seem to be a real regression.
What happened? We've done the order-2 allocation for the stack since
May 2014, so that isn't new. Did we cut off retries for low orders?
So I would not say that it's an exaggeration to say that order-2
allocations failing is a regression.
Yes, yes, for 4.9 we may well end up using vmalloc for the kernel
stack, but there are certainly other things that want low-order
(non-hugepage) allocations. Like kmalloc(), which often ends up using
small orders just to pack data more efficiently (allocating a single
page can be hugely wasteful even if the individual allocations are
smaller than that - so allocating a few pages and packing more
allocations into it helps fight internal fragmentation)
So this definitely needs to be fixed for 4.7 (and apparently there's a
few patches still pending even for 4.8)
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-23 19:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 9:32 Michal Hocko
2016-08-22 9:37 ` Michal Hocko
2016-08-22 10:05 ` Greg KH
2016-08-22 10:54 ` Michal Hocko
2016-08-22 13:31 ` Greg KH
2016-08-22 13:42 ` Michal Hocko
2016-08-22 14:02 ` Greg KH
2016-08-22 22:05 ` Andrew Morton
2016-08-23 7:43 ` Michal Hocko
2016-08-25 7:11 ` Michal Hocko
2016-08-25 7:17 ` Olaf Hering
2016-08-29 14:52 ` Olaf Hering
2016-08-29 14:54 ` Olaf Hering
2016-08-29 15:07 ` Michal Hocko
2016-08-29 15:59 ` Olaf Hering
2016-08-29 17:28 ` Linus Torvalds
2016-08-29 17:52 ` Jeff Layton
2016-08-28 5:50 ` Arkadiusz Miskiewicz
2016-08-25 20:30 ` Ralf-Peter Rohbeck
2016-08-26 6:26 ` Michal Hocko
2016-08-26 20:17 ` Ralf-Peter Rohbeck
2016-08-22 10:16 ` Markus Trippelsdorf
2016-08-22 10:56 ` Michal Hocko
2016-08-22 11:01 ` Markus Trippelsdorf
2016-08-22 11:13 ` Michal Hocko
2016-08-22 11:20 ` Markus Trippelsdorf
2016-08-23 4:52 ` Joonsoo Kim
2016-08-23 7:33 ` Michal Hocko
2016-08-23 7:40 ` Markus Trippelsdorf
2016-08-23 7:48 ` Michal Hocko
2016-08-23 19:08 ` Linus Torvalds [this message]
2016-08-24 6:32 ` Michal Hocko
2016-08-24 5:01 ` Joonsoo Kim
2016-08-24 7:04 ` Michal Hocko
2016-08-24 7:29 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFyTnS6Z3UHcJfTO-dsNBS-ZXaDmYU42_fDWPO0qhc2xFg@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=Ralf-Peter.Rohbeck@quantum.com \
--cc=a.miskiewicz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greg@suse.cz \
--cc=iamjoonsoo.kim@lge.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markus@trippelsdorf.de \
--cc=mhocko@kernel.org \
--cc=olaf@aepfle.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox