From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx180.postini.com [74.125.245.180]) by kanga.kvack.org (Postfix) with SMTP id 4EBBB6B00EC for ; Fri, 23 Mar 2012 17:36:10 -0400 (EDT) Received: by wibhq7 with SMTP id hq7so2055028wib.8 for ; Fri, 23 Mar 2012 14:36:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1332228283-29077-1-git-send-email-m.szyprowski@samsung.com> References: <1332228283-29077-1-git-send-email-m.szyprowski@samsung.com> From: Linus Torvalds Date: Fri, 23 Mar 2012 14:35:48 -0700 Message-ID: Subject: Re: [GIT PULL] DMA-mapping framework updates for 3.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski , Dave Airlie Cc: linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , Thomas Gleixner , Andrew Morton , Arnd Bergmann , FUJITA Tomonori , microblaze-uclinux@itee.uq.edu.au, linux-arch@vger.kernel.org, x86@kernel.org, linux-sh@vger.kernel.org, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org, discuss@x86-64.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, Jonathan Corbet , Kyungmin Park , Andrzej Pietrasiewicz On Tue, Mar 20, 2012 at 12:24 AM, Marek Szyprowski wrote: > > =A0git://git.infradead.org/users/kmpark/linux-samsung dma-mapping-next > > Those patches introduce a new alloc method (with support for memory > attributes) in dma_map_ops structure, which will later replace > dma_alloc_coherent and dma_alloc_writecombine functions. So I'm quite unhappy with these patches. Here's just the few problems I saw from some *very* quick look-through of the git tree: - I'm not seeing ack's from the architecture maintainers for the patches that change some architecture. - Even more importantly, what I really want is acks and comments from the people who are expected to *use* this. - it looks like patches break compilation half-way through the series. Just one example I noticed: the "x86 adaptation" patch changes the functions in lib/swiotlb.c, but afaik ia64 *also* uses those. So now ia64 is broken until a couple of patches later. I suspect there are other examples like that. - the sign-off chains are odd. What happened there? Several patches are signed off by Kyungmin Park, but he doesn't seem to be "in the chain" at all. Whazzup? (*) (Btw, I notice the same thing in the tree I pulled from Dave Airlie, btw - what the F is going on with samsung submissions - those are marked as committed by Dave Airlie, and don't have Dave in the sign-off chain at all!) - Finally, how/why are "dma attributes" different from the per-device dma limits ("device_dma_parameters") Hmm? Linus (*) Btw, I notice the same thing in the tree I pulled from Dave Airlie, btw - what the F is going on with samsung submissions - those are marked as committed by Dave Airlie, and don't have Dave in the sign-off chain at all! Dave? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org