From: Linus Torvalds <torvalds@linux-foundation.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Tejun Heo <tj@kernel.org>,
syzbot+c0cf869505e03bdf1a24@syzkaller.appspotmail.com,
christophe.jaillet@wanadoo.fr,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
syzkaller-bugs@googlegroups.com, zhangweiping@didichuxing.com,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: INFO: task hung in wb_shutdown (2)
Date: Tue, 01 May 2018 16:06:48 +0000 [thread overview]
Message-ID: <CA+55aFxaa_+uZ=bOVdevcUwG7ncue7O+i06q4Kb=bWACGwCBjQ@mail.gmail.com> (raw)
In-Reply-To: <43302799-1c50-4cab-b974-9fe1ca584813@I-love.SAKURA.ne.jp>
On Tue, May 1, 2018 at 3:27 AM Tetsuo Handa <
penguin-kernel@i-love.sakura.ne.jp> wrote:
> Can you review this patch? syzbot has hit this bug for nearly 4000 times
but
> is still unable to find a reproducer. Therefore, the only way to test
would be
> to apply this patch upstream and test whether the problem is solved.
Looks ok to me, except:
> > smp_wmb();
> > clear_bit(WB_shutting_down, &wb->state);
> > + smp_mb(); /* advised by wake_up_bit() */
> > + wake_up_bit(&wb->state, WB_shutting_down);
This whole sequence really should just be a pattern with a helper function.
And honestly, the pattern probably *should* be
clear_bit_unlock(bit, &mem);
smp_mb__after_atomic()
wake_up_bit(&mem, bit);
which looks like it is a bit cleaner wrt memory ordering rules.
Linus
next prev parent reply other threads:[~2018-05-01 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 17:10 syzbot
2018-04-24 12:19 ` Tetsuo Handa
2018-05-01 10:27 ` Tetsuo Handa
2018-05-01 16:06 ` Linus Torvalds [this message]
2018-05-01 21:30 ` Jens Axboe
2018-05-01 22:14 ` Tetsuo Handa
2018-05-03 15:13 ` Jan Kara
2018-05-03 15:25 ` Jens Axboe
2018-05-01 16:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxaa_+uZ=bOVdevcUwG7ncue7O+i06q4Kb=bWACGwCBjQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dvyukov@google.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+c0cf869505e03bdf1a24@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox