From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Andrew Lutomirski" <luto@kernel.org>,
"Kees Cook" <keescook@google.com>,
"Hugh Dickins" <hughd@google.com>,
"Jürgen Groß" <jgross@suse.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
namit@vmware.com
Subject: Re: [PATCH 00/11] [v4] Use global pages with PTI
Date: Tue, 3 Apr 2018 19:11:41 -0700 [thread overview]
Message-ID: <CA+55aFxYunj-s2N60Q2Y63TsrhJKwqLa=-GJPMb6--RA_ud6Fw@mail.gmail.com> (raw)
In-Reply-To: <20180404010946.6186729B@viggo.jf.intel.com>
On Tue, Apr 3, 2018 at 6:09 PM, Dave Hansen <dave.hansen@linux.intel.com> wrote:
> Changes from v3:
> * Fix whitespace issue noticed by willy
> * Clarify comments about X86_FEATURE_PGE checks
> * Clarify commit message around the necessity of _PAGE_GLOBAL
> filtering when CR4.PGE=0 or PGE is unsupported.
I couldn't see anything odd in this, but I only read the explanations
and the patches, and the devil is in the details.
But it all looks sane to me, and the added comments all seemed like
good ideas. Plus the performance numbers certainly speak for
themselves, even if the big changes are from that Atom microserver
that I probably personally wouldn't want to use anyway ;).
So Ack from me, maybe a weak review.
Linus
prev parent reply other threads:[~2018-04-04 2:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 1:09 Dave Hansen
2018-04-04 1:09 ` [PATCH 01/11] x86/mm: factor out pageattr _PAGE_GLOBAL setting Dave Hansen
2018-04-04 1:09 ` [PATCH 02/11] x86/mm: undo double _PAGE_PSE clearing Dave Hansen
2018-04-04 1:09 ` [PATCH 03/11] x86/mm: introduce "default" kernel PTE mask Dave Hansen
2018-04-04 1:09 ` [PATCH 04/11] x86/espfix: document use of _PAGE_GLOBAL Dave Hansen
2018-04-04 1:09 ` [PATCH 05/11] x86/mm: do not auto-massage page protections Dave Hansen
2018-04-05 19:49 ` Tom Lendacky
2018-04-04 1:10 ` [PATCH 06/11] x86/mm: remove extra filtering in pageattr code Dave Hansen
2018-04-04 1:10 ` [PATCH 07/11] x86/mm: comment _PAGE_GLOBAL mystery Dave Hansen
2018-04-04 1:10 ` [PATCH 08/11] x86/mm: do not forbid _PAGE_RW before init for __ro_after_init Dave Hansen
2018-04-04 1:10 ` [PATCH 09/11] x86/pti: enable global pages for shared areas Dave Hansen
2018-04-04 4:45 ` Nadav Amit
2018-04-04 15:52 ` Dave Hansen
2018-04-04 16:09 ` Nadav Amit
2018-04-04 18:14 ` Thomas Gleixner
2018-04-04 1:10 ` [PATCH 10/11] x86/pti: never implicitly clear _PAGE_GLOBAL for kernel image Dave Hansen
2018-04-04 1:10 ` [PATCH 11/11] x86/pti: leave kernel text global for !PCID Dave Hansen
2018-04-04 7:42 ` kbuild test robot
2018-04-04 7:42 ` [RFC PATCH] x86/pti: pti_clone_pmds can be static kbuild test robot
2018-04-04 2:11 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxYunj-s2N60Q2Y63TsrhJKwqLa=-GJPMb6--RA_ud6Fw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=hughd@google.com \
--cc=jgross@suse.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=namit@vmware.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox