From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, page_vma_mapped: Introduce pfn_in_hpage()
Date: Mon, 22 Jan 2018 12:16:52 -0800 [thread overview]
Message-ID: <CA+55aFxB_+qyhxaQB7EucJ7e3JO5nJjX=ewBYttmT4gFZSHGtA@mail.gmail.com> (raw)
In-Reply-To: <20180122092230.42908-1-kirill.shutemov@linux.intel.com>
On Mon, Jan 22, 2018 at 1:22 AM, Kirill A. Shutemov
<kirill.shutemov@linux.intel.com> wrote:
> The new helper would check if the pfn belongs to the page. For huge
> pages it checks if the PFN is within range covered by the huge page.
>
> The helper is used in check_pte(). The original code the helper replaces
> had two call to page_to_pfn(). page_to_pfn() is relatively costly.
>
> Although current GCC is able to optimize code to have one call, it's
> better to do this explicitly.
Thanks, I applied it directly, since your page_vma_mapped fix was
still my top commit, and I asked for this cleanup.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-01-22 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 9:22 Kirill A. Shutemov
2018-01-22 20:16 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxB_+qyhxaQB7EucJ7e3JO5nJjX=ewBYttmT4gFZSHGtA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox