From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com [209.85.213.173]) by kanga.kvack.org (Postfix) with ESMTP id 2A09E6B007E for ; Sat, 19 Mar 2016 21:20:25 -0400 (EDT) Received: by mail-ig0-f173.google.com with SMTP id av4so63497688igc.1 for ; Sat, 19 Mar 2016 18:20:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160314171737.GK17923@kvack.org> References: <20160115202131.GH6330@kvack.org> <20160120195957.GV6033@dastard> <20160120204449.GC12249@kvack.org> <20160120214546.GX6033@dastard> <20160123043922.GF6033@dastard> <20160314171737.GK17923@kvack.org> Date: Sat, 19 Mar 2016 18:20:24 -0700 Message-ID: Subject: Re: aio openat Re: [PATCH 07/13] aio: enabled thread based async fsync From: Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Benjamin LaHaise Cc: Dave Chinner , Al Viro , Andrew Morton , linux-fsdevel , Linux API , Linux Kernel Mailing List , linux-aio@kvack.org, linux-mm On Mon, Mar 14, 2016 at 10:17 AM, Benjamin LaHaise wrote: > > I had some time last week to make an aio openat do what it can in > submit context. The results are an improvement: when openat is handled > in submit context it completes in about half the time it takes compared > to the round trip via the work queue, and it's not terribly much code > either. This looks good to me, and I do suspect that any of these aio paths should strive to have a synchronous vs threaded model. I think that makes the whole thing much more interesting from a performance standpoint. I still think the aio interface is really nasty, but this together with the table-based approach you posted earlier does make me a _lot_ happier about the implementation.It just looks way less hacky, and now it ends up exposing a rather more clever implementation too. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org