From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC, PATCH 0/2] mm: map few pages around fault address if they are in page cache
Date: Tue, 11 Feb 2014 15:52:03 -0800 [thread overview]
Message-ID: <CA+55aFx+-ynTnj2ycq6JFo56bo978n6ZjB6LBue-jb0ipw1tXg@mail.gmail.com> (raw)
In-Reply-To: <20140211133956.ef8b9417ed09651fbcf6d3a9@linux-foundation.org>
On Tue, Feb 11, 2014 at 1:39 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> hm, we tried that a couple of times, many years ago. Try
> https://www.google.com/#q="faultahead" then spend a frustrating hour
> trying to work out what went wrong.
>
> Of course, the implementation might have been poor and perhaps we can
> get this to work.
Kirill's patch looks good, and shouldn't have much overhead, but the
fact that it doesn't work is obviously something of a strike against
it.. ;)
I don't see anything obviously wrong in it, although I think 32
fault-around pages might be excessive (it uses stack space, and there
are expenses wrt accounting and tear-down). But the patch is also
against some odd kernel (presumably -mm) with lots of other changes,
so I don't even know what it might be missing.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-11 23:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 3:05 Kirill A. Shutemov
2014-02-11 3:05 ` [PATCH 1/2] mm: extend ->fault interface to fault in few pages around fault address Kirill A. Shutemov
2014-02-11 3:05 ` [PATCH 2/2] mm: implement FAULT_FLAG_AROUND in filemap_fault() Kirill A. Shutemov
2014-02-11 21:39 ` [RFC, PATCH 0/2] mm: map few pages around fault address if they are in page cache Andrew Morton
2014-02-11 23:52 ` Linus Torvalds [this message]
2014-02-11 23:58 ` Kirill A. Shutemov
2014-02-12 0:25 ` Linus Torvalds
2014-02-12 0:44 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFx+-ynTnj2ycq6JFo56bo978n6ZjB6LBue-jb0ipw1tXg@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox