From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mel Gorman <mgorman@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Linux-X86 <x86@kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Steven Noonan <steven@uplinklabs.net>,
Rik van Riel <riel@redhat.com>,
David Vrabel <david.vrabel@citrix.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2
Date: Tue, 8 Apr 2014 10:01:39 -0700 [thread overview]
Message-ID: <CA+55aFwrwYmWFXWpPeg-keKukW0=dwvmUBuN4NKA=JcseiUX3g@mail.gmail.com> (raw)
In-Reply-To: <20140408164652.GL7292@suse.de>
On Tue, Apr 8, 2014 at 9:46 AM, Mel Gorman <mgorman@suse.de> wrote:
>
> If you are ok with leaving _PAGE_NUMA as _PAGE_PROTNONE
NO I AM NOT!
Dammit, this feature is f*cking brain-damaged.
My complaint has been (and continues to be):
- either it is 100% the same as PROTNONE, in which case thjat
_PAGE_NUMA bit had better go away, and you just use the protnone
helpers!
- if it's not the same as PROTNONE, then it damn well needs a different bit.
You can't have it both ways. You guys tried. The Xen case shows that
trying to distinguish the two DOES NOT WORK. But even apart from the
Xen case, it was just a confusing hell.
Like Yoda said: "Either they are the same or they are not. There is no 'try'".
So pick one solution. Don't try to pick the mixed-up half-way case
that is a disaster and makes no sense.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-08 17:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 13:09 Mel Gorman
2014-04-08 13:09 ` [PATCH 1/5] x86: Require x86-64 for automatic NUMA balancing Mel Gorman
2014-04-08 13:09 ` [PATCH 2/5] x86: Define _PAGE_NUMA by reusing software bits on the PMD and PTE levels Mel Gorman
2014-04-08 13:09 ` [PATCH 3/5] mm: Allow FOLL_NUMA on FOLL_FORCE Mel Gorman
2014-04-08 13:09 ` [PATCH 4/5] mm: use paravirt friendly ops for NUMA hinting ptes Mel Gorman
2014-04-08 17:21 ` David Vrabel
2014-04-15 10:27 ` David Vrabel
2014-04-15 14:44 ` Mel Gorman
2014-04-08 13:09 ` [PATCH 5/5] x86: Allow Xen to enable NUMA_BALANCING Mel Gorman
2014-04-08 14:40 ` [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2 H. Peter Anvin
2014-04-08 15:22 ` Linus Torvalds
2014-04-08 16:04 ` H. Peter Anvin
2014-04-08 16:12 ` Peter Zijlstra
2014-04-08 16:46 ` Mel Gorman
2014-04-08 17:01 ` Linus Torvalds [this message]
2014-04-08 18:51 ` Mel Gorman
2014-04-08 18:55 ` Linus Torvalds
2014-04-08 19:06 ` Mel Gorman
2014-04-08 19:08 ` Rik van Riel
2014-04-08 17:03 ` Mel Gorman
2014-04-08 17:30 ` Peter Zijlstra
2014-04-08 17:41 ` Linus Torvalds
2014-04-08 18:16 ` Cyrill Gorcunov
2014-04-09 6:21 ` Ingo Molnar
2014-04-09 23:34 ` H. Peter Anvin
2014-04-10 0:12 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwrwYmWFXWpPeg-keKukW0=dwvmUBuN4NKA=JcseiUX3g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=david.vrabel@citrix.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=steven@uplinklabs.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox