From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 260DA9000BD for ; Mon, 19 Sep 2011 14:56:04 -0400 (EDT) Received: by wyh13 with SMTP id 13so7424551wyh.30 for ; Mon, 19 Sep 2011 11:56:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20110918170512.GA2351@albatros> <20110919144657.GA5928@albatros> <20110919155718.GB16272@albatros> <20110919161837.GA2232@albatros> <20110919173539.GA3751@albatros> <20110919175856.GA4282@albatros> From: Linus Torvalds Date: Mon, 19 Sep 2011 11:55:42 -0700 Message-ID: Subject: Re: [kernel-hardening] Re: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Vasiliy Kulikov , Andrew Morton , kernel-hardening@lists.openwall.com, Kees Cook , Cyrill Gorcunov , Al Viro , Christoph Lameter , Matt Mackall , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dan Rosenberg , Theodore Tso , Alan Cox , Jesper Juhl On Mon, Sep 19, 2011 at 11:46 AM, Pekka Enberg wrote: > > OK, so what about /proc/meminfo, sysfs, 'perf kmem', and other kernel interfaces > through which you can get direct or indirect information about kernel memory > allocations? Pekka, there are degrees of badness. Also, quite frankly, your argument that /proc/slabinfo is so important for kernel debugging is bogus. Every time I've complained about the fact that the thing is useless AND ACTIVELY MISLEADING because it mixes up all the slabs (so big numbers for "vm_area_struct" might actually be about some other slab entirely, and *has* been, to the point of people wasting time), the answer has been "whatever". You can't have it both ways just to argue for the status quo. Considering how useless /proc/slabinfo actually is today - exactly because of the misleading mixing - I suspect the right thing to do is to make it root-only. Having some aggregate number in /proc/meminfo would probably be fine. And yes, we probably should avoid giving page-level granularity in /proc/meminfo too. Do it in megabytes instead. None of the information there is really relevant at a page level, everybody just wants rough aggregates. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org