From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f199.google.com (mail-io0-f199.google.com [209.85.223.199]) by kanga.kvack.org (Postfix) with ESMTP id 997606B0007 for ; Mon, 16 Apr 2018 15:55:48 -0400 (EDT) Received: by mail-io0-f199.google.com with SMTP id p18so15205733ioe.9 for ; Mon, 16 Apr 2018 12:55:48 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id t7-v6sor4572566itf.49.2018.04.16.12.55.47 for (Google Transport Security); Mon, 16 Apr 2018 12:55:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180416153816.292a5b5c@gandalf.local.home> References: <20180416153031.GA5039@amd> <20180416155031.GX2341@sasha-vm> <20180416160608.GA7071@amd> <20180416122019.1c175925@gandalf.local.home> <20180416162757.GB2341@sasha-vm> <20180416163952.GA8740@amd> <20180416164310.GF2341@sasha-vm> <20180416125307.0c4f6f28@gandalf.local.home> <20180416170936.GI2341@sasha-vm> <20180416133321.40a166a4@gandalf.local.home> <20180416174236.GL2341@sasha-vm> <20180416142653.0f017647@gandalf.local.home> <20180416144117.5757ee70@gandalf.local.home> <20180416152429.529e3cba@gandalf.local.home> <20180416153816.292a5b5c@gandalf.local.home> From: Linus Torvalds Date: Mon, 16 Apr 2018 12:55:46 -0700 Message-ID: Subject: Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Steven Rostedt Cc: Sasha Levin , Pavel Machek , Petr Mladek , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , Cong Wang , Dave Hansen , Johannes Weiner , Mel Gorman , Michal Hocko , Vlastimil Babka , Peter Zijlstra , Jan Kara , Mathieu Desnoyers , Tetsuo Handa , Byungchul Park , Tejun Heo , Greg KH On Mon, Apr 16, 2018 at 12:38 PM, Steven Rostedt wrote: > > But I don't see in the git history that this was ever reverted. My reply > saying that "I hope it wasn't reverted", was a response for it being > reverted in stable, not mainline. See my other email. If your'e stable maintainer, and you get a report of a commit that causes problems, your first reaction probably really should just be "revert it". You can always re-apply it later, but a patch that causes problems is absolutely very much suspect, and automatically should make any stable maintainer go "that needs much more analysis". Sure, hopefully automation finds the fix too (ie commit 21b81716c6bf "ipr: Fix regression when loading firmware") in mainline. It did have the proper "fixes" tag, so it should hopefully have been easy to find by the automation that stable people use. But at the same time, I still maintain that "just revert it" is rather likely the right solution for stable. If it had a bug once, maybe it shouldn't have been applied in the first place. The author can then get notified by the other stable automation, and at that point argue for "yeah, it was buggy, but together with this other fix it's really important". But even when that is the case, I really don't see that the author should complain about it being reverted. Because it's *such* a no-brainer in stable. Linus