From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christoph Lameter <cl@linux.com>
Cc: Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>, Shaohua Li <shli@fb.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [GIT PULL] workqueue fixes for v4.3-rc5
Date: Wed, 14 Oct 2015 11:40:53 -0700 [thread overview]
Message-ID: <CA+55aFwSjroKXPjsO90DWULy-H8e9Fs=ZDRVkJvQgAZPk1YYRw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1510141301340.13301@east.gentwo.org>
On Wed, Oct 14, 2015 at 11:03 AM, Christoph Lameter <cl@linux.com> wrote:
> On Wed, 14 Oct 2015, Linus Torvalds wrote:
>>
>> So why is this a bugfix? If cpu == WORK_CPU_UNBOUND, then things
>> _shouldn't_ care which cpu it gets run on.
>
> UNBOUND means not fixed to a processor.
That's exactly what I'm saying.
And "schedule_delayed_work()" uses WORK_CPU_UNBOUND.
YOUR code assumes that means "local CPU".
And I say that's bogus.
In this email you seem to even agree that its' bogus, but then you
wrote another email saying that the code isn't confused, because it
uses "schedule_delayed_work()" on the CPU that it wants to run the
code on.
I'm saying that mm/vmstat.c should use "schedule_delayed_work_on()".
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-10-14 18:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151013214952.GB23106@mtj.duckdns.org>
2015-10-14 16:30 ` Linus Torvalds
2015-10-14 16:57 ` Tejun Heo
2015-10-14 17:36 ` Linus Torvalds
2015-10-14 17:57 ` Christoph Lameter
2015-10-14 18:37 ` Linus Torvalds
2015-10-14 18:58 ` Christoph Lameter
2015-10-14 19:01 ` Linus Torvalds
2015-10-14 19:02 ` Tejun Heo
2015-10-14 19:16 ` Linus Torvalds
2015-10-14 19:38 ` Tejun Heo
2015-10-14 20:10 ` Linus Torvalds
2015-10-14 20:24 ` Tejun Heo
2015-10-19 3:51 ` Mike Galbraith
2015-10-16 19:51 ` [PATCH] vmstat_update: ensure work remains on the same core Chris Metcalf
2015-10-16 19:54 ` Linus Torvalds
2015-10-14 18:03 ` [GIT PULL] workqueue fixes for v4.3-rc5 Christoph Lameter
2015-10-14 18:40 ` Linus Torvalds [this message]
2015-10-14 18:59 ` Christoph Lameter
2015-10-14 19:10 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwSjroKXPjsO90DWULy-H8e9Fs=ZDRVkJvQgAZPk1YYRw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=shli@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox