From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Bob Peterson <rpeterso@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
swhiteho@redhat.com, luto@kernel.org, agruenba@redhat.com,
peterz@infradead.org, mgorman@techsingularity.net,
linux-mm@kvack.org
Subject: Re: [RFC][PATCH] make global bitlock waitqueues per-node
Date: Mon, 19 Dec 2016 15:07:34 -0800 [thread overview]
Message-ID: <CA+55aFwK6JdSy9v_BkNYWNdfK82sYA1h3qCSAJQ0T45cOxeXmQ@mail.gmail.com> (raw)
In-Reply-To: <20161219225826.F8CB356F@viggo.jf.intel.com>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On Dec 19, 2016 2:58 PM, "Dave Hansen" <dave.hansen@linux.intel.com> wrote:
This boots in a small VM and on a multi-node NUMA system, but has not
been tested widely.
No, this is wrong.
+wait_queue_head_t *bit_waitqueue(void *word, int bit)
+{
+ const int __maybe_unused nid = page_to_nid(virt_to_page(word));
+
+ return __bit_waitqueue(word, bit, nid);
No can do. Part of the problem with the old coffee was that it did that
virt_to_page() crud. That doesn't work with the virtually mapped stack.
So bit_waitqueue() must not do the page lookup.
Only [un]lock_page() that already has a page can do the NID thing.
OK?
Linus
[-- Attachment #2: Type: text/html, Size: 1490 bytes --]
next prev parent reply other threads:[~2016-12-19 23:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 22:58 Dave Hansen
2016-12-19 23:07 ` Linus Torvalds [this message]
2016-12-19 23:12 ` Linus Torvalds
2016-12-20 0:20 ` Dave Hansen
2016-12-20 2:31 ` Nicholas Piggin
2016-12-20 12:58 ` Mel Gorman
2016-12-20 13:21 ` Nicholas Piggin
2016-12-20 17:31 ` Linus Torvalds
2016-12-20 18:02 ` Linus Torvalds
2016-12-21 8:09 ` Peter Zijlstra
2016-12-21 8:32 ` Peter Zijlstra
2016-12-21 18:02 ` Linus Torvalds
2016-12-21 18:33 ` Nicholas Piggin
2016-12-21 19:01 ` Nicholas Piggin
2016-12-21 19:50 ` Linus Torvalds
2016-12-22 2:07 ` Nicholas Piggin
2016-12-22 19:28 ` Hugh Dickins
2016-12-21 10:26 ` Nicholas Piggin
2016-12-20 2:26 ` Nicholas Piggin
2016-12-21 12:30 ` Nicholas Piggin
2016-12-21 18:12 ` Linus Torvalds
2016-12-21 18:40 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFwK6JdSy9v_BkNYWNdfK82sYA1h3qCSAJQ0T45cOxeXmQ@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=agruenba@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=peterz@infradead.org \
--cc=rpeterso@redhat.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox