From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Eric Biggers <ebiggers3@gmail.com>,
the arch/x86 maintainers <x86@kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Biggers <ebiggers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Denys Vlasenko <dvlasenk@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
"H . Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Thomas Gleixner <tglx@linutronix.de>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/mm: fix use-after-free of ldt_struct
Date: Thu, 24 Aug 2017 11:39:07 -0700 [thread overview]
Message-ID: <CA+55aFw6zfaM=LubJnsERYVtaSdvNtGfFNRxeHvC=hahrh6wVA@mail.gmail.com> (raw)
In-Reply-To: <43bcad51-b210-c1fa-c729-471fe008ba61@linux.intel.com>
Ingo,
I'm assuming I get this through the -tip tree, which is where the
original commit 39a0526fb3f7 ("x86/mm: Factor out LDT init from
context init") came from.
Linus
On Thu, Aug 24, 2017 at 10:59 AM, Dave Hansen
<dave.hansen@linux.intel.com> wrote:
> On 08/24/2017 10:50 AM, Eric Biggers wrote:
>> --- a/arch/x86/include/asm/mmu_context.h
>> +++ b/arch/x86/include/asm/mmu_context.h
>> @@ -148,9 +148,7 @@ static inline int init_new_context(struct task_struct *tsk,
>> mm->context.execute_only_pkey = -1;
>> }
>> #endif
>> - init_new_context_ldt(tsk, mm);
>> -
>> - return 0;
>> + return init_new_context_ldt(tsk, mm);
>> }
>
> Sheesh. That was silly. Thanks for finding and fixing this! Feel free
> to add my ack on it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-24 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 17:50 Eric Biggers
2017-08-24 17:59 ` Dave Hansen
2017-08-24 18:39 ` Linus Torvalds [this message]
2017-08-24 18:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFw6zfaM=LubJnsERYVtaSdvNtGfFNRxeHvC=hahrh6wVA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=dvyukov@google.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox