From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D54C433E0 for ; Wed, 23 Dec 2020 03:42:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 596E7223E0 for ; Wed, 23 Dec 2020 03:42:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 596E7223E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B3C436B009B; Tue, 22 Dec 2020 22:42:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AECCA8D0014; Tue, 22 Dec 2020 22:42:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A01EA6B00A0; Tue, 22 Dec 2020 22:42:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 8A23F6B009B for ; Tue, 22 Dec 2020 22:42:26 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5075A824999B for ; Wed, 23 Dec 2020 03:42:26 +0000 (UTC) X-FDA: 77623149492.18.pail95_251258827465 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 35C8C100ED3BE for ; Wed, 23 Dec 2020 03:42:26 +0000 (UTC) X-HE-Tag: pail95_251258827465 X-Filterd-Recvd-Size: 4335 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 03:42:25 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id h205so36938693lfd.5 for ; Tue, 22 Dec 2020 19:42:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0ybqpSjFFFFHlPBLk8nUiODbC32XCT34HJ3orNNILNM=; b=q802V44G+iqYoHXuiqs3/R4CRSg1mxfDB1ak3G8DwEfKd19hRyh8w35dG9qbFFy5Vr tZerxaYM3bzwVzcTOb28xScuWVLpzW/gb9n0+OfRtuWwB6bDL0Se1Nlby9615BzJKGlx uaWeX0GG3cXhLJmJ8HmawYI8us+b/km/IMDXcybJkOLtn7SMpvsaeINnZDxC3qgpYmhC puhQk8gmB+9xNzWLQSIy1vyVlYIz0thUW6KQmpFS1QtFdtfacixdHjaUOaN+ywvVYC+4 e4/m/aYfPAdcqw40d8HStwHHOMj/tmj+PCdkyOzJZSVgvUn6cPFSLZKXWt0qG9qyL+Q7 XkeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0ybqpSjFFFFHlPBLk8nUiODbC32XCT34HJ3orNNILNM=; b=Ck0c0kaWRDgGj/RuIORiNwUbtZ5m91Zqtxp0iTyNfYloNAtOa8JWVIlWgy2rOG39Qg nXq0i9XclJ1KpIkl5PNwh0RfaG2ci4VmXuuVdIq+EHYyz5gNtI+4v10NG8SQDQHd5DmL YftR3bTHRSomRVl4pf022APAe//EuVlvraz4fIjple9SfKBI+m9fNei1DE+1Xrd1+xGW bYe3JAyssx1a8CPVWP7Qs7c3mUjVUf8MnZkIdeSTkc+hMCG11KyRSuQ1y3GZNnIP5Lzs z319G0sQ9TsrOXE6trL+mcGeZqtaGRuR9as7IEYEyFZa8b3jFfRP1wKUag4KNiGcakpn obmg== X-Gm-Message-State: AOAM531fUFXVI48zh/WdbAMhYN6vt0NpDyvb1Q+lI3umuOQvt0SaEb2X K4cNgSXhO/+WwhWIMyoQe5hpKppxTpu+gnt3FAcdAuLK24k= X-Google-Smtp-Source: ABdhPJx265cqM52gdhbhsGHYsq7df5bDeK+RzTSogLsOrDLz4OYfazEqIXTLJEizjC1b4nEwlLSTBCMR3o0+/2touKA= X-Received: by 2002:ac2:5c08:: with SMTP id r8mr10135064lfp.12.1608694944427; Tue, 22 Dec 2020 19:42:24 -0800 (PST) MIME-Version: 1.0 References: <20201222074656.GA30035@open-light-1.localdomain> <52a6cb93-1fed-dfd7-d21e-f14197a9c9dc@oracle.com> In-Reply-To: <52a6cb93-1fed-dfd7-d21e-f14197a9c9dc@oracle.com> From: Liang Li Date: Wed, 23 Dec 2020 11:42:12 +0800 Message-ID: Subject: Re: [RFC PATCH 1/3] mm: support hugetlb free page reporting To: Mike Kravetz Cc: Alexander Duyck , Alexander Duyck , Mel Gorman , Andrew Morton , Andrea Arcangeli , Dan Williams , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang , Dave Hansen , Michal Hocko , Liang Li , linux-mm , LKML , virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On 12/22/20 11:59 AM, Alexander Duyck wrote: > > On Mon, Dec 21, 2020 at 11:47 PM Liang Li wrote: > >> + > >> + if (huge_page_order(h) > MAX_ORDER) > >> + budget = HUGEPAGE_REPORTING_CAPACITY; > >> + else > >> + budget = HUGEPAGE_REPORTING_CAPACITY * 32; > > > > Wouldn't huge_page_order always be more than MAX_ORDER? Seems like we > > don't even really need budget since this should probably be pulling > > out no more than one hugepage at a time. > > On standard x86_64 configs, 2MB huge pages are of order 9 < MAX_ORDER (11). > What is important for hugetlb is the largest order that can be allocated > from buddy. Anything bigger is considered a gigantic page and has to be > allocated differently. > > If the code above is trying to distinguish between huge and gigantic pages, > it is off by 1. The largest order that can be allocated from the buddy is > (MAX_ORDER - 1). So, the check should be '>='. > > -- > Mike Kravetz Yes, you're right! thanks Liang