From: Liang Li <liliang324@gmail.com>
To: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [RFC PATCH 3/4] mm: add sys fs configuration for page reporting
Date: Thu, 16 Apr 2020 09:30:04 +0800 [thread overview]
Message-ID: <CA+2MQi9KHbw5fJZ4pZJYbcKU545rhM3bPddCJjupmJZCGqHqaw@mail.gmail.com> (raw)
In-Reply-To: <64985d09-d11e-5fc0-64b0-b56ef514448a@linux.intel.com>
On Mon, Apr 13, 2020 at 11:02 PM Alexander Duyck
<alexander.h.duyck@linux.intel.com> wrote:
>
> On 4/12/2020 2:09 AM, liliangleo wrote:
> > This patch add 'delay_millisecs', 'mini_order', 'batch_size',
> > in '/sys/kernel/mm/page_report/'. Usage:
> >
> > "delay_millisecs":
> > Time delay interval between page free and work start to run.
> >
> > "mini_order":
> > Only pages with order equal or greater than mini_order will be
> > reported.
> >
> > "batch_size"
> > Wake up the worker only when free pages total size are greater
> > than 'batch_size'.
> >
> > Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> > Cc: Mel Gorman <mgorman@techsingularity.net>
> > Cc: Andrea Arcangeli <aarcange@redhat.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dave Hansen <dave.hansen@intel.com>
> > Cc: David Hildenbrand <david@redhat.com>
> > Cc: Michal Hocko <mhocko@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Alex Williamson <alex.williamson@redhat.com>
> > Signed-off-by: liliangleo <liliangleo@didiglobal.com>
>
> I am not really a fan of making these configurable globally. Especially
> since the existing virtio-balloon is relying on some of this being
> configured the way it is.
>
> It would make much more sense to push these configuration options out to
> the registration interface so that the thing that is registering for
> page reporting can configure them when it is registered.
>
Agree, that's better. Thanks!
prev parent reply other threads:[~2020-04-16 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 9:09 liliangleo
2020-04-13 15:02 ` Alexander Duyck
2020-04-16 1:30 ` Liang Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+2MQi9KHbw5fJZ4pZJYbcKU545rhM3bPddCJjupmJZCGqHqaw@mail.gmail.com \
--to=liliang324@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox