From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FE1C433DB for ; Tue, 22 Dec 2020 12:13:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E47E229C6 for ; Tue, 22 Dec 2020 12:13:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E47E229C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4BE516B0093; Tue, 22 Dec 2020 07:13:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 495886B0095; Tue, 22 Dec 2020 07:13:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D1E76B0098; Tue, 22 Dec 2020 07:13:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 28C0C6B0093 for ; Tue, 22 Dec 2020 07:13:28 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E9969824999B for ; Tue, 22 Dec 2020 12:13:27 +0000 (UTC) X-FDA: 77620808454.02.girls30_5c040d92745f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id CA5AA10097AA0 for ; Tue, 22 Dec 2020 12:13:27 +0000 (UTC) X-HE-Tag: girls30_5c040d92745f X-Filterd-Recvd-Size: 3999 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Dec 2020 12:13:27 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id o13so31469830lfr.3 for ; Tue, 22 Dec 2020 04:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XDqWemTZAr3Yf5zc0WPnza6SJa69M9w7Rj4fQPF3P5o=; b=tPpOPFZiOO+7bXVYjFI5JFD6T6i0npRgJb2VT4lieoQIF08DoFCYSGjj9UtUf7OlOT k59s2Xvq/lfysj+/GyyxJvQlfo02nL1EuA2PBhI+xh9pDS5Yg5bPQ4Zt7jO0QiFdxGdp dKcuZ4zXWF5bWyAxUTzFny3vMoMajws16JY40rUn6sUIVqICCZSBYnX5i8M7E+Z0u3CT lTPukRJlbMMNBCD78ibfqd94YssAxc4XtIpdyd2C7HlUWeqJ17NRIF47bAm5ugtNHU68 U4khUQcaFfH58dRFjW4SmhGv0p2aKTkWcwPPS4ZUSjxZrs0qCCkJW8Il2Xt6AJjLwQiX KhqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XDqWemTZAr3Yf5zc0WPnza6SJa69M9w7Rj4fQPF3P5o=; b=P4m0Byn3w1UuyYubmUDiY1v2z06IST1prWmSdsZG3u27KirDRWac+qPmNwGx7q66CZ TMAKF9dxR5l9B1enw0lwvzhORbZd6OFizeqCbMyxhdpuODIC50/fCygpFFCuWqE9AMGL BFP+FyGiOwipBOV7dgaaq+/SPeEUuFBce9aWMpNGDkOR7DCgewM0PnqXDq3Lt968fbxY wVmYvz+QKnU43dpRkaNmgSb/doPhYold7uxzULbk0hBp4fhZLmInlxMxzqbHkM+IcWix OfHCxT340DbzWq8WM9cWPCur62rqVIbSZTcezFhnkGauhjRn/XbK8JCsVO+UKo3P5LBD N9iQ== X-Gm-Message-State: AOAM530mxs+LVLwHopRyUnV0oIPmoc9/dz8mil/lAWsxVVGd1GItLe5n gM723pMakIWCN/3WADjUZ/T3QNvl7doK4EkEa6YwWwLcqkk= X-Google-Smtp-Source: ABdhPJy//mXDzhSL1YWk1GnMAjPpsove6BusTlVwzWEpUuwAUeHj+jE+6K6s+3pbthcvs1KaZqTkjZMhul0rQkreE6s= X-Received: by 2002:a2e:b8d1:: with SMTP id s17mr10053775ljp.472.1608639206075; Tue, 22 Dec 2020 04:13:26 -0800 (PST) MIME-Version: 1.0 References: <20201222074910.GA30051@open-light-1.localdomain> <585791f4-4b41-5e73-296e-691d5478a915@redhat.com> In-Reply-To: From: Liang Li Date: Tue, 22 Dec 2020 20:13:12 +0800 Message-ID: Subject: Re: [RFC PATCH 3/3] mm: support free hugepage pre zero out To: David Hildenbrand Cc: Alexander Duyck , Mel Gorman , Andrew Morton , Andrea Arcangeli , Dan Williams , "Michael S. Tsirkin" , Jason Wang , Dave Hansen , Michal Hocko , Liang Li , Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Free page reporting in virtio-balloon doesn't give you any guarantees > > regarding zeroing of pages. Take a look at the QEMU implementation - > > e.g., with vfio all reports are simply ignored. > > > > Also, I am not sure if mangling such details ("zeroing of pages") into > > the page reporting infrastructure is a good idea. > > > > Oh, now I get what you are doing here, you rely on zero_free_pages of > your other patch series and are not relying on virtio-balloon free page > reporting to do the zeroing. > > You really should have mentioned that this patch series relies on the > other one and in which way. I am sorry for that. After I sent out the patch, I realized I should mention that, so I sent out an updated version which added the information you mentioned :) Thanks ! Liang