From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA42C369AB for ; Fri, 18 Apr 2025 12:32:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7219F6B02B5; Fri, 18 Apr 2025 08:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE2B6B02B6; Fri, 18 Apr 2025 08:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52B0B6B02B7; Fri, 18 Apr 2025 08:32:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2D0ED6B02B5 for ; Fri, 18 Apr 2025 08:32:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0D6DBADD9E for ; Fri, 18 Apr 2025 12:32:37 +0000 (UTC) X-FDA: 83347103154.26.A78D4F3 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf16.hostedemail.com (Postfix) with ESMTP id EAEDA180013 for ; Fri, 18 Apr 2025 12:32:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E9B0am0R; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of joshiiitr@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=joshiiitr@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744979555; a=rsa-sha256; cv=none; b=s4hGTg5B/74lm3FHkOsHkII3rbEivIZ/N+QlJzJ5tX2c7+oNsJVayNJuIXBvvaWsUmLaQ/ APyIAZWlW/KMpOtBcMVy/Qt8Rm6ce3lCr5CIh7BkpqcOMZnHqmwcJZ7ts4tlPNb762gap2 HMFl2BXVvhZTXNHo10DRKGoMvJh6GQE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E9B0am0R; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of joshiiitr@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=joshiiitr@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744979555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4uxNqOBD/ogCW1O0rrQ2A0HcfFujRPCySOpF/YO01oA=; b=lSVFSh7HwQjnYxF7k9Vtym/JeENxwuBm+0MyKBexEXu+SATmV/wTLom26rbD5L0A4K+wXW J/Z2wfiGHIVhJ0kVms/blflYgh8gtpWHUEY1EB86ZfvNsn+vo+SwYQz/mOsRl4NcF516fM a3tSZSMFjrG/3WRKpytIK3Ydan9TuHc= Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-b0db0b6a677so919970a12.2 for ; Fri, 18 Apr 2025 05:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744979554; x=1745584354; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4uxNqOBD/ogCW1O0rrQ2A0HcfFujRPCySOpF/YO01oA=; b=E9B0am0R6XOMLwJiAti1VeItfJyZiRisNrfi62uDhclkD289op9eGmBHh4IRMhEVbu FVK7C9RC3VylIv1RTyC7/vm6ponpyOkGuZcod+CuYn/hDoIqVBphffckKuPCG30zk4dd hQRX2CKaqaBHwCCm1r8kiv7n/lL+pIDY9eIaNOucys7OOGM++oKDgJL3WiNpU70hyxe5 sCnV+tKEdW1zRvnms4oAqBBv3rHd9Pg2fPt8cYRH04XMCnTS2+AZH59IFb4Lhf9dCEaL kJbznHJg0Hu7HoNKn0tfHVOVGACdLii4auN3tUBopzNR8eBWqHicoVZ2N8GthyGoFeP7 khNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744979554; x=1745584354; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4uxNqOBD/ogCW1O0rrQ2A0HcfFujRPCySOpF/YO01oA=; b=jXp8n0UOBRghiGsRyahyQ0NVSkOzCFA/Z8LSCTHe5cwtoox9vy+QfSO7+dUgHeNXFW ufEuHqIDHF9yFHV/zdDSqwCfgCXHQ4z1k/gq8ZMRtxUY43Su2MEiTK/LP6G0lNE4i2Gf KWhs5Tnscv5jevjHvaYzCYvhDzEHgC+gDNiCu5b3VXkxSjkGbnChtMw/E1cX3YGCZFzg Mb2PGd091p8qqYYwy0gALkEO2+plGa4oJrhZc0K18ZMWrH8qYESkIMcGZ8ZShjEV2LKv wqJfc8hL+robYWQ7v7OhNWRlDt0zN0IZMPHLwzTG+1Yr1YhhBjlQiDTwdJLCia3S9puC GX/g== X-Forwarded-Encrypted: i=1; AJvYcCUuwhwJgn040NtNKHKFtKrlQHxxiYcAfzjFqioKhsv9+O+DQBCLtGR3b18HEF7kQDbFwhe7vh76aQ==@kvack.org X-Gm-Message-State: AOJu0Yz2JWe2qhm50/EG2JyqYi2/apmW5e2LjKXYBV6xssGgqg9xwkRu HajaR3IbdcbxippXsPBr41trEsDi8grB6JBAzjskm1JCiG1w7KDvY3Cn6swvAzuKeKpZ0Jx9uV0 gsoOxVmHoJY6gprVnB1U/o+bK14I= X-Gm-Gg: ASbGncsNjLYyzHv9X5bbX/40yjBOho3EF3eLU9iK4ZflOunnVx3MIBLxBq/p6xQZjBv 3TRtyzYIdP/AhAJL7cn+A8qL1qmQXNTleVTnjvs1ppUTttLm5Rk2PJwLsYf183u5h/TwoGLsCR0 dmiPsGoCO2jxYkahFuKpClsLmENwS3y4h22jCmt8Ee6/nGGf+lCkjMl3kJ X-Google-Smtp-Source: AGHT+IE6KPLtDnTScFEtJJlvCdwmMFGgLV6Sh+PZ7MHmYiMb3jtvP1cSpc1ynbu9LO+7GJYkCunnvOZCbjH4BPDTV0s= X-Received: by 2002:a17:90b:2e03:b0:2fc:c262:ef4b with SMTP id 98e67ed59e1d1-3087bb6f117mr4849982a91.18.1744979553652; Fri, 18 Apr 2025 05:32:33 -0700 (PDT) MIME-Version: 1.0 References: <670389227a033bd5b7c5aa55191aac9943244028.1744825142.git.leon@kernel.org> <1284adf3-7e93-4530-9921-408c5eaeb337@kernel.org> In-Reply-To: <1284adf3-7e93-4530-9921-408c5eaeb337@kernel.org> From: Kanchan Joshi Date: Fri, 18 Apr 2025 18:02:08 +0530 X-Gm-Features: ATxdqUGyYBEsfK-IN2nZn9q0XDVh1xSRZINsNgbIk6fSYXOiPXAs6WAhmbL1EUw Message-ID: Subject: Re: [PATCH v8 24/24] nvme-pci: optimize single-segment handling To: Damien Le Moal Cc: Leon Romanovsky , Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Kanchan Joshi , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Chaitanya Kulkarni , Nitesh Shetty , Leon Romanovsky , vishak.g@samsung.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EAEDA180013 X-Stat-Signature: rkdcrgbyfxkzg5mn17t97td81fg1n696 X-Rspam-User: X-HE-Tag: 1744979554-293240 X-HE-Meta: U2FsdGVkX1/kGtmt5JPGZrX+jbP+rj3gBSsaZKFtgjau1NwTda8ACJOZsBmkPA40XgrL9WJFL4LsIKg5Mr938j6RKPMQrRVPrOkyTWQ3/AuoyTzmDeykGJi9TEeoazMKLtQ6sobB9oD/64MfJ0KFHYPw1Dry+0ctIcYR6HfEfbxLVyZRQ2rs5L/cg/VXGufB+7aEJHbjVYjcEfuQb1eEijXrEo4z9ns69h+7DG5uUWqVg/L3kpU+/RBVMw/Tf8Awd8ecnEoRxkvfZ31w5FXgcb22MZTP5imd2UT/HIt9WTaGqSDONOp/bOIPcphIzwEjVxzz1yDWUCfXIU5FMKAUaFt6WByDDzCN9DTCeYGTJdUZgevh/yhfExA4c8F662Hrt6N5GuH3HLlbISUg9DKrqhAi8fWqy4LnE8pEBkfpO0YSM3u6T85Krk9iRQcK5Ze1K7hnJQbRRgW/UwGt9d/YjPbx6XoXkCKmZ6ujKYwuBtx1KVsCrBYoUh8Jv9Gf/isXkAhbNxlk3Wa350YI/clLvfp2IS/VKUMkXGoIbdaG7uNgM77VWveOuFz6jbs1Plv2Ih1K6EpKY95B0mYkIaTUlm8YwUznOETmxBQ/yII8Fafv7ZhyKCJ29txY7fTkHbDdYwrPc7Qe4T4Ab1zK/6qu+so9MtIs9qQU1vGBaDr0J14cQVOzSiUQYbOLJSaELqiehVoDEW7PiKeZHI/B8GSF62EFWlLvmXu4WxgK555pLA+//WKRP5Bmi/fhMDT8XeMddQrYfrn8E8s2M7y+7gV28rBORRFhFtpwoUX6J1b5sWZTUktEYnVAo1snjhLU9yegHGAfF1V767aV7cDgcwkukPBgc8oEtHOoM+1lRinHfoOJ3YO+i4nFJkbsgpPz3v4LJSQDHlu4AIYlTjjZdjeNKkKEO81n34IVjyzaxlEBfjSympat57XvVoNITqkbSLv8idvv4h3Cl93o/UDf9LJ UygyXyyd J/G0XXYQpqQR/VfdTR1IlFo+jybs3+SSco+WZ3rl/S0kVe1+DxBmlzQS7ogK8V7Dz2DxDRiQIZ2F0ySLQgugpKqTbm0ErfGQG5Iz03vonUavZ25Dk3zX3SQ16cRIBjr1PrXI2StNwBwi9vImncicNOq+9UKnpW++0u+B3c0et70ARvgtqU3kxG+wC5jrpRgfLhdYZUhzmq5nWzwqJyuNs2B8X04/c6RUCkvED3pApbzLWahmvNdUDkfxj8AsWHfoGvpRU9t9de7E64H7WRHUVOdFQyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > + if (nr_segments == 1 && (iod->flags & IOD_SINGLE_SEGMENT)) { > > nvme_pci_setup_prps() calls nvme_try_setup_prp_simple() which sets > IOD_SINGLE_SEGMENT if and only if the req has a single phys segment. So why do > you need to count the segments again here ? Looking at the flag only should be > enough, no ? Yes, the flag will be enough. I started with nr_segments first, but felt the need of a flag when I reached to handle the unmap part. This can be changed if the series requires an iteration. Or I can do this as part of the cleanup which I anyway need to do to replace the "iod->aborted" field with a flag. -- Kanchan