From: Song Liu <songliubraving@fb.com>
To: William Kucharski <william.kucharski@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Bob Kasten <robert.a.kasten@intel.com>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
Chad Mynhier <chad.mynhier@oracle.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <jweiner@fb.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v3 0/2] mm,thp: Add filemap_huge_fault() for THP
Date: Wed, 31 Jul 2019 08:35:46 +0000 [thread overview]
Message-ID: <C9405E2A-4A0B-4EFD-B432-C54D2C9CFC2B@fb.com> (raw)
In-Reply-To: <20190731082513.16957-1-william.kucharski@oracle.com>
> On Jul 31, 2019, at 1:25 AM, William Kucharski <william.kucharski@oracle.com> wrote:
>
> This set of patches is the first step towards a mechanism for automatically
> mapping read-only text areas of appropriate size and alignment to THPs
> whenever possible.
>
> For now, the central routine, filemap_huge_fault(), amd various support
> routines are only included if the experimental kernel configuration option
>
> RO_EXEC_FILEMAP_HUGE_FAULT_THP
>
> is enabled.
>
> This is because filemap_huge_fault() is dependent upon the
> address_space_operations vector readpage() pointing to a routine that will
> read and fill an entire large page at a time without poulluting the page
> cache with PAGESIZE entries for the large page being mapped or performing
> readahead that would pollute the page cache entries for succeeding large
> pages. Unfortunately, there is no good way to determine how many bytes
> were read by readpage(). At present, if filemap_huge_fault() were to call
> a conventional readpage() routine, it would only fill the first PAGESIZE
> bytes of the large page, which is definitely NOT the desired behavior.
>
> However, by making the code available now it is hoped that filesystem
> maintainers who have pledged to provide such a mechanism will do so more
> rapidly.
Could you please explain how to test/try this? Would it automatically map
all executables to THPs?
Thanks,
Song
next prev parent reply other threads:[~2019-07-31 8:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 8:25 William Kucharski
2019-07-31 8:25 ` [PATCH v3 1/2] mm: Allow the page cache to allocate large pages William Kucharski
2019-07-31 8:25 ` [PATCH v3 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP William Kucharski
2019-08-01 12:36 ` Kirill A. Shutemov
2019-08-03 22:27 ` William Kucharski
2019-08-05 13:28 ` Kirill A. Shutemov
2019-08-05 15:56 ` William Kucharski
2019-08-06 11:12 ` Kirill A. Shutemov
2019-08-07 16:12 ` William Kucharski
2019-07-31 8:35 ` Song Liu [this message]
2019-07-31 8:58 ` [PATCH v3 0/2] mm,thp: Add filemap_huge_fault() for THP William Kucharski
2019-07-31 10:20 ` Dave Chinner
2019-07-31 11:32 ` Matthew Wilcox
2019-07-31 22:19 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9405E2A-4A0B-4EFD-B432-C54D2C9CFC2B@fb.com \
--to=songliubraving@fb.com \
--cc=chad.mynhier@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=jweiner@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=robert.a.kasten@intel.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox