From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B61AEE14D0 for ; Wed, 6 Sep 2023 20:22:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64E168D001C; Wed, 6 Sep 2023 16:22:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FCF78D0005; Wed, 6 Sep 2023 16:22:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49E1B8D001C; Wed, 6 Sep 2023 16:22:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 375268D0005 for ; Wed, 6 Sep 2023 16:22:30 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFFCC120E9E for ; Wed, 6 Sep 2023 20:22:29 +0000 (UTC) X-FDA: 81207295218.17.DCAB881 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf05.hostedemail.com (Postfix) with ESMTP id 08874100018 for ; Wed, 6 Sep 2023 20:22:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=UTlwtNKw; spf=pass (imf05.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694031748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OD7kjBc/iBCRToogLtJPKs8deknmulxtzUCmXzFwU6E=; b=6mgaeTCDvSwjO4HyaEcWfEzmTWs8RnSkEtsxOFDh9U4XOSUekNwlNLfIjVBdO9jRdVBLJP vrkYMyq9MJ7TJoVggZd82mxPjVbH0ooAXOYm90Fm3tnn+dUzpGUftIctYmAX5VrJyTWl6x sspC3D0RBnkTxy64EcLABRoQBnYa2OA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694031748; a=rsa-sha256; cv=none; b=u6vsISSubcFW+OXRvWr3FKSHfQKDhFB39wNJIc2nOk84sY5Wwq1NHHXH805ipGKm+HHsay AscJcBJZUcUEE3rLLOJFPeUqtmp5iKMDQVl8zSoziZrHk+il0n9bF2bkoA6My1k12QniLK J3xTbWwtzSYHxuL+9ECZNjaTQ9idJas= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=UTlwtNKw; spf=pass (imf05.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so213158a12.1 for ; Wed, 06 Sep 2023 13:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694031747; x=1694636547; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OD7kjBc/iBCRToogLtJPKs8deknmulxtzUCmXzFwU6E=; b=UTlwtNKw+X3fLxNPvheTnMU5ehH/YwvhOSGs0BVI6AoTel62sZPQaGF6clCSnxUAt+ 9jOzLb/XzqwnOhFef+uNDc78AgUdac9z1VzLe9rdTFn/j3g8um6INocimVx1gf1AgMi/ zY4ZtdiR5fBvQ6pqaHW/BT1TZXcvjIRDtoizKn8FCCYpA82vhrDaI/2+3mjfDPsBpriJ slbEShoJ9HSOm2wz0NPLQme/cE2PGg9/NuRZfN5uJzHN9zNECJs8zT55WLGdfc0uKjeR 5fqPyzoo0duVbuYNMp1ejzw57pgEhexU759tW8/Uf65oZLmtyImNGEGcP25h/q2p2eXz 1APQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694031747; x=1694636547; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OD7kjBc/iBCRToogLtJPKs8deknmulxtzUCmXzFwU6E=; b=AiGFoWEUVvrrmtLNSUd0FA6WvUyVz1nizd07b8k8Y6iPtcpbWUnv9p5enJy2qiyNc7 hKKZ+nMPywBPTkY2jZdEZTP3p3recDBB5fwK9XhKIX67odW+RV0m/i/1nMvvnXnFHkEd TyBVx36RpBVFEjdZ8ss8nEu4CWh1r20wIjT5Aj0gLmOsE4vKPTT76lYKgcYBeO1YvOY/ Qogof98+cmFb7czwvBulY6J5oNw6NN0BpswA4qLfHVoEip/pZvCA4z7eiz9gtEZITjDy ggdhC7/N/NlFnbXLDJihZqHae1VOVNjKnK7/S7Ushg3hQuByy5r1edmLvLQtlMyWhiKy 5EoA== X-Gm-Message-State: AOJu0Yw8eEkxQQ5YWj+hTBXBnNSehUjWk+dvzmyb7UXrXnfpGjb/sI4V GnEUi78YzonuAs1bTIcANEk= X-Google-Smtp-Source: AGHT+IGmvOVV/7HqCSH46swl/UmrMsBdSsMfSDMwiGwNRsu0ygeNZKfizRBSj3U2w7qfL3CnxZ0o2w== X-Received: by 2002:a17:90b:212:b0:271:ae19:c608 with SMTP id fy18-20020a17090b021200b00271ae19c608mr15956217pjb.41.1694031746571; Wed, 06 Sep 2023 13:22:26 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id v23-20020a17090ae99700b00256a4d59bfasm169219pjy.23.2023.09.06.13.22.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Sep 2023 13:22:26 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: [PATCH v3 4/4] riscv: Improve flush_tlb_kernel_range() From: Nadav Amit In-Reply-To: Date: Wed, 6 Sep 2023 13:22:13 -0700 Cc: Alexandre Ghiti , Geert Uytterhoeven , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm , linux-riscv@lists.infradead.org, Linux Kernel Mailing List , Andrew Jones Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230801085402.1168351-1-alexghiti@rivosinc.com> <20230801085402.1168351-5-alexghiti@rivosinc.com> To: "Lad, Prabhakar" X-Mailer: Apple Mail (2.3731.700.6) X-Rspamd-Queue-Id: 08874100018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1rwwmy17bw34bbttxjejbkn5poa6aye5 X-HE-Tag: 1694031747-528469 X-HE-Meta: U2FsdGVkX1/2JALdTx2zbWGPYKp2MxlUcOPsCzeLi0520zOh9XG3ikKpPeBieePhIZ7kBybu/XPcdmWWRebCTTf7JMV8HeFRJCMODn3zSLJ8SNGmoA5L/dfJbTfJ4I+2SjyPU3SZ5B0cb/hJbXtAjtBECEtbgC+3p8Ds0NCvSYLCKBtN6hOqZweHCncgZwCp3LmJb2CPZ2EMJuo9Bb8dFhjz/0AIwlufiS+jnQofP4wOaYU4S0PCAxC4+el95ShWbtieE/qKADxUpE5ayM9fPze+xgt8yW5b6/gmMhrgIs8rMso89ERl2Dujvy5gUqw2+fKKrhiHHD9f237amsWhW3fHzNw8P4q0LVnSWCBxXffLolFT6OGxGKthd6wusHKQ1s1eGOMUKCwZYqDlMyJv/kI4yeqMJXm26YyRfliqERoSKXQMVSQrvuBEtm/lGxaB/rxfcMigbyaii9uPpHjDnKTmbZy0oL/QPr6nxLaxJWlly0pqG0MlctWvmRWlL/vSmJQg8u2fY1Xy+XeF9LQEgGiU944LKs7uAOaSiZ5Tgevuq+QRliUa8u7byhcKg5vrcmUuvsbv/rQkDJNJgwKfMzZlreljv+S5SJGDf1WFicDj8bJh1B0TV5mWdDcvFoW7P8/qs1583cwmaI2ygzsau50/smsrOs3xWExbsJMguebv+x4W4SyuG1YKygb614vx733hjFpO5OTDnQ4rdD5AGqAkt4OZZgv4v7ZKQlBgNAWrsR/lT/fLwhGqh8sB4BXjxs/gw3Ou355yXkO9GfAMPVzSH8Ci3mFvoglo49j/fUy0haKJSlnTtsxyXjbDnjbR1MYF1UdoKzdiIlNWOrAgt+02C1vkTAlDnjlsTPfEeMEhKHnbPkHxHOtLM2NnGIsUEX1NRvufijeqQdR6/3xlsBYnaVyJdfgWRxou5nDTmV9uQTXtZLKf69PWRvAaaHsrr8EwxL79Udl9OkV3Dxw 5/27ta7l jeBF8BSA2tHX/0gYEsgMnq/uN/dU088gLAdZUPSnxP/lRojic0ifkch9ChXeRfXPvgS4JeULAOTEOw4DeOkFRtxI+5a/taMl1nFt78Fu5+R7L4VWtXG1pvInEX+Ox0zlEx2o6M157ztfkQSdr5rvI3IeExMLGe4nz/jzSuvdp8p5cyJD979dLCSJ0mvAt838Qe2EMaCvm3Xsm6sY3+E/7wee5d2CNWxl5VAgY0NsJhWxoyJm/LVGeX8+R0CMj4HeQWrxxTM1+7zJtHzIhNDCN2tJDO+ECfq/fMvcMJ0Q+GbirB+hCq6bBtC79sRb2CHQxBk9U/RVFoyzuF02JDUaMSHwEK94U4sNSk/KdY8p4Kw+Z8SklYQLod0LHHOkDt9yBAIUoaschoVlRoCTVklY6U0UMP73s8Azlo415WLH7AEKf/NvkUHgVO4sMELGo5y95eRmqA/LoZ+SurnWwRaB4E8JxjR3/EYF0LblEQWkwaFriTf2b1doZQytcCbWxlI+fnAQGBjsT8IbXjxiMB/PKuTbF+LyOtH19vfS85TDrIdpFl51vm4Sba40Ak0a+ACpA2Q5o1CBEmVc3hWDvyOt/4BSpteafmmzTihEkNoe3bNIkKBIwrSyyyV1GgL0vN+bzBkKvoEZV9RUTM9Kj9cSPOtoghPzua+073GXatYTVfpyAqRc66XuyPKMEzWFNhJXvfsoQ77NH6XM0h0NcNtBznePwEw7iclVcgfwXxuO8UEmrxCrTQFxIwys+VTviUnQA5yla X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Sep 6, 2023, at 4:48 AM, Lad, Prabhakar = wrote: >=20 > Hi Alexandre, >=20 > On Tue, Aug 1, 2023 at 9:58=E2=80=AFAM Alexandre Ghiti = wrote: >>=20 >> This function used to simply flush the whole tlb of all harts, be = more >> subtile and try to only flush the range. >>=20 >> The problem is that we can only use PAGE_SIZE as stride since we = don't know >> the size of the underlying mapping and then this function will be = improved >> only if the size of the region to flush is < threshold * PAGE_SIZE. >>=20 >> Signed-off-by: Alexandre Ghiti >> Reviewed-by: Andrew Jones >> --- >> arch/riscv/include/asm/tlbflush.h | 11 +++++----- >> arch/riscv/mm/tlbflush.c | 34 = +++++++++++++++++++++++-------- >> 2 files changed, 31 insertions(+), 14 deletions(-) >>=20 > After applying this patch, I am seeing module load issues on RZ/Five > (complete log [0]). I am testing defconfig + [1] (rz/five related > configs). >=20 > Any pointers on what could be an issue here? None of my business, but looking at your code, it seems that you do not = memory barrier before reading mm_cpumask() in __flush_tlb_range(). I believe = you would want to synchronize __flush_tlb_range with switch_mm() similarly = to the way it is done in x86.