From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9D9C433F5 for ; Sun, 13 Feb 2022 21:09:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D6E56B0072; Sun, 13 Feb 2022 16:09:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2850B6B0073; Sun, 13 Feb 2022 16:09:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 039B66B007B; Sun, 13 Feb 2022 16:09:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id E54346B0072 for ; Sun, 13 Feb 2022 16:09:37 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9E6399A7F9 for ; Sun, 13 Feb 2022 21:09:37 +0000 (UTC) X-FDA: 79138997994.19.15AC8A3 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf22.hostedemail.com (Postfix) with ESMTP id E28FFC0009; Sun, 13 Feb 2022 21:09:36 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id c4so4523884pfl.7; Sun, 13 Feb 2022 13:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=rjIqEqA67/Bhen+9LL3/ebqOxSKocsMm/Zaa9+D0Oto=; b=JaM4Ihuob7dxDqOezGlvQfAB9r0Fk0N/sTYO3oEA6FncN9MFApHlfqotpkB4NeiejC vB9kojK55qOn2QS/CIzMRcWucSjYzqcAZl8AXj8RuUPLX5XHxFphvw5djFMd0SY6OogL OI69cLwnMquENaaXOuk/ybsUXA7q1qsuXHFbG+tOUFh2L/VIllGo9cyXrMfHe30Ua6d0 Avf+0fuz7ml7PKRougJzEx4Qh1/fR4O0sPd2925eW0Y66rtFCy+h6VC/PsO1ha0JYEAt 2S2sul3mMnEIDvkUXzcA50P9W47YMTIVlWGIYed/F2yY0Wu/IuwWGUEqii78OhHyOnbA BwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=rjIqEqA67/Bhen+9LL3/ebqOxSKocsMm/Zaa9+D0Oto=; b=2BgCXic9JyeKDRKMQybPSNYiW1kzmAlD0L86TRkexuzdY30G3uUILTv2qVg8eebInS 08AY3gUOCUsdtnp1ZW5vW2pQaG5YQl8sEGJtfMzbTeLd9Vf1KhFbD2tvdbjhk1YyJVQC kn1WzVsF55h+jf1+188/VsGVfEVQ9TkzhNQeqUKf7v2rsX1AIZYfwE1dZss50w/i6yY2 h9imjsfC7nDAhVzeYmMdZJGiMQByvykiR+LA2wfO3+wGQLB5uJOA3HKisM+PfI9W7HzG IOeObmjgpiMYoFVeSAwwz0d3GcjDpjrmjJhw2EIl8ToiiUUa9XrIU0c+eJLMgJ5K/T6R ipqw== X-Gm-Message-State: AOAM533OE3ACyWfbXKGk+p1XQqyYPVs2DrU8laCWd+ipbqZ6NS9uTftJ Jrd9CW12ylaxX81bs3PUYqw= X-Google-Smtp-Source: ABdhPJy4xr1KKvF4naRPuxlPj33esOPX6S5/8oUUQ9wjKc6fgbBab8Jt4orGS2/H0PN59zyaybRMiA== X-Received: by 2002:a05:6a00:1a4f:: with SMTP id h15mr11493109pfv.50.1644786575557; Sun, 13 Feb 2022 13:09:35 -0800 (PST) Received: from smtpclient.apple (99-105-211-126.lightspeed.sntcca.sbcglobal.net. [99.105.211.126]) by smtp.gmail.com with ESMTPSA id s15sm33600030pfg.145.2022.02.13.13.09.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Feb 2022 13:09:35 -0800 (PST) From: Tong Zhang Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_84FE8124-5787-4AC4-BE8E-E163022F66D3" Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" Date: Sun, 13 Feb 2022 13:09:31 -0800 In-Reply-To: Cc: Domenico Andreoli , Luis Chamberlain , "Eric W. Biederman" , David Airlie , Andrew Morton , amir73il@gmail.com, Andy Shevchenko , Arnd Bergmann , bcrl@kvack.org, benh@kernel.crashing.org, clemens@ladisch.de, crope@iki.fi, dgilbert@interlog.com, Greg KH , jack@suse.cz, jani.nikula@intel.com, jani.nikula@linux.intel.com, "James E.J. Bottomley" , jlbec@evilplan.org, john.ogness@linutronix.de, joonas.lahtinen@linux.intel.com, Joseph Qi , julia.lawall@inria.fr, Kees Cook , kernel@tuxforce.de, Linux Memory Management List , mark@fasheh.com, "Martin K. Petersen" , mm-commits@vger.kernel.org, nixiaoming@huawei.com, penguin-kernel@i-love.sakura.ne.jp, peterz@infradead.org, phil@philpotter.co.uk, pjt@google.com, pmladek@suse.com, rafael@kernel.org, rodrigo.vivi@intel.com, rostedt@goodmis.org, senozhatsky@chromium.org, sre@kernel.org, steve@sk2.org, surenb@google.com, torvalds@linux-foundation.org, tytso@mit.edu, Al Viro , wangqing@vivo.com, Iurii Zaikin , open list , regressions@lists.linux.dev To: Ido Schimmel References: <20220121221021.60533b009c357d660791476e@linux-foundation.org> <20220122061228.nmuo75sDn%akpm@linux-foundation.org> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E28FFC0009 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JaM4Ihuo; spf=pass (imf22.hostedemail.com: domain of ztong0001@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=ztong0001@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: stqp18ccfcbeqjwrc1or8wrn1fe93ukn X-HE-Tag: 1644786576-58146 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Apple-Mail=_84FE8124-5787-4AC4-BE8E-E163022F66D3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Feb 13, 2022, at 7:34 AM, Ido Schimmel wrote: >=20 > On Wed, Feb 09, 2022 at 08:49:20AM +0100, Domenico Andreoli wrote: >> fs/binfmt_misc.c | 6 +----- >> fs/file_table.c | 2 ++ >> 2 files changed, 3 insertions(+), 5 deletions(-) >>=20 >> Index: b/fs/binfmt_misc.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- a/fs/binfmt_misc.c >> +++ b/fs/binfmt_misc.c >> @@ -817,20 +817,16 @@ static struct file_system_type bm_fs_typ >> }; >> MODULE_ALIAS_FS("binfmt_misc"); >>=20 >> -static struct ctl_table_header *binfmt_misc_header; >> - >> static int __init init_misc_binfmt(void) >> { >> int err =3D register_filesystem(&bm_fs_type); >> if (!err) >> insert_binfmt(&misc_format); >> - binfmt_misc_header =3D = register_sysctl_mount_point("fs/binfmt_misc"); >> - return 0; >> + return err; >> } >>=20 >> static void __exit exit_misc_binfmt(void) >> { >> - unregister_sysctl_table(binfmt_misc_header); >> unregister_binfmt(&misc_format); >> unregister_filesystem(&bm_fs_type); >> } >> Index: b/fs/file_table.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- a/fs/file_table.c >> +++ b/fs/file_table.c >> @@ -119,6 +119,8 @@ static struct ctl_table fs_stat_sysctls[ >> static int __init init_fs_stat_sysctls(void) >> { >> register_sysctl_init("fs", fs_stat_sysctls); >> + if (IS_ENABLED(CONFIG_BINFMT_MISC)) >> + register_sysctl_mount_point("fs/binfmt_misc"); >=20 > Hi, >=20 > kmemleak complains about this: >=20 > # cat /sys/kernel/debug/kmemleak > unreferenced object 0xffff8881045fea88 (size 96): > comm "swapper/0", pid 1, jiffies 4294669355 (age 167.804s) > hex dump (first 32 bytes): > e0 c8 07 88 ff ff ff ff 00 00 00 00 01 00 00 00 ................ > 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] __register_sysctl_table+0x117/0x1150 > [] init_fs_stat_sysctls+0x30/0x33 > [] do_one_initcall+0x108/0x690 > [] kernel_init_freeable+0x45a/0x4de > [] kernel_init+0x1f/0x220 > [] ret_from_fork+0x1f/0x30 >=20 >> return 0; >> } >> fs_initcall(init_fs_stat_sysctls); Hi Ido, Thanks for the report. This is a known issue. The fix is proposed here. https://lore.kernel.org/all/YgRbEG21AUrLSFKX@bombadil.infradead.org/ = Thanks, - Tong --Apple-Mail=_84FE8124-5787-4AC4-BE8E-E163022F66D3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Feb 13, 2022, at 7:34 AM, Ido Schimmel <idosch@idosch.org> = wrote:

On Wed, Feb 09, 2022 at 08:49:20AM +0100, Domenico Andreoli = wrote:
fs/binfmt_misc.c |    6 +-----
fs/file_table.c  |    2 ++
2 = files changed, 3 insertions(+), 5 deletions(-)

Index: b/fs/binfmt_misc.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- a/fs/binfmt_misc.c
+++ = b/fs/binfmt_misc.c
@@ -817,20 +817,16 @@ static struct = file_system_type bm_fs_typ
};
MODULE_ALIAS_FS("binfmt_misc");

-static struct ctl_table_header *binfmt_misc_header;
-
static int __init init_misc_binfmt(void)
{
int err =3D = register_filesystem(&bm_fs_type);
if = (!err)
insert_binfmt(&misc_format);
- = binfmt_misc_header =3D = register_sysctl_mount_point("fs/binfmt_misc");
- return = 0;
+ return err;
}

static void __exit exit_misc_binfmt(void)
{
- = unregister_sysctl_table(binfmt_misc_header);
= unregister_binfmt(&misc_format);
= unregister_filesystem(&bm_fs_type);
}
Index: b/fs/file_table.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -119,6 +119,8 @@ static struct ctl_table = fs_stat_sysctls[
static int __init = init_fs_stat_sysctls(void)
{
= register_sysctl_init("fs", fs_stat_sysctls);
+ if = (IS_ENABLED(CONFIG_BINFMT_MISC))
+ = register_sysctl_mount_point("fs/binfmt_misc");

Hi,

kmemleak complains about this:

# cat /sys/kernel/debug/kmemleak
unreferenced object = 0xffff8881045fea88 (size 96):
 comm "swapper/0", pid 1, jiffies 4294669355 (age = 167.804s)
 hex = dump (first 32 bytes):
   e0 c8 07 88 ff ff ff ff 00 00 00 00 01 00 = 00 00  ................
   01 00 00 00 00 00 00 00 00 00 00 00 00 00 = 00 00  ................
 backtrace:
   [<ffffffff81d11637>] = __register_sysctl_table+0x117/0x1150
   [<ffffffff86c3600f>] = init_fs_stat_sysctls+0x30/0x33
   [<ffffffff81002558>] = do_one_initcall+0x108/0x690
   [<ffffffff86bca8bd>] = kernel_init_freeable+0x45a/0x4de
   [<ffffffff83e0757f>] = kernel_init+0x1f/0x220
   [<ffffffff810048cf>] = ret_from_fork+0x1f/0x30

return 0;
}
fs_initcall(init_fs_stat_sysctls);

Hi Ido,
Thanks for the report. = This is a known issue. The fix is proposed here.

Thanks,
- = Tong



= --Apple-Mail=_84FE8124-5787-4AC4-BE8E-E163022F66D3--