From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95434C4345F for ; Wed, 24 Apr 2024 22:39:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17D6F8D0036; Wed, 24 Apr 2024 18:39:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 106B58D0031; Wed, 24 Apr 2024 18:39:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE8B98D0036; Wed, 24 Apr 2024 18:39:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D059F8D0031 for ; Wed, 24 Apr 2024 18:39:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 82725C108A for ; Wed, 24 Apr 2024 22:39:50 +0000 (UTC) X-FDA: 82045894140.28.CECA433 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2059.outbound.protection.outlook.com [40.107.237.59]) by imf21.hostedemail.com (Postfix) with ESMTP id AF2C01C0015 for ; Wed, 24 Apr 2024 22:39:47 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=lwWMN2lQ; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf21.hostedemail.com: domain of ziy@nvidia.com designates 40.107.237.59 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713998387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BbG7sb9iTQTKbtXv3D9xPMCBO0YmgpG/DwKpRR+G32I=; b=toC3IVrhppxMC1/0z+xBjxRIUppU8e1qTeKmTgibRycrPej37uGuS2alsKnOhSPaUTQO+t b92XNdc9Fr6JpEL5zHtAU0Az+OZIIQ0oaQ/zPjpE/yCH7wfa9J4xYrGyZtEgquRjQTGZbo fgYpR6y0daVAgoKzE1auKtqPTXkOJso= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=lwWMN2lQ; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf21.hostedemail.com: domain of ziy@nvidia.com designates 40.107.237.59 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1713998387; a=rsa-sha256; cv=pass; b=bxcqzFTQ45A4GfOPjp1umZWjFrYihNOgZ9zXladHkZnfRdTp4zE3btcUHFvY3PlmNTGDoC VSf4yaUhQOvcXCKnudIGpjpJ6BCpdpJAvWZeIJlzhPigGo2b25DN1xLvqA1Zc2X+3odKQj x3ll4YZpgLTIs26UudGUlW6510OTzr0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yz8E4HbHhEpUAnIYxn45QikVDJ8TWMXsbbNNRFKezdBUYNj6A9tPTLi0QI490jIooPRybK2z/OhIPZTiq15APuLr11NzTRliW0310jAcwUKL6tki4X3Lvyd9QiXPFzlO0AdK3zt+g/z/r0xGNWll9lJUNHSj0qFnJCqw3DxGHo0IqrAIgpYVkgjk6N5QW4KrRncTeI9ho2X9wu/Dk0/2M3NYlaJ9rSx73ki7141thbeX7sFkexhIoP86XGCYzYyTYa8CAps8kMsNIbEyDEgI9dENCcnhRVoGe1yoCEIlTtSDUxJ7dI0fPhQsY/VfHVi/TJmKwPSXxVftLnzO9JifBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BbG7sb9iTQTKbtXv3D9xPMCBO0YmgpG/DwKpRR+G32I=; b=ljTpQKidTSl/nSv9fla3QV5VBkVmFzs31MLETvKP8m5nYD9OVtdG9JDdSm7NZec/VKA5z8E8RJ/tCqkPxymT8TbajydMf7XDDaowykoqXSB+s3jDEF13AtPM1N991fGv1hneNlrdHdaQ/2BhN9a97xP0bVpfv+K0VWHHQqkYOjcN7NBpy7WmHzZSzi6Y+DqVIGyQx4Hv2FM/Vex0ibyZbqFOcGS0HxSKzAkSJhmX5dwJSOqx2FxmVHfeB6hLf2aLrtYk6pqFCkp7RwrDPOloK6rH3VDwWi9JlmYsUwdfDDJrnU5yjkfIVT+cvjBPkG4GoyCxVSoQeRudvZB1iXoX/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BbG7sb9iTQTKbtXv3D9xPMCBO0YmgpG/DwKpRR+G32I=; b=lwWMN2lQxVQq5CMMdsgAcXQbWslFkTNFAISe/Vw4kHaZMf5mS/fSjebtJe6Vl8ktjqJSoCsqRgLK4ENz/gucUNB7RWqWl3LR+YQlsmhN5sI98UjzfIicleyZ/aed1COHPUfKG0+s+kjDw2s64Q+2iHfKWtas90hY/S6G+clJYJSA+zl7g/8kVqQzUkgKu5BOpt9Hu+xB/WzzCf9y8fgA4iCCM4y5FWHKFILx0L2+j79JSRDHSFToLpBU6ll0xpTilsVZ6efVtL3+9vYZUcEgbZBv24HzGfLc1hEZEcQoj+50EZwcZM/IAfOve9wC4F+imR/m9Mjj5yInxY9ffRT+1w== Received: from DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) by CYYPR12MB8991.namprd12.prod.outlook.com (2603:10b6:930:b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.24; Wed, 24 Apr 2024 22:39:42 +0000 Received: from DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753]) by DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753%6]) with mapi id 15.20.7519.021; Wed, 24 Apr 2024 22:39:42 +0000 From: Zi Yan To: Yang Shi Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Ryan Roberts , Barry Song <21cnbao@gmail.com>, David Hildenbrand , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/rmap: do not add fully unmapped large folio to deferred split list Date: Wed, 24 Apr 2024 18:39:40 -0400 X-Mailer: MailMate (1.14r6030) Message-ID: In-Reply-To: References: <20240424211031.475756-1-zi.yan@sent.com> Content-Type: multipart/signed; boundary="=_MailMate_4E2CF516-C937-41EE-991B-24E683F9E68D_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: BL6PEPF0001641F.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1004:0:f) To DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5744:EE_|CYYPR12MB8991:EE_ X-MS-Office365-Filtering-Correlation-Id: 95764397-6e84-47b1-050e-08dc64af6f0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T1Rwa3pMSHNpOERXS3JBcjZTdFlhTHI1SmFOQmVNV085VWl0Rnh1dFY1Z2J0?= =?utf-8?B?QjN1YTZhQk9iRW9nR1VFd3FEL1h6enpEQmVUYXNZaGxPQUZxQ1hmQ1AvOTNj?= =?utf-8?B?WmM0WGhMbUZITG1ORDZ2NXBieTJXZ2NlbkVubUlhM0xDb1JNREhhQVh6Y2lw?= =?utf-8?B?YUpyaU96L2tXWUJiY0FkTGFnUERrN1hkRWRNVVlaY0pRWjlIcnhjWTU3RmtS?= =?utf-8?B?NFo0eUdtdG1KUVpTMUp1eGN5UUlpSlhOWjJlVDl2ZC9uZHdnMW5Fa0NLajRr?= =?utf-8?B?ak5nQ1AyOGxUWXZXNEEyMi9YdkF6UWplazVxOVkrYWRLUGRIaE1iKzQxZkFq?= =?utf-8?B?ZDYzTUU0Vnc4L0YwSFdRTzRaL2ExT0xqR0dvb3NmMTFhSzlyK3pFNnorR3dh?= =?utf-8?B?Z3BMai9Pa2pVK1M5aVo4WkFGZEtPM2JXTU9VV1QxZFhNSTIxeDFuR1JpZjdK?= =?utf-8?B?ZDBkMDRWeTRpVmRFWVh1QWFINTNSbklKQ28zWTdNNVNyZjFkdzNTZ0xBNG5M?= =?utf-8?B?NmJGUEVLakZFRFFMeUg3d1lsV0FkN2pNaEdyc0MzQ2VISEE1MDFxdG5xeFY4?= =?utf-8?B?dE5Mamkwa0xGajQrU05GaDJxai9nTGx3RHFVNDdUeDFsT1dxOGZrZEMxTmcr?= =?utf-8?B?QWhoNnRhRFJKQUd2Zzc4TDNOK3Zid1A0S212T3ZzS3NsYXhsYTVRWXh4NkNl?= =?utf-8?B?OGp1T1N3S2FkM3l1RU9lZkVSZlJ1NmJlNXk2cUNYNVBrcWFWSFZsVVptUnEz?= =?utf-8?B?WVIrQktDK0x0aDI4OEtxRjNaN1pyTEVwek9tQW1iMU5PR1RQUnR4eE9IM256?= =?utf-8?B?cktqT3JraGJmbU9ER3dqMVFzTDUzUDlnRi9mQU1ybUxhKzJIQ0lla05yZ0VP?= =?utf-8?B?UTJ2czlTZmpHSVVTdGIwTHVVck5xeHZpM0swZDloblZSU3plaW9ta1JGdk5N?= =?utf-8?B?bzBRREg1R0VUUWcxSkJFVk5rYnlBelMyMU5IYmtKOThjWlljY0dBcXBDYUhM?= =?utf-8?B?S1o2KzhrNkh5TmJRMUY4RXVYbWt6ZThvWDVjc2dWNCsxT0xIMm80NmZzbWQx?= =?utf-8?B?SG9ockVMMWxhSVl3aFFaMWNOaWlJOUN6K25PSkNoRmhaOWt1TnBuQXlQY2Ra?= =?utf-8?B?ZEV2NDNlbzA3Q0VUc2lTbWx4TDJWSzZORFJib2xONEEwNjFOdUt4L09uQTlD?= =?utf-8?B?ZUx6Z1RHWDYzUGRDSFgvL3F4VVpSeStJNW80ZjlWbTQ2d09UeVR4YXhPREVG?= =?utf-8?B?bXJJVEVNSTh0b0V1dFV4Rks0T3ZiRFlEbHRMY01aSkJMVnlGNjlxcWhtMnRx?= =?utf-8?B?dEF0YldjTi9uMmZWMDZta1hzZmtGeW9JaVNOM25sVVFlZzQ4ZHM5dDFabHA4?= =?utf-8?B?MHFUNGhpOEV6UWZBY3F0VnVhbXNWRUtjYzV4SE8zdEQ5YzFEa0NucVRPZmhG?= =?utf-8?B?cG15SnlNZUhVWFQ2cDdaUkl1TUYrZlMwQUZ3UjNla2daQWc3QlJKSVVEUjY1?= =?utf-8?B?S09kM2szdktJazAzaTZqZWxwb3lRVlpWMjBGMUdaenNZdkZtYURVcWdBMUU3?= =?utf-8?B?ZTg1TzZrSERQVm9GNjVuaHNZditaUnNMb1QweDhnT29GNlZmMGlkRmptS3U0?= =?utf-8?B?NHpWUVlXSU9zdFVkK3hQcy9ZRVF4dTdqNU1TSUZKYmRMYzVBK1kxUkk0UzJw?= =?utf-8?B?SjQ5TStqUmthemRpS2JaaEVKUUtGWHlkWFVRNE83dWtYVjBURzh4cTBBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5744.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWdVTVFqOXFYT3pHZW8zWkF5RmplYjh4dG1YTFlqMkVod2RwWldxWmxjbXRN?= =?utf-8?B?THZrdVBkSTFmclNZT2tBSFQybWxGR21HU29WUlY1WTNmYmdUdUlxRVprWXdP?= =?utf-8?B?aUlGZHdoSWlucElib09aY0hRY3VhUUtpTUNGelczQU5raFFzak9xUkpKbGo5?= =?utf-8?B?OGRFV3FNQ3dEaEdpS0FJa2h4Q1BkVVo4dGVWaWIwbjMyUFdHVW5rTFpqbzZp?= =?utf-8?B?TytZdkNVRnQxRkdKOVFzSkpMMW1xM2xLRlBBM0VKZlZFcmNNLytDZ3RtdUYw?= =?utf-8?B?WFlIVktKbGpmWmE4dHlud0hoNlhZMGYyV21GZVRXcGNQc2FFVmc4MkhVenBu?= =?utf-8?B?eC83SDY3WWs2ai8xazc1R1F0d3Y1SHZuQmFhVUthYS9JZHVwTWdyWU84N1pY?= =?utf-8?B?dUlaWUtuMHRVUDF5S2pZSlFwdzRTenFjdGVtMUdqWkFOajIvMldWa2NBWGc2?= =?utf-8?B?dFVacE9pWVNvenVuZFMzbTRFRGx5ajBoaC9ZSUpnUFltMTV0NHVRRmd4SVZI?= =?utf-8?B?bzkyWVBlaU1odkZQTlpZUzlBaHJ2RmlCakVtQ1BCMmxncVlQc2NrYU9UcXQ4?= =?utf-8?B?dURwZVpKdUVCaWk2UVBpMyt0WVowaUhLd0ZhL1o5NndLakdoSWxrdnJReDFT?= =?utf-8?B?aTBXUzhwcnJkd2JKdkhBb1ZUdU9aaisycEV4RmlWeHVqY2lXNFpMZ1RWVWJ4?= =?utf-8?B?U3E1WjRyQmFwRkZoUU9HandxbnY2RDg1K21NdnNmR0lxbTM1YmtmL3h5akNE?= =?utf-8?B?RzlVQzlFcFdiSm1aY2ZDbFVyZUd5MVk2VzdQTmhlUkhQSU51ODZ3VEtpODlX?= =?utf-8?B?TGVvZk9TaVN0YWw1cGZRdjQ5NUI2by9COWZXSzRyM08yQzhScWllRnVQemZK?= =?utf-8?B?em1zT0tPdFJoam82empyQXM3ZjdmRDZKNWlMZzFYV0lkeEl4NFByOGdpYUcw?= =?utf-8?B?bVFNSUdsRFQ3dFZoT1NXTWJDZWhuUEZiUnU4RE9ZZnJESjdtVy92Y1ZZWlRL?= =?utf-8?B?VFI5VTltaVdnSjNPUTNpYTNScnFVNWpOWVc4UzVqbTEyMUJSMXdOUUo2Wngv?= =?utf-8?B?ajdTMFpLdEtrdkFhaGJJQ3kyN3htSitBMVdERzNkRnVjSXMyWU9UdzMzeGI3?= =?utf-8?B?L3Y4UlJYcXR3QkFRM2VRSWN6YWRNMjkxZjUwRjFFQ3RieHBHcDk3eWNVM1d4?= =?utf-8?B?NlBaV2EvUnBSbWlWNGtDK3AxczN0Tkh4d0lTUTROMU5WT3FaOTJ4dkRidVNR?= =?utf-8?B?WnZ4TmhMSjgrNHRyN3lXS2svZ3E4Ry9qM3dyOHVFSXg3Ui9FT0luYXM3MlpL?= =?utf-8?B?djdEZitPZ1FkM2RjdFpFR1RQZWN3aldqZDVPelgreVdiMmN6OTdpcTdiT1c1?= =?utf-8?B?bnoxTU85b3VnaHVyQnlyRU1hSTBaMTFrSWxNdjFlTjU1ZlhXKzRkVjlOTEhS?= =?utf-8?B?QVhPeUY3ZGpQZ1l5VHc0TzdwYzhRL2xCZHB1Sm45OWN0dzZZak9sR3NUcTlI?= =?utf-8?B?ZFFZbTJwZUNJSW5UYWU5Rk5DWWRZdzhubnJpUk0xUC8rNjRFNnpSY294T0ZK?= =?utf-8?B?RXNNZ2w2eExLZytzUmVBMmZKbzN1cHBTMmhNbDM4Yk1pZnY2Rk9KS1VTVVpr?= =?utf-8?B?N2EwNjZHM0FoWFMxeDdJVE0xOTdsRFVzSDdaRDJTS2VPTXB0Zk5QZ3lYV2Ns?= =?utf-8?B?NmJKZE1Manh6ME43ZGNGVnZmd2NCWFoyRlgzUllMdVZaNG5uRUsxRjlocmxr?= =?utf-8?B?c1R3ZFlaTWQvL1V1aVlhNkFtRU1VSEM5eUpUS0FpQWpNOGNyUFlzZnJQa1Vx?= =?utf-8?B?ZDdOSm1oNENLTTlRMFROQjBIYmhraFBiMTFWUTZVVnlkZjlLbThObHBhanFw?= =?utf-8?B?OFV1MXZyVmtWVzNhdWEzWm1tTFY5UGo2VWJZbndEZ2VFemdQcnFUMzFSU2cx?= =?utf-8?B?cTlFd1l0bllzQXFIZVJqZFYwaDBZUmxYcnNTYzZlMHNFbjEvV2FqRFBhdTdR?= =?utf-8?B?SENJMXBaMDQ1NWdyVWs5enV0aTBlcDl5cnhjaUxtSURWUXc4Ri8yaVc3cWRm?= =?utf-8?B?Z3ZMMVBKZ3RYV0REYStvbjFPMWMwU0xMOEhnWlVxeDlvQ2FNVDBTWEpWbzZ0?= =?utf-8?Q?5KHk=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95764397-6e84-47b1-050e-08dc64af6f0f X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 22:39:42.6179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0x7z2fec7gurlWxJoC8E/JvbVjYpWfgL54OKGpVFr1KTxw+g1jaC4NVKa7hx73yO X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8991 X-Stat-Signature: j3xf3rkym1wsxzhheghdfuo7kicwci33 X-Rspamd-Queue-Id: AF2C01C0015 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713998387-885529 X-HE-Meta: U2FsdGVkX19oVPhVv8Y9T49YY9ldUkpjjUBJCOfO+Op074PfKAZYC06OaXbF8AKbG/16f7fTPxFT8FUzr9w3k31CzvIu53NnKuZyU9Zc2L4qFFf3fHed3SuP3iVb1KyVnrAiwpMWtlzSIixU4vSb0dT2fkYepmHe4mmpjU2/PNo0GYAnAmzzjvJb4kCqE16uFUb6R0ZmtM9Gfwq+I9usQJO99n7RlgWzMQnu/CCCHxB7WHbyVtsq4I4p76LfpGvQ8B4qY4oBaAlEjPNnPzdNZFAshs4/5dw/lb0fSm9Fi1fqYJt0EHFxd/AOVy9JfWgFh9pppExOxwGNMcEEPaQb87YisC9LYSXWRkCnvCBIuErO56sfbzL5Y7xBkyyHDXMKIxYgfOLrFczO2KMXs7DZMyUsNeeSUZDfOZYkzpedkvGT7VZMdeWlf2AYyucySviMhRa8S4NgiS2V1nzjCJN9fwvSG7DMAKIxs92oDpNl3hXJIWd6Kv/sT1PYbY/jzmC2ZWuuQXoXF+XbgSix1Zw6VTcMm/cXyC12Ww7tB9SeYDa8H6x/9Oy7j7SlY6j3S6HCTd1/YbFreZLK8nlY8bGpbmIcgEhPLNTXhKAvoBM0qp0hI8hqGVYloGrxCRr1n9Ea6lMVAjvjuahZVKva/h48xbs6VJSNpl70V6alvDGavL3+Su3hXyst2is2Jy0fI8hpZPxrzzCqIkha0SJlhZD4XxCO8ovBJ8JvIVm9NvLtA92LsqIZRR4EXuZiA5f8xH3EOflYGAVKqjPbm6e9Pxjy5jAqViiR3VAbX5PlNVFXYuVU9eYPkq/svdroCzGjJlyxfGNjSmUR1Mf5nv9ARbyxzM2Y+09rC6u8Twhx9QFQ60PFTXQxQ4XBT7xRsE070SXxIRAtdvFgXtomfdxGtosrJD5Uu4DJJVRakff4v67vccCn4Mlo2tTk48jEb0emCrbUshrFqZXHmQsKCyMorMA 5aJr79DR 73xb0kXwPWxL3Qr8eA8vvBR/HF6fWDYatQtochARhyo0GyLkTsHiltKsamsgBfWltlzytT1TanGGsI9SPou+H2M9G3z5bYzAL9Ohh28C3N9cOQwndPz8d6052UuyObbK55pIkL168IubLr2nFTX5IMkcCbBVswYnQ1nIeYoHdFEwTf/kntiBiGFbTMV5ktdiZdDDAudpDAu81bg+Lr4OGnzMC+V9zLvq6YiwmGaceJa/Q9XBIKfEvXQFkItIqDqbngYR8dPbKJY8PNOvakCYkwrD+AXYKHUxpUylB25RPp4Pb6jtM43V2gYT/FGnCE6Mof87iJkrW7YN27wo52AVM3cU9htMTfp5wTnf52IRckMoOd1gQklPJG9QC6qANlQz5aboScfEe00YMdbPUuv6eGjMytc+xr6ENzESfP4yAPVtgWjU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_4E2CF516-C937-41EE-991B-24E683F9E68D_= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24 Apr 2024, at 18:32, Yang Shi wrote: > On Wed, Apr 24, 2024 at 2:10=E2=80=AFPM Zi Yan wrote:= >> >> From: Zi Yan >> >> In __folio_remove_rmap(), a large folio is added to deferred split lis= t >> if any page in a folio loses its final mapping. It is possible that >> the folio is unmapped fully, but it is unnecessary to add the folio >> to deferred split list at all. Fix it by checking folio->_nr_pages_map= ped >> before adding a folio to deferred split list. If the folio is already >> on the deferred split list, it will be skipped. >> >> Commit 98046944a159 ("mm: huge_memory: add the missing >> folio_test_pmd_mappable() for THP split statistics") tried to exclude >> mTHP deferred split stats from THP_DEFERRED_SPLIT_PAGE, but it does no= t >> fix everything. A fully unmapped PTE-mapped order-9 THP was also added= to >> deferred split list and counted as THP_DEFERRED_SPLIT_PAGE, since nr i= s >> 512 (non zero), level is RMAP_LEVEL_PTE, and inside deferred_split_fol= io() >> the order-9 folio is folio_test_pmd_mappable(). However, this miscount= >> was present even earlier due to implementation, since PTEs are unmappe= d >> individually and first PTE unmapping adds the THP into the deferred sp= lit >> list. > > Shall you mention the miscounting for mTHP too? There is another patch > series adding the counter support for mTHP. OK, will add it. > >> >> With commit b06dc281aa99 ("mm/rmap: introduce >> folio_remove_rmap_[pte|ptes|pmd]()"), kernel is able to unmap PTE-mapp= ed >> folios in one shot without causing the miscount, hence this patch. >> >> Signed-off-by: Zi Yan >> --- >> mm/rmap.c | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/mm/rmap.c b/mm/rmap.c >> index a7913a454028..220ad8a83589 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1553,9 +1553,11 @@ static __always_inline void __folio_remove_rmap= (struct folio *folio, >> * page of the folio is unmapped and at least one page= >> * is still mapped. >> */ >> - if (folio_test_large(folio) && folio_test_anon(folio))= >> - if (level =3D=3D RMAP_LEVEL_PTE || nr < nr_pmd= mapped) >> - deferred_split_folio(folio); >> + if (folio_test_large(folio) && folio_test_anon(folio) = && >> + list_empty(&folio->_deferred_list) && > > Do we really need this check? deferred_split_folio() does the same > check too. Bailing out earlier sounds ok too, but there may not be too > much gain. Sure, I can remove it. > >> + ((level =3D=3D RMAP_LEVEL_PTE && atomic_read(mappe= d)) || >> + (level =3D=3D RMAP_LEVEL_PMD && nr < nr_pmdmapped= ))) > > IIUC, this line is used to cover the case which has both partial > PTE-mapping and PMD-mapping, then PMD mapping is unmapped fully. IIRC > this case was not handled correctly before, the THP actually skipped > deferred split queue. If so please add some description in the commit > log. It is properly handled before, since the original code is (level =3D=3D RMAP_LEVEL_PTE || nr < nr_pmdmapped), meaning if either level is RMAP_LEVEL_PTE or (level =3D=3D RMAP_LEVEL_PMD && nr < nr_pmdmapped), the folio is added to the deferred split list. So only level =3D=3D RMAP_LEVEL_PTE part of logic needs to be fixed. > > Otherwise the patch looks good to me. Reviewed-by: Yang Shi > > Thanks. >> + deferred_split_folio(folio); >> } >> >> /* >> >> base-commit: 2541ee5668b019c486dd3e815114130e35c1495d >> -- >> 2.43.0 >> -- Best Regards, Yan, Zi --=_MailMate_4E2CF516-C937-41EE-991B-24E683F9E68D_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYpiiwPHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUsBoP/i1R6Eg/O3e4UD3vZje97FdyclYWCutpQ1VD 4iTRaVY8ZZ6+1nix1RLWzrl9CeHTyXUTHn11Or8AikWero4F3oih+uoc3LOZpSu/ qpCcMR+86KSgCvVoBY9zM2n28ptz998ytoJ32WMvSad4CR+BCgwyZGnoNjZpB/bm nCh5he72Unu77aHtQbjBbsmAguwcmaHEzkVGgLP/EpSkPnH6wZAaknfMfpC3iRCY dhpkSthImGYCxb9DWZKbG5YLGz1EKaPaniu267GXT4BProW+0G1yM5X7QxO8NTqd NKDQ6g6nOAlzVPqzSYKTkFSJ7uzLwGYXE6FM0wONwCJclDHttGNPQxFNSnW6iZaz 6M3oAXtTNRFetRW1cVltBv38TBM4tOeiUjGfUjbJnnQd5z15AqcGwFe65gCrHc1H PyxNlACEOuzxHEApZJxkt6VeLDRV0cR4gpW+6V7SGLmzHKAeTjwC7RG9rsTPOPTe wJvowGMSEKxcKLNfYTgiVjIQDLAoy3qtAjn5tBmvDUtLnMXoSlItYVqVY9TdA1jN nm2qPzCWN2mADVk2jFJ/2ypHZbxgMLYtxmVxRy5T2miBvTuO2yXxH5oSXCGh5o08 3ifiwHf8Vi9pQRKXGP4LBlbYKuFgrq+O9MEP+BdTEaFUqLYiaIoH66xATOf77hN2 Udx91HNp =q/Fi -----END PGP SIGNATURE----- --=_MailMate_4E2CF516-C937-41EE-991B-24E683F9E68D_=--