From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED28C7115B for ; Mon, 23 Jun 2025 14:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B100B6B00C3; Mon, 23 Jun 2025 10:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABEA56B00C4; Mon, 23 Jun 2025 10:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987856B00C5; Mon, 23 Jun 2025 10:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 84A536B00C3 for ; Mon, 23 Jun 2025 10:40:02 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 356641A03EB for ; Mon, 23 Jun 2025 14:40:02 +0000 (UTC) X-FDA: 83586925044.16.51EBC86 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2083.outbound.protection.outlook.com [40.107.102.83]) by imf09.hostedemail.com (Postfix) with ESMTP id 6DE9014000A for ; Mon, 23 Jun 2025 14:39:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=XBIIwKBE; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of ziy@nvidia.com designates 40.107.102.83 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750689599; a=rsa-sha256; cv=pass; b=zKjwFUpesSY8KdjqqQ70adgifcpi0dcfs1CbCafSppmQIUgEqzhrMF44DAHSVgU5j3U8ax h8QfW7POKlGlE0KghzPz/MPIeTg2AIGytzAVarV8+GUZMM7YNxj0riC6/fd+0KvYPuZDs2 TM4e3nFX24mIOrmw7in0qIj2UP3gcBA= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=XBIIwKBE; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of ziy@nvidia.com designates 40.107.102.83 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750689599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qACd2E2k2yxXU/5qYLsoN6ENxvc9EIwJ2s+VTObtkOQ=; b=AVUQrurUaMH/9z22JT/81RlMb9eFRbJekJQJhGZ/xbXkgxRpq53pc4hdV2r2hitTTweQvb GC5zOwcclb2GAD4t71UDOHyX7BhdUQuOFbXxLUn8FquBMpH5jntJtey09dQ4vY/NpFU2wa UU2RutSqWpm00+BiKv+iEHG2oYbl+to= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sYOg8/jzWjlt2oKCcvpE3yiwZgXHJctA2+WMxR+Mn0XnUlAoE1Np1bB+wEYUqP+h47KykVSTg2C1CUYBW3o1JgdimeirIozWZCqp3br43bYM2B0H++NxvvDHC+A3DBifMiO+Rx+61XcV0oAvyrb+XyE5bfO41RPmKvKeB7XX4B8rsT31A2hZCuOHprLHW8hncM/X3z8I1zxKz0FqqYNRSD9VePVpjwZr5sNu8UNqwxH6rGQZ/ueY1HpAqKKnJ8CKNDvk61EZvPI8LqaKjD0ly92Ja3D4E1hF8L02TNTD8PSXt6cMqdmPdStZ1tpcO/dioV0+6u2euu9qg0QIm2d97Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qACd2E2k2yxXU/5qYLsoN6ENxvc9EIwJ2s+VTObtkOQ=; b=AF1weBwe1EL03xqy5VDchdfW95wZsY4T1/O0TGm+J4EFOfiR4zyy2L9hA/Oiff/y6+74/7I7SOUKCLKzPRMSrCRDfbU8CzAGF5nr3U9hrDFfc2zJUyuzQG309TcFeA3zaj2Mxu7rnLV9Au4zX1Ue0vv0QxeN7SlBJ8pkov6asv7+Wz54ODMYW4b0+RVQ3g+vsnoGRa85/cIIRIr9L0JRzjhKFYvYvUoJ1+EtG6DNqqv/DDiE06CWP1jWl3VakyaXfhLk4K6LO45nJa2ER2wOVqjLhOeWUJGm8NcPbNW4xbhqWBeS5O1JZ40QRZr32FO1cxD6luTjbte8LW8ESHADCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qACd2E2k2yxXU/5qYLsoN6ENxvc9EIwJ2s+VTObtkOQ=; b=XBIIwKBEHtialVeJ/bnOYWm5rC6yXtq9z2M2Ly2rnl4C31Pj8+2l4UEASXQ/XPadwpYQ78YNvMRlS6tE2kWfC87iIZkB107kOXioqphM5AeSgaOwwz3lpBoW+lQCTckSt8oW/nvfsBpZb7mN2c087byA9LGkCbij+TRM3AutHfsw+zqMyxK63VzpQ5YtgaTX2oWSetTmlM4bmjy34JhOdKoZekk0XxZOnFMip0m+LUGOnV6+bwL1TzwEZrDSaDP/Q7tsXQ11Iq/RxZLJwfmxLAFA8W+2o6XWVXLBIPPONUyH5dlqmDy6qyfMvTqxGZBSuFPaTzcyj97ZZVexyo1/0w== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DM6PR12MB4172.namprd12.prod.outlook.com (2603:10b6:5:212::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Mon, 23 Jun 2025 14:39:56 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8835.037; Mon, 23 Jun 2025 14:39:56 +0000 From: Zi Yan To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled Date: Mon, 23 Jun 2025 10:39:54 -0400 X-Mailer: MailMate (2.0r6265) Message-ID: In-Reply-To: References: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0394.namprd13.prod.outlook.com (2603:10b6:208:2c2::9) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DM6PR12MB4172:EE_ X-MS-Office365-Filtering-Correlation-Id: ea6a962b-63b6-4371-7c47-08ddb263d2c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?STFmeUZwM2lTemdnMUtOSzVkajJaVDl3ektLOWJsMUE0WHNDWmcyYUo4bkFI?= =?utf-8?B?MHQ2YWFodHhTdVZtTElJd0llc1FkNkhtenFGTVFjeUVDZkVqYTdoclhTWEVr?= =?utf-8?B?SFR1U2FPQzVhRjNNcHdvMGRtWlhUYXpxSUN1RDJVaW5jMVhRZi84TXNjWnMr?= =?utf-8?B?VGJralFXRHptQ3pidFIrWmNhcVd2S3ZUMXFLbCtKR2ZSaVlsYm5oT3haZnJC?= =?utf-8?B?bkNXZ0xHR3FtL09tOGRjUmFwa1R4MkhBdVF2YVIrZUs0WllGUmp4T2Q3SkFq?= =?utf-8?B?bmN1R1VUdThZd3FQcFZEZTUvZ0hIWkNkdjdrR1ByWDgwVWpzZ0hWK2JUdFdj?= =?utf-8?B?ZEFKdGFBUXN5TEU5TkRnR3hIUnUrN25OVXVHUnFUVkNVYlhubGMycVI5VU5o?= =?utf-8?B?RDgxb0RKRHVGakczMmhhZldQa0s0bjlsMHdWb3NXQm5lL1RBOVhjc3VZWkVo?= =?utf-8?B?aDFvQi9jaThFenpzd2NhMkJQSUhpTloybTRzTWFVVEJvTTJVRlFkL1dHb3Ba?= =?utf-8?B?VlY3OVdWaTNXKzNzU0hFYUFEaVVEY2dod1RlWEhYOXkzS3prWmtxVmpZUjlq?= =?utf-8?B?ekpGOWZTMXlHUkorY0haamJmUVE3ODg4MTdTeHFHeU9QQnhlZGZCTmtMYkhy?= =?utf-8?B?TlR3d2padVhZK09TRHIxdklYR1ZzaEtiT09zMWx1RXVXcG44M3pZT2xWQmY4?= =?utf-8?B?UXNVcTd5UFlUSUlkOENXNjFsdWt5SmVHczQ4UVlTb3JDNWZLdlBkWVNlUitZ?= =?utf-8?B?cEhpMGt4b1pSTUpFQWxhamVnaldJamFTV1VpektqV3Bod1cwLzFaUXFFU29U?= =?utf-8?B?RmVpeUF5WlpVOXBxdlBDTXJNZDJ4Y21henI0ZzRTT1pkSTVtK0w3dGJKN216?= =?utf-8?B?bDdubCtwMkhkYXdPNXNlQldYMEtTWnlmbGZVOXFGcitOVXdITjFPTXUrWUNh?= =?utf-8?B?cmhQVUljNmhnZEt1djJDYndVbTE5ay85Y2tmalNncjNBemR1ZHlKL1hCU2pZ?= =?utf-8?B?TnZYNCtSWmFMdm1hMHB3WDREY21tVkIrOXh3Ukg2emVPckU5ck9UNERMN1pz?= =?utf-8?B?TE41UVFhVmUyN3Iwa01OK3ZUdUU2ZXpGa1o0aURoWVorTzZqbmo4d0gwVGlq?= =?utf-8?B?dzRvVDZ4c04rd2JLSURVVHprdmlvSEowZ2IxbTNBTEQyb3h1bGhNL2dCS1d6?= =?utf-8?B?UkJCMzBTNWhpd2FWYW1tK0RyQlRPRlpQTGZhVjZjUW5EaUM1eVdTd1VqVFJP?= =?utf-8?B?ZkE4RkRVVG5TY1hWaXRrS2wrK1o4VXJITmZSc2xTN3ZEcVVhK0RWenl0dVl0?= =?utf-8?B?bXVZdFZjWk9OdGtIVnE2YzFIZHFQQ0I4OEhzZm45Ujc1bzdzUzVBalByRTdG?= =?utf-8?B?aHp1ZjdlOElSd2hJSFVCNlNXNjgySnBSNHM2Z1J5bUpYczZUcGE0MVo2blJX?= =?utf-8?B?Y1kwZlRUMlBpbzk1SUI2dmxFMGQ0QTQ5RlVpY3hYS1l6ZlYvQStkN3RTWFJm?= =?utf-8?B?cXpPLzJzVVlKcXkwQUVBNERzWmE2ZDl3UHFJaVB2VFdMN0ErSi9ES3NVUDN5?= =?utf-8?B?L0tsOThPQUdrcEtwMGFBY01rUWNJUXFLR2xEaDR6endka1FGZWdPUTUzUVlJ?= =?utf-8?B?ditNZW8wWVBwK0xQQ0xoWCtXWG55NnJyVUZ3ZEE5OWxGcEk4emZXRFJKajBx?= =?utf-8?B?YUhrb1krcVE2VXQ0YW1MbHN5c3c4azhnbHdQTktnNUEvbU02NEo0eFlmTHNR?= =?utf-8?B?elkwWkFoL3Nnc1IrQlBvUGZDQW5nRlBSRFJiV3h2RG82YVdNa3JnbStKYy95?= =?utf-8?B?dVdZVlVPUGZXRzVyanZ3TmpZQ1pML0NvNS96ZXpMNEN2UGYwbVlyZHpYeUNM?= =?utf-8?B?SzExUTltclR1Z3NYT2VMUGpXcXVSVHBQaG9veE9rdkZPNnJhb2dUbUVYVDZn?= =?utf-8?Q?0jnHDEaT2ig=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzYyS1pFanhOYnFrT0U1L2o2QTdZaGFIUHdvUEF3Nm4vRFJtS0FENjM4TE1I?= =?utf-8?B?SWpMcmowbzVPTjJOWDNwU2lWNDIvajdVaWFybnlwM3NuQkZwV2dXVXdwVTNC?= =?utf-8?B?ZGRuV1ZjaGdDN2FBaEl2SUFPRmgwQkp2L1FrOHlid3NxV2xYODl1Zyt5MjJk?= =?utf-8?B?VjhtTG9CRXN4NVR2OE90YWNGTG1yZjVIaGR0eTFEeWhiSEQ1N0o1R0tKUVdu?= =?utf-8?B?OWZEZWNxMEtqOXFjRjF0SmVvYmRzc3d1UGFHTStVQXRLOU9ibWkvRW0wMDgy?= =?utf-8?B?SElVeXNDblNKVkc0S0paNzhHOWIyaW5vSXZ3OXBWVjYwNUl1WnhMaWR1Z3dn?= =?utf-8?B?dWY1aDlub0tNdUgyVFU4TVIvUHJaZnFkNFZKVzdhRGFyUWhLNTNFRmlqMGdi?= =?utf-8?B?VDZQT1EzSzhCdjlUV2tONU9CdWFWMXlDcXExVEJUZ1JmQm1pN0ZuZ2Frdmg2?= =?utf-8?B?WUxYMkJRWDltWFltR21oSXhPaFRqcXBjUGJkK1krN3QvRy81VWFhSXQxb3A1?= =?utf-8?B?L0xXL0dkOGZiTlZockU0MC9xL29MYVFYNU55ckhtVzhKem0zbzdjY3RIWlZh?= =?utf-8?B?TTFPcjFVUm5UaktBMElQbWdOU1BqVUVuUHNiZ0hwU1ZCZStrRC9BUlhZemFi?= =?utf-8?B?bFJyUEVWQUlpUzlyMUNsRU5oTzFleDU2d0hETWRnbTBYVkZyUUhiT0ozUEpa?= =?utf-8?B?V0lwM3JhYXhYOTh2cDMwWHhPZ25OdkVNWklyVGl6R0lsSVZrQlpnWWRzMzU4?= =?utf-8?B?ZWVWcmdQZjBUT3QzUGllbElsUWQzeStXTEVEclJLMEJrK1dCNVdzM3Q4Zkx1?= =?utf-8?B?OHpiZE5LRGJjcVd2TlNJTmczb1VqWnZyWk81ZVgxbkFmellmTnJBTTkwZjly?= =?utf-8?B?dGZLTStUOGtNblF5RmdGeHo1d0N5VitJWVI4WG5YNU93Y0F6R0wrbEZDVFND?= =?utf-8?B?dFN0ZmVqMHdWdGFzd0dBRXArTVU5MGt0QWhqVmVuWmR2eTgzSmVGNUZnL3Fn?= =?utf-8?B?M0FQbGdyNy9ad3Fua0cycU5McDVWTlZSakVVTDFLVEUxTzI5cU5mdVAzYmlr?= =?utf-8?B?dUdCRkcvSmJRV1huWldsaEZqQmxPaVAvV3VCYXZlZUNMbjVhUVF5SlFKZ0FX?= =?utf-8?B?eXlUZVd0UkdFUGRHem5icURndjgwWlU0MzFFd3A3V09QNU1JNExuK3Biemla?= =?utf-8?B?dXBKMk54TTVhNGlVMDQzWCtURDRxelcrd1Z0b0pzaDB5Y3plWStadEp2WVRS?= =?utf-8?B?aDlmdXlTdloza1Rtamo4TmE3Unp6MmF3Q0VOeGExbCtOSzFiOEM4dkpsNGFz?= =?utf-8?B?c3RUdUdLYXp3MXRXU3JpeEd0MS9mZHN5MGYvUjFNUTk2YjdLdXA4aDM5cUh3?= =?utf-8?B?SGFFWTh4bUZ6R1hqVEc2YnphSFVTWGtTOHN3N0FUdGt6YlZrbUxnQ1BrKytj?= =?utf-8?B?akk5ZUljU2h3NUZkVCtuK0NOM1FvZzVJRjZUUnRqbStKOG5EdnJ1QzZJcktm?= =?utf-8?B?emxDclVZb2hBR1NMdVJrMm5Ma3M3YkFac1VLb1VlUHN2ZUUwZVBPTEx6Wk1y?= =?utf-8?B?SVJ0SFk3QUZJM25BWEswcHdkck92b3lUZ0FNeWR4MWRPeFFjeEFDbWFvLzl3?= =?utf-8?B?Mkk1SmcvZ2laZk1CNkZzd2ZaWHg1YVRwWjZHem5BOUJOdFBjdnZpMVRUakh0?= =?utf-8?B?WE5ISVBMclE3WXJ4L1dwS1ZIWkxMSncxZVV4OWY4dkJkK1VQMUNEbmZNMUZQ?= =?utf-8?B?SlhrYUMxYkNDNXBJSVZybWUra1hMYU40MDdqTy90V1dzZ25KMVhRVnlYbmti?= =?utf-8?B?bmgzZWx1QytVbUpzRm1ZR05aRHdQNlM1d01oTSt1ZkdidVNVc2JmeUhvYUpK?= =?utf-8?B?NXJXdUF2RjM1bSs0a041cnVKNFVzQ2JPcWRiMUZBWUNZdFBXTlcvYUhoYmdo?= =?utf-8?B?bWE3eDRYK0g3RFQ2ZlF2V0FFbTVuakVhYXM5ZnkzRzZRVC9sZHc5a3dNQVNt?= =?utf-8?B?cW1RcE9mdTFFb2NlREJxK0lxRHNlVkZwdUE4L1p0Q1FVek83Rm1UaUNCMUdH?= =?utf-8?B?S2Myc2dJdHZIaklyWlc1bXNmL25NeURERXMvcFZhUWNkZWE3YWE5RlRQcXN6?= =?utf-8?Q?XJHlzibm/j9Vmfq+ZsAPGmXTe?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea6a962b-63b6-4371-7c47-08ddb263d2c7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 14:39:56.6899 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cOmaaTKr0NMyiy2M5xHprhM+s0wGhAK6t92Df91x/MpvR555R+546E4QkTCsdIxK X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4172 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6DE9014000A X-Stat-Signature: yaquhxyk1e48ty1gdmt8d5115yqc9j8h X-HE-Tag: 1750689599-214485 X-HE-Meta: U2FsdGVkX19EivoNH8Yo/yY8Q+Tpf6z7WQTPyQ2ck9WCy5iuO3eFAMwn++pXHNNfw6CZFoyxwbJFB6GwBQlfFTpZwuoYP+ZqfLIYAOSwwnFWUvRT0EQC+/2MGTBfNjXAycw2PkZFLUdIFQnEb/qgHdZ7p+Vh+ubEfh9pC83EfxEKFz/237zuj8ILmuPxms1028c6wZ8QVbNmBCzvoNK1CW5xVqjfFjv1//3IQZv6LwjVz8aetgkh7c4rkqgUQVwSV5EsUqaLV3hMn/ZIHH7bULzuAasDTpX7gB+O7Ypw5lvbWRFcYGUOjW9Qg66PwfiRqOqBwaWq+8ncMCb6D7fuvYGnTCe32mJXwl2mV9j0AoO6EPZBwZOuQL5xrR2qQxEySsmiKgwCup+TS48GcfiLZ9GvpTRizSFLp6wWZJ7zFEgJ2UD3X6Tseop21ZuqT6Wz2e20zKUIqkXD5KiIaJsRtC0ZdJ5+07pQYfzDg/H405WO5CuQHdOIzPLktEqaqhyWyUrLpHJvX1vA3/jtDH3d+AIo+9TqIJ5WM13G0h9CgTUW4i69Mxr9twJMg2aBXU54IbY3TC+NL/1592ohayPRvgnr1yCBB2LwU3zyu7AesMi9c019eQSe7xxL/8BlNwe2chccW91xfmo4+6RxYmUk53069XtmpMId+pURetrVKSE8X17vw+piZi1YPUGfBHdZqEIJdQNzoSITKWCpQVnYxhJRF1mOGKMHa37OB3bMFV7sPES4gHDoez6W0PJFZXv60x6Zitn1sxTSoi/NYpq/80YO/nJ0Ca46iupdxplt4U4pI2dQ0deIXtdKQY7FkcyeXEAaClt90ORRZjypbtllDY2572j1Hnldm22m2dVEOB6ewOE3uqYySbvc+2Ne6gKBzX9Wdx7DfZP5oVUqEHNVXaGz0JxnqCpQ5aK7qK5pBImWfK1CapBucv7LEzEzpbw5j8HBBVIiUCi0eGLkIcw zQxTuC6i tRW4Ovke3ExZ5CbctuBlAI9QNEKV0fX6aZyli9wTmxU04td3cPolblz+GEToa9omCyMsChU2RlN4d1cw42CIfr0KqZuKC67EPQxkzL4swTyycZtV/6O/ROccdhQ3aJPRr9dduhjxnkUVX9NJrjWjLuW15p1A77kTu9ekvHkBU/xcb/7j/H01dTU+skKDc1H2mBZk2JVmKn/gqjUoYMcIvm3JrUi3Jp89CbigND/3Ezh9EJHYsGclv32+WOWSBrQ6ODIs90OZw6l1U4XDHguh9l15xkL63/c4sQ9dc9C48EJZVK/bpkT3mKO9lmVQIcsBwXy95a2GjvpFCrSJHiPZWkuDoTXvYM4DCCxln4h5Q2sYtVDkhlWdi1GcDc7AJc8fy0fD10LGODW+GduYP/M5g8GyqqrUZ6RVqSnrYWOphYn02p6ipCyt+MIipUueWy3h7GPcXP7FRxXEkgWf14DEDEHrtn4Y8HI3jF5c1Bvev0yqyrIq8SYt4x03hknM12QKYJnlqvaw7FCz6odtCysxJUUw8QZiMwIwxt9N8ebXJYxnJrOmiLfkWHDoxQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23 Jun 2025, at 4:28, Baolin Wang wrote: > When invoking thp_vma_allowable_orders(), the TVA_ENFORCE_SYSFS flag is not > specified, we will ignore the THP sysfs settings. Whilst it makes sense for the > callers who do not specify this flag, it creates a odd and surprising situation > where a sysadmin specifying 'never' for all THP sizes still observing THP pages > being allocated and used on the system. > > The motivating case for this is MADV_COLLAPSE. The MADV_COLLAPSE will ignore > the system-wide Anon THP sysfs settings, which means that even though we have > disabled the Anon THP configuration, MADV_COLLAPSE will still attempt to collapse > into a Anon THP. This violates the rule we have agreed upon: never means never. > > Currently, besides MADV_COLLAPSE not setting TVA_ENFORCE_SYSFS, there is only > one other instance where TVA_ENFORCE_SYSFS is not set, which is in the > collapse_pte_mapped_thp() function, but I believe this is reasonable from its > comments: > > " > /* > * If we are here, we've succeeded in replacing all the native pages > * in the page cache with a single hugepage. If a mm were to fault-in > * this memory (mapped by a suitably aligned VMA), we'd get the hugepage > * and map it by a PMD, regardless of sysfs THP settings. As such, let's > * analogously elide sysfs THP settings here. > */ > if (!thp_vma_allowable_order(vma, vma->vm_flags, 0, PMD_ORDER)) > " > > Another rule for madvise, referring to David's suggestion: “allowing for > collapsing in a VM without VM_HUGEPAGE in the "madvise" mode would be fine". > > To address this issue, the current strategy should be: > > If no hugepage modes are enabled for the desired orders, nor can we enable them > by inheriting from a 'global' enabled setting - then it must be the case that > all desired orders either specify or inherit 'NEVER' - and we must abort. > > Meanwhile, we should fix the khugepaged selftest for MADV_COLLAPSE by enabling > THP. > > Suggested-by: Lorenzo Stoakes > Signed-off-by: Baolin Wang > --- > include/linux/huge_mm.h | 51 ++++++++++++++++++------- > tools/testing/selftests/mm/khugepaged.c | 6 +-- > 2 files changed, 39 insertions(+), 18 deletions(-) > The code looks much cleaner. Thanks. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi