From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E919CC47073 for ; Thu, 11 Jan 2024 02:08:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 178626B0095; Wed, 10 Jan 2024 21:08:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 102436B0096; Wed, 10 Jan 2024 21:08:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE3F46B0098; Wed, 10 Jan 2024 21:08:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB1386B0095 for ; Wed, 10 Jan 2024 21:08:41 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9D73D12025B for ; Thu, 11 Jan 2024 02:08:41 +0000 (UTC) X-FDA: 81665396442.29.925F902 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf27.hostedemail.com (Postfix) with ESMTP id BDC5C40017 for ; Thu, 11 Jan 2024 02:08:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IH1ZeZrj; spf=pass (imf27.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704938920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qmEEcsA0fyriEKAX8TlwhNLaVQANlK3RwRydup4EB8s=; b=NOOj0mB+Nhdls5y8rKXLUQ0JM6la0idY9nEeoERIu/a40NVVKtIbfaFpZ0skzTHwPANtEN VgRL/aX3HkGaHI+UGpvckv2DspZNzK02k5olm+cdKnFcKNtx4YRMuVsHaL+KbmNJ3Sjqoj 0s7StOXi9XrGVmXgz5OCAMw2iIcm+zY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704938920; a=rsa-sha256; cv=none; b=VSqA+9gHKqgYKSJDMqsuChnOrfDS6xcEGODKWP+kL9jFwYPCW+rFOc5zYuaGAXeLiSdqyy zSKYamOgkyaUVveojXUeNzxV5UDZMrkKyv2jfjwaGPVVwtmdJjs5APKPRL7DuOvWNQYGBE bO1nUg1FXRpuq548hvzJqiu69WNwhIk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IH1ZeZrj; spf=pass (imf27.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704938917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qmEEcsA0fyriEKAX8TlwhNLaVQANlK3RwRydup4EB8s=; b=IH1ZeZrj6G+es7br9lTnFYyTgS8/NZ0PXntEb9/Z50vjKtlOktUF47bs/H13CEyBNEL2G4 Rtdm1BiJg+oE9KqACaizjUPUDDtYR5OwEN4CIDMNootAWjFqNFtLBWJ976MsR1q1AcffSr nHPjaiVp52YhioD9c5kbusjZypUg/44= Mime-Version: 1.0 Subject: Re: [PATCH 1/1] selftests: mm: hugepage-vmemmap fails on 64K page size systems. X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240110075351.f4b6f43e31629ddcb96503cc@linux-foundation.org> Date: Thu, 11 Jan 2024 10:07:58 +0800 Cc: linux-kselftest@vger.kernel.org, Aneesh Kumar , Linux-MM , linuxppc-dev@lists.ozlabs.org, LKML , Geetika Moolchandani Content-Transfer-Encoding: quoted-printable Message-Id: References: <3b3a3ae37ba21218481c482a872bbf7526031600.1704865754.git.donettom@linux.vnet.ibm.com> <20240110075351.f4b6f43e31629ddcb96503cc@linux-foundation.org> To: Donet Tom , Andrew Morton X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: BDC5C40017 X-Rspam-User: X-Stat-Signature: rnwgxxhyz8oto4ziscb99k4kt9xz86mo X-Rspamd-Server: rspam03 X-HE-Tag: 1704938919-715665 X-HE-Meta: U2FsdGVkX1+XTRs4U7S8yQNI8xXFjq+s1kuAyP7IsYvldwG6BXV2MvTJmV3j82qbQtN9+BO8MwTpZVdt/GqRIo3oc6eOV/fTj4kLRE4+RcEwDkbYKffTmh/57PlMdj8xdbpEBXS6MMk040R4BJAAAStmi6LHVc5MG1QR7E7KI2RRG4jaCM0w0XSyaBoxbq0HJyO3TM61MEOsJJWkV51zK+h36LAwg3R5JXvTY4LJBQTNvmhzRuhyyNLAehJyFuMXKH0PzgQCDsLH6YzfxQewhnV79rll+Pc41ccIU7bYcgCJ6neUsg4cXbarP996UPFq+XRVtaP43fH8Bo97ybf0UMcY+tmSHcpDdl5qaXEZZGL21PN6EYo6tKZGB3FK7uPwUm1BP8JBVZykkLpmIJv+U06GjiSVCwzWVOELOAnx04fBKSbrVg9XfMjzeFubJH1rdcVQ00JhfFfNdD4GhP78Iztq8d/XJcFxqbxbJ+16862GnP9bVPUFisjEXtPyDPhMfGmncmi8Qg+cbIbfnNsCALY0v+A+Lk0FCsaUNYeYfvEqUQD4cPVv4aat/NH5+KztsPGdp6uy5H/LufopI3mcm/Q0VO+dpNm5T/1sWnbCH8OaXquaZLUcf467x3cewA7ASvu133DbmJu3UWSt54qeKCdvyAm0NCnpFgUYOcOk6W3ONDIxifcMn44DJZf3PeAlUKI8GQn40BbLG55TIBcaYmVjtF7184bFw84Woyt8l2uweMETzR+4NTxpUqB/+LYaECLIE19kEpolqVqEP7D1WlVZn4Gxget4hZZIUXwcFhAiRxWqumRKiy8uI2CJQxvAtFuVg6PcyM5ybqknxrW72s159izBFCftXc3uN0gNnCqOf8YT9tr5egH8iKjE2EBBN/KPnTJbBO+muHYtxQ+wMvX6Fk0zjdlgcMQN3/jPwETrBl3kJQtqnREZt6QTqofhi0SAVPderaEsLOpmSSB b26bGBVw fYkvfVTy0fiEwmEo/9wycva6j4PYzyWFeFZMnjPDcKNS5zbA6SzWbNmOjW4zL2pVa0zMnpTW0Wc0MH8A0rh3XqqBDWHW68WrvcLDMR6IkSX2PxdjS0UAjnMLnsJv45mILssPCFdN/uvDfDOSf5mvl5QC6o7HEi9Q5L77zxpWleRt3XA5YnhzbaYVribu8sv+va6xI6xzSzHOZ4aMu29zah8zE5UlNYZoCwQqbs+lS0W5aRD8k2dXWCS1c4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Jan 10, 2024, at 23:53, Andrew Morton = wrote: >=20 > (cc Muchun) > On Wed, 10 Jan 2024 14:03:35 +0530 Donet Tom = wrote: >=20 >> The kernel sefltest mm/hugepage-vmemmap fails on architectures >> which has different page size other than 4K. In hugepage-vmemmap >> page size used is 4k so the pfn calculation will go wrong on systems >> which has different page size .The length of MAP_HUGETLB memory must >> be hugepage aligned but in hugepage-vmemmap map length is 2M so this >> will not get aligned if the system has differnet hugepage size. >>=20 >> Added psize() to get the page size and default_huge_page_size() to >> get the default hugepage size at run time, hugepage-vmemmap test pass >> on powerpc with 64K page size and x86 with 4K page size. >>=20 >> Result on powerpc without patch (page size 64K) >> *# ./hugepage-vmemmap >> Returned address is 0x7effff000000 whose pfn is 0 >> Head page flags (100000000) is invalid >> check_page_flags: Invalid argument >> *# >>=20 >> Result on powerpc with patch (page size 64K) >> *# ./hugepage-vmemmap >> Returned address is 0x7effff000000 whose pfn is 600 >> *# >>=20 >> Result on x86 with patch (page size 4K) >> *# ./hugepage-vmemmap >> Returned address is 0x7fc7c2c00000 whose pfn is 1dac00 >> *# >>=20 >> Signed-off-by: Donet Tom >> Reported-by : Geetika Moolchandani (geetika@linux.ibm.com) >> Tested-by : Geetika Moolchandani (geetika@linux.ibm.com) Acked-by: Muchun Song >=20 > I'll add=20 >=20 > Fixes: b147c89cd429 ("selftests: vm: add a hugetlb test case") > Cc: Yes. It should be a real bug fix. Thanks.