From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB8FC10F12 for ; Mon, 15 Apr 2019 10:12:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4CB772075B for ; Mon, 15 Apr 2019 10:12:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="dkiPsFxF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CB772075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9BB546B0003; Mon, 15 Apr 2019 06:12:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9404B6B0006; Mon, 15 Apr 2019 06:12:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E23E6B0007; Mon, 15 Apr 2019 06:12:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by kanga.kvack.org (Postfix) with ESMTP id 57C986B0003 for ; Mon, 15 Apr 2019 06:12:39 -0400 (EDT) Received: by mail-qk1-f197.google.com with SMTP id a15so14232703qkl.23 for ; Mon, 15 Apr 2019 03:12:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=YoMWmUaIuhPWO6FEtWwrQktpmL4pDG/BBVlcee6yDfE=; b=UXuD6AqyrEYjypjJhrtepXuWn5kuGUM23wDvaYhNpmDRorLYTVIp6HbvRH602jYDi0 8GZ6O/cZU+fiQ7JlJoQpjzfW+D/KkmoqvakHbfxaWak5XASDj17Sg2ZxF5NxZK8GOFJy dE9YIWos5+2mAXtmOgzlA6w+S+1B6KnRkCcgYL8b2gy0ZjXOP0Xgb4FXb4MXL0bXTVnD lrLcViAFjetp4WYQuJjDbyZtSBY6tUbR1H4i6QkfVcCpMMd9Tcol1txw1xsrmpWFnHhN 44jB0VkEFgSldNy5l++/U3X6OWg4k+d90JOGHjz88um6mfRphGMbRFssfseMYSKgbj4s 2ZFg== X-Gm-Message-State: APjAAAXosZALSRZ1/R1Bt/zbDJO/Esj4F7oG8+7DxZedWRG/8jfIlNIQ Day85hmZkqG/+TIBBrkiheX5Mo1nAVOGSZr34oVnmufy+T8i7hPsJGU8F2pqtWXuf3pLviaZI4l p/Qx1VM1CLs/HDfWXAJH9E4nIjFti+keXyuEhMjpVEUMFO6fYVTN1wwSILN8SOvn1xA== X-Received: by 2002:a0c:85a4:: with SMTP id o33mr59994906qva.105.1555323158970; Mon, 15 Apr 2019 03:12:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6hBrOb4gZtafTBvZAGAbMi8yPNncIXpLvrg6zzrSauzs6WlkhaMdmT2gW0VK+ii81kmWK X-Received: by 2002:a0c:85a4:: with SMTP id o33mr59994862qva.105.1555323158208; Mon, 15 Apr 2019 03:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555323158; cv=none; d=google.com; s=arc-20160816; b=ZLGHzxS1SV7uaNzjf6NQz0g6SzxPEz4ctbb+r7KfJ6XXLrF6sFj2iMtvv7S/6hjT29 aXL+SbE0rWgGpV8jcMn9eRMLD/O/SAdCdBblxnLuzAZnsY2i61q1cYTE3FgHlGPkahKB CiXZupfKXXPjUSOT6od2rbu6Ifp/Skhnp44Uir8Eo1Ihj6WiQWX6k343W5FfReiJBkx9 RH0Z8LdLVP/5nYgBzTfpqpn5GHl2PTd62RNlWPOEUQVTrog/LeHNxbFr082r8i6XpT2L M6VHrBSXmmk/hb4u7IdewYWmALx3FU3IH7vc5hDteAsfWbwjo0MD6oLP1ucG2g+KqnYL oqhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:dkim-signature; bh=YoMWmUaIuhPWO6FEtWwrQktpmL4pDG/BBVlcee6yDfE=; b=h9SxsCxQ6CLieteAS352jl9gCUUz8ZFGzZrkXyL/ubdxrpCmTCsgpnkAn7JsLStBN2 34XTGZNCz5OYTJ9Yxu62x9a8zARlEEaCxKdDnGx/KZ9s519cbv+iINkS8lG+TZfSTi0C sHyKh46ZVwLArTy017QZiiDyImffGGYCP8JVFKIyiU6YIjDTNcUK7R8RjqN0TosVlHCd 0H0Is7VZUhrhz+KDHx0Aif4hYb08mWxBMDYt8uu3IzVKz78CFXRMup9j3tGXYm6O4be3 rOSazOsh/X0EMWD8tECVi4V3PyJz2bK744SM3qpID5Ag+N5l9qo3GjLDlfk6a/TWZnLi avgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=dkiPsFxF; spf=pass (google.com: domain of william.kucharski@oracle.com designates 141.146.126.79 as permitted sender) smtp.mailfrom=william.kucharski@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from aserp2130.oracle.com (aserp2130.oracle.com. [141.146.126.79]) by mx.google.com with ESMTPS id g29si900208qtk.64.2019.04.15.03.12.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2019 03:12:38 -0700 (PDT) Received-SPF: pass (google.com: domain of william.kucharski@oracle.com designates 141.146.126.79 as permitted sender) client-ip=141.146.126.79; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=dkiPsFxF; spf=pass (google.com: domain of william.kucharski@oracle.com designates 141.146.126.79 as permitted sender) smtp.mailfrom=william.kucharski@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3FA8Ule131521; Mon, 15 Apr 2019 10:12:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=YoMWmUaIuhPWO6FEtWwrQktpmL4pDG/BBVlcee6yDfE=; b=dkiPsFxFARZHO8s5GhtIc9W+Ua/BB8ArL9gL0S4apvcmpbFv4Qq5c9ctchFDiwT/M6b2 mqa3kgf4ykq/sRcF4xmGL1mtLKZTeAoUdFCUhVS+EB3aswa7IuJEbp0Gq16PyICqTibx SjTX8OHfHCQJRNM63Ib74hA9hCVxFm/XT3R13vz7MFgxkq2F3kRNaCfQ3xcf9PMl1eyf Kn3HzmOKUYJ/K3MUs+TXxxRUQXuUNBGqBbJzNdFHHf6+8pIsCOCSnbltssuRk7Rw/+SW y5ZDZZ00HbckDtY+Fap94sV/ze7rlw5VPKZznkO/NwtWS1VHZ53D9m+bArDCVnECy2+W cw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2ru59cwvfj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Apr 2019 10:12:27 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3FACObS176437; Mon, 15 Apr 2019 10:12:27 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2rv2tu3b2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Apr 2019 10:12:26 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3FACIeb009910; Mon, 15 Apr 2019 10:12:22 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 15 Apr 2019 03:12:18 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: [PATCH 1/2] include: linux: Regularise the use of FIELD_SIZEOF macro From: William Kucharski In-Reply-To: <20190414091452.22275-1-shyam.saini@amarulasolutions.com> Date: Mon, 15 Apr 2019 04:12:16 -0600 Cc: Kernel Hardening , LKML , Andrew Morton , keescook@chromium.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org, kvm@vger.kernel.org, mayhs11saini@gmail.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190414091452.22275-1-shyam.saini@amarulasolutions.com> To: Shyam Saini X-Mailer: Apple Mail (2.3445.104.8) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9227 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904150072 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9227 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904150072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Apr 14, 2019, at 3:14 AM, Shyam Saini = wrote: >=20 > Currently, there are 3 different macros, namely sizeof_field, = SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets = use > FIELD_SIZEOF and replace all occurrences of other two macros with = this. >=20 > For this purpose, redefine FIELD_SIZEOF in include/linux/stddef.h and > tools/testing/selftests/bpf/bpf_util.h and remove its defination from > include/linux/kernel.h > --- a/include/linux/stddef.h > +++ b/include/linux/stddef.h > @@ -20,6 +20,15 @@ enum { > #endif >=20 > /** > + * FIELD_SIZEOF - get the size of a struct's field > + * @t: the target struct > + * @f: the target struct's field > + * Return: the size of @f in the struct definition without having a > + * declared instance of @t. > + */ > +#define FIELD_SIZEOF(t, f) (sizeof(((t *)0)->f)) > + > +/** > * sizeof_field(TYPE, MEMBER) > * > * @TYPE: The structure containing the field of interest > @@ -34,6 +43,6 @@ enum { > * @MEMBER: The member within the structure to get the end offset of > */ > #define offsetofend(TYPE, MEMBER) \ > - (offsetof(TYPE, MEMBER) + sizeof_field(TYPE, MEMBER)) > + (offsetof(TYPE, MEMBER) + FIELD_SIZEOF(TYPE, MEMBER)) If you're doing this, why are you leaving the definition of = sizeof_field() in stddef.h untouched? Given the way this has worked historically, if you are leaving it in = place for source compatibility reasons, shouldn't it be redefined in terms of FIELD_SIZEOF(), e.g.: #define sizeof_field(TYPE, MEMBER) FIELD_SIZEOF(TYPE, MEMBER)