From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947D9CD13DF for ; Sat, 31 Aug 2024 22:39:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E63B48D0036; Sat, 31 Aug 2024 18:39:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEC2D8D0022; Sat, 31 Aug 2024 18:39:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17888D0036; Sat, 31 Aug 2024 18:39:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A110D8D0022 for ; Sat, 31 Aug 2024 18:39:17 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 16A28141088 for ; Sat, 31 Aug 2024 22:39:17 +0000 (UTC) X-FDA: 82514007954.26.C23C841 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2074.outbound.protection.outlook.com [40.107.243.74]) by imf30.hostedemail.com (Postfix) with ESMTP id 5918780006 for ; Sat, 31 Aug 2024 22:39:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=eoSKAodz; spf=pass (imf30.hostedemail.com: domain of ziy@nvidia.com designates 40.107.243.74 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725143881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WHWykqseJO9iSgVaZVMgIIqOaUTAOi0dxrahzhJNpCM=; b=OzaefbSElklScKBveoler3EilAXFnGqhc9xqtWVoFHx9LVxXjx2azQbIzPj37t4JpWgRWu O67KRzASVX9N4xamKsLP6gkXuMS3chdpJyeg/x9aQuHb9rp8Ts6Ek4KQFShX9mfkQx7O9+ Qtuvty5tkFpenQmLNcNKgr1NGw2z8bk= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=eoSKAodz; spf=pass (imf30.hostedemail.com: domain of ziy@nvidia.com designates 40.107.243.74 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725143881; a=rsa-sha256; cv=pass; b=gMlx925Gn5StUU4kT+W4WreQiRtpfNsITcdyi9beGUFPgwsdH8COaBbHDr+QizUsf+ErbX ZcEPdLsB3Pipu6WvDg2ZIW4Xe1lSEAWg/yf1Zl2WRwsRLkdeEQzPRh6360kEm0Xtklio6s knKdTfieco4YjFScl7JPOCOAwT88Xlw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xfzlERiXMmbpi6D3Izz4z6S2O7Jwd7iAAFVSQJIDy9Ns7G9y8wzXOy2/NqfDKO5Akfjp+1antOnCwYzxZOlRySwibDj4VMlHpVNlw+HUunF21F4OBAZHO+9JXCvG8o4SSx106P9mUoyMRQs9Tb3RO5WCFzwWSIEgmvih2UZn4une9MSbnLHztRz+fNRWx7D32Xx58Gx9vJUhGuhlgZ+ZfDPWRzS8qupUYH9xtjMiveuajQNPyrlq7x3GU/h9LIgWn/u8QEWCnEpnx91h3hMFzH5vxjJYriUS4Qnvvy3gboTqycNl5TCM+HGsx6I6NRH+9BvDAvIruBCbSjydiVJBjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WHWykqseJO9iSgVaZVMgIIqOaUTAOi0dxrahzhJNpCM=; b=CLwNggjcI5bBsxWyjA5n0eEnywle/LqrCBlwc0Aw9SymWpkNzCHZg7iEXagHRRwgrfrNUzshscC8Fq+TDIUZPKSWf7zlTFhVL9YyPacQSyRSSzBJ6qHR7w5t/AGjl38fDbg/opTsNO954P1g5GK/gxr5PdfKH8rCwcH8haosue/LMRvIueW6IptPLT6AQrpA6bCrhCseP4Kd6MrOhcbLeimSUCWaJusF4LJoTyL2Te81gJa3a1e/5uKoPEA1e9IjqFqpxXpvfuaigFOoBd+BqSDdQ410Hq8pbbanC6gV62X+RWa/qv9wt8+PDDq2e/6KxR0cSzLHcGb9fmPWKsrqng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WHWykqseJO9iSgVaZVMgIIqOaUTAOi0dxrahzhJNpCM=; b=eoSKAodzxu6o6rlyU3cKvuF7e5HTN9u1ftP4ffVZ++rCKiegziaaHKMaYyCXUpjuB1FZtiR5URumnIW3CLm09PGo7HsVHQ3myyg5m9Wuv0kBK7QKZedj+++NvBitzKcsx+jSn09BLcwp05wyIueqIBpcg/46H37h9SNL9yYm8aKEkdaPq6Lg22aA5K0Nyf7tj84O2Mlv5Ihb5levp8U+p7rYmrjQ/St1i2ArYYgUYktpkw5ukJD2T0pz5pJIHdfChd44LQ8eQuIEMojDNh0C2TA1K5i5JonhKwxmgpKwjdujWoNIIA1QSCBhWqp1dau1cpghWVADkr9ydq5WfK2YLw== Received: from CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) by MN2PR12MB4095.namprd12.prod.outlook.com (2603:10b6:208:1d1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.20; Sat, 31 Aug 2024 22:39:11 +0000 Received: from CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f]) by CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f%5]) with mapi id 15.20.7918.020; Sat, 31 Aug 2024 22:39:10 +0000 From: Zi Yan To: Luis Chamberlain Cc: Pankaj Raghav , Matthew Wilcox , Sven Schnelle , brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hare@suse.de, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, ryan.roberts@arm.com, David Howells , linux-s390@vger.kernel.org Subject: Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks Date: Sat, 31 Aug 2024 18:38:57 -0400 X-Mailer: MailMate (1.14r6064) Message-ID: In-Reply-To: References: <20240822135018.1931258-1-kernel@pankajraghav.com> <20240822135018.1931258-5-kernel@pankajraghav.com> <221FAE59-097C-4D31-A500-B09EDB07C285@nvidia.com> <2477a817-b482-43ed-9fd3-a7f8f948495f@pankajraghav.com> Content-Type: multipart/signed; boundary="=_MailMate_73D40388-9FAE-4DA3-A9BE-D7A35598BCD4_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: BN0PR03CA0053.namprd03.prod.outlook.com (2603:10b6:408:e7::28) To CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYXPR12MB9320:EE_|MN2PR12MB4095:EE_ X-MS-Office365-Filtering-Correlation-Id: 33d80965-7f89-4b7a-5995-08dcca0dbb65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0+MWAutNT5JptpDEuoiOVoZYsSktgJklNCYt5wVYzFPjhFyOd4LToL+Tzxuf?= =?us-ascii?Q?Xtfgm3DuSrTWht4Gsd87dtHOZKGsUXaCpmb5TLyY45/ifH7dd1xym10oKLlc?= =?us-ascii?Q?u35NTM7emXBbw/UkW0E1F0M+enrjYiSTChB2uhywGxd13ThPOBJ6hkZJIxpu?= =?us-ascii?Q?A/PgBUsu0+9RfUlpmqu2ncZjnNwCwgRHvjstI9B4OXjjEGG8dDczOy2Yl1hi?= =?us-ascii?Q?Z6QGGY8BVo8HoesPuwuS+lJFjdqHBxsuFiZkB6+nlY+1kqbxp1iLHyHTsSqw?= =?us-ascii?Q?WnBIJZd/2mO+XNhTBBnEnJ9pvcrBHhUsKP53hVs/gMurhPDqNbkSQePiQgtI?= =?us-ascii?Q?IuqeaytZ+V6oHhBswhhNv66EE8bqAlnv+cfMfOekHLOYLinHjgRd9IvZA/Ks?= =?us-ascii?Q?Ok1JQhg5vsqvMILRXFPtCjwauDOLqEvxYK1gNbqyE4YHgCHUteQHRSn95lhG?= =?us-ascii?Q?amPGbAjTlP0Ti2RO5bYcMk3SXnHdGAFm+aNeYlKSB0cjVr9IQxG5LW79nwHD?= =?us-ascii?Q?WhPiMoDOKKQg9cXKRcLYnGu7P41z0Q5q5xU38lTo6l38bEbZIIbrARTDtcIX?= =?us-ascii?Q?Npnp3lUx9q4oIF2/DO44we6Xl/WLNXQ8zfQOxhCETWXqnkYU8uU0CS6fBFrW?= =?us-ascii?Q?6TWh0irB7KboRIzcZzO2iRwGKQxeXLOHm9GrxVW5jE3sEtEmviT4uaWgOyuP?= =?us-ascii?Q?M4beD2Rh8QRqW+VFT7+1i7CJ/4yfFOEtpnu3QjsuF1HqXqETMcouVgOgLQHK?= =?us-ascii?Q?GSZyfh2HX7kGz8vdRy9pStweZdilnwEJ+tUkaHTZSIWwtpFzhNrz6XpJbwyB?= =?us-ascii?Q?8RZchN2X9aPoevaiJTi7G29vLupFB5pxWVo8mJrZBy0rxDJP/yU+BZ1Ihri5?= =?us-ascii?Q?OhePmxFkFBOWN4tE6L+ujFjpcv4Y8Nfstu2ztWGAD2I92TLzhrrr0R2ydxvv?= =?us-ascii?Q?X74fJljpMHZhKCIn9MOuElswEL4iqO52BARQGY28pdaCLJc2j/oi6Qsqn3rM?= =?us-ascii?Q?F9tdxyK8pdgtvQ0+NeHCKmb2rCK0mf+BB+uEcyCPyEPc9Boowrl31HBECQOr?= =?us-ascii?Q?7MvPf2tsHH/ArX+2z/Sc2y9IS61WQKe17h2r8D6unkhKQg2irPJpdosb7txH?= =?us-ascii?Q?0whkgMXozBut9Y0xRAQ2Tq122xtaIOg2ik/exkd7lVrKyiT9+HtbZHQQ+zCX?= =?us-ascii?Q?QgY8vgjUhD3iJkV1DecgayXa7J/dibOpM5eWNm4GyYbk+7cMX9D7mnxFJo7C?= =?us-ascii?Q?rHJDFa8SoaNry1sxtAmpQDddCJPLP3z+lLBh69Drz+caEf2cegVHfb/YHYUn?= =?us-ascii?Q?Xe1mGKmWJQznJ+SbIdfsw0AuJrMRAIQUP1rCOs3xDeSxcA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYXPR12MB9320.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GEhp/KegyyfgTqKLbILqBhvC7Zn/Ulk+B+wxQh0rnJlHAB7Cokin+WeTS294?= =?us-ascii?Q?A8YwnWZcO1bwskdidCZcBdH+iiVocFgdPAPaarNcp3/bQL2djkPaiq/IIBRX?= =?us-ascii?Q?IuqIVilwzRytpomtJsMGDRwdmO0FkqBFbNPMw4XKRV1IuF0knFYK4KhfBkV9?= =?us-ascii?Q?WyigZnfQ1biP7Td2fj9/QCykwUnzvENyJKRHJ/PZAJPPk6UWj0NpMYP2FRY7?= =?us-ascii?Q?7sfkHW9kXi0ql8MN+hv6AgVKYx7Z9ArWLE024L7/1nvSfZHqzEbfUfx1KH9W?= =?us-ascii?Q?okKdeo2rmaPBDs8To7BiJFaZxVdrqHC7tsNp6if+LvFsC1bTfu2fHHgPSMAP?= =?us-ascii?Q?c6kSz3Mb27w63OylzOn+KwR5FtA4PmmVxM1LOggWq//7giCsiRGB151g8eXw?= =?us-ascii?Q?h7FXIBbR3HYmkbvH8O8sjup6Jzb4A7QZVKLs2/7tLboel/uKyTgifnMzcJ9L?= =?us-ascii?Q?Ni4NGQYezmXW/gtEczOCyJd5j80uAP23tLcvXwmgyvBb97PtZFuiJBEE+K4Q?= =?us-ascii?Q?qq9V4vpEAElMGlHndLIDxlVN1vQ9lm+soAA8xqy1zQwWjc2d/z/OuMUyNGFT?= =?us-ascii?Q?o0r23D5ZX7+MVw3isyQzu7slOAqGbImdEsZsDu45HzWN+sCuU6fMD03a/RGG?= =?us-ascii?Q?8LJ7Xu7JqLazKjr8Mgpm0Tn2lcEqQ2hS2SLn+aT7Oouw60rOpLFbSleNFQ92?= =?us-ascii?Q?iIYbKjZi0TGmYpbiJOXQ8w94BPZfIhxOnUa3wuxK79H6BlM4T3Y5QRpba5c8?= =?us-ascii?Q?d6hapEsCjN+FaET7IxLUuSL0uutNcgk8954gMFLXnb+x42rTUFMN+anybhKX?= =?us-ascii?Q?1rX9xyJYYUOoi2rjnIwUHuoi/xD6eiYBbwKTDGuNu65ELxw2z39U6Yn3MmFI?= =?us-ascii?Q?0AF44lvJglmujXT8TkkT5hCgqplsRo3GwA3HhMsYYgzHPwjVSYF2xsvD2Fb/?= =?us-ascii?Q?pnGglNbBQhGqotRFK7e9d5K7Z1/PxXFo31+7IkcHjprcn8ZZcYHpFeooAuEK?= =?us-ascii?Q?u3S7vgrr48nl72+e+mTM2lMYSm3kj5XpYUQWze8y9WdexSaLfSg1OxET5LlR?= =?us-ascii?Q?/QgO4sGmaZr/XC+LjGRQNOii0hRzUqIZ2rIVdqY4rYSAapFcHZyJRRsitYK2?= =?us-ascii?Q?FjRbqVJtQSAUsCe7ZelR7vs5kGeCnpFrFn9+Rrte12nOM9Eu92SuobN0h0GR?= =?us-ascii?Q?LLRTq2KjlHN43HjqJJiJp9eioeensvsJ39ObngciW19yfcAz4Y3zXjZC+PO5?= =?us-ascii?Q?995jwUSXwunaRfO6ywq25pjlqxg/8eqaZiLLv3OEFIUeBMvPZ7VHgOyQZjWy?= =?us-ascii?Q?U7ZtyQClB/YYp9+SG3LD6efv2kezcZvobsWghOalnCZ5jv48icfDKBt0nYzD?= =?us-ascii?Q?oUgylSYYynJYRTFzNLgH3YlmvJhXJ03YGvxHNY+2ZItE2p9XUTZyr8lSG1TO?= =?us-ascii?Q?43fNy2a+RaEIsjfNT8D/mhLfIEheew/wcuAtl5rQtLf5QIvqDw0OjbadKnn6?= =?us-ascii?Q?lt+3V4+Ws7++fcZIREfN3Tl3Rm4Qu6gaKrIrPKFwvCJJZMyPdTk+3r3y/kLn?= =?us-ascii?Q?Oa7/kvmApZQUW0yXaGU=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33d80965-7f89-4b7a-5995-08dcca0dbb65 X-MS-Exchange-CrossTenant-AuthSource: CYXPR12MB9320.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2024 22:39:10.8400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jUWisNGGx+1P74eteswdYG5m+zcs2BayW0/t+BQF3a6RvhMpIkYpgomnsA8wbH3Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4095 X-Stat-Signature: 4d6mfnmtjhbz4fszgn155muni8u6d86g X-Rspam-User: X-Rspamd-Queue-Id: 5918780006 X-Rspamd-Server: rspam02 X-HE-Tag: 1725143954-612695 X-HE-Meta: U2FsdGVkX1/PmbavPEpeb0LpNCjecIGkd3kBXOCYE9IJxXZDKl9b9pMdQp9wQ1j5VryN3iSBbVsC5PnqGuiNZmSvFCVAHVqkp37/LGo9bG7wbZxYaAfkFYL/nzxekF673EYQn3CRdGZWYq5C6TwjoHJDDIwvhQDnrdCbP4sZBtDpexYQAOsXZiCqVNsl5D7bQ+mO+hecZWRpjyf4THiaJ8vsAjo7uO6bGnlcQE5bR1qPt4eQWgUnzxphVJkUgld7Coyn3Wy5CattH8i9vpFK0xSRHWCqmmtTjdVDo/TueBGMVadbtR820af2ERlp/0qj2yikPUSgxjWooA5EpZnp8DPO0O7TjjTWwgxaZlEp81UmeJmfgTJ95ZoJvxDPZCAGoNNGjLks4yg6D3K2DcrxkFK9XimjoKSeB1klTaTN8L8GlWHtsdbOm8vg3H4rdHg7SS9dSbBduBRzKZphl10zQ4W32dQQj+WxzBgiGrzsLHyYmZihP0A3alkCqDE7Liw031KOwhIBWpwV8mSx7z1/+f+rQdxn+mnVcP21nsAMDc5tJyO9Ue0it2CF3cgu7JkFUZOk9eXlx8r8P3PhmPqkAnlPVrG4a6gMfY7MkhDmZSz0oQioJLumG8nyw28Gdo14vCT1N1LRL8Hx2J2Yky5tfLfi5pT6rM7GNCL27epDTz1NvYPPkrwG6OzsAKlZ+r985gL/s1GSQQv8vf3YV4xQyacREg9H4AeoRkno4JjSGCtBcTj8oVEp4VqY3PiUjCsawYFRRSWSa4nlUGah+nMCiWQjN4G5y5tKbcHPUOpmywGN8KfKuu3hjFGZAbtNBlfk09jr6Fa/Pj6oAYkOK1VLFEoO71njxLI7yk1EvIGXIdgjUIcTXQzpRO2+zKAh05nW/lh6c1Mj3gIn2XZMVJJT/Q1Td10h8VXprPS08KdjxBbyU2Py8uzwBHNA5jp/DHwCjueXnaxl6+FIP0C8ul5 U6I7I3m1 DtG2hm3MiPZ+uvG1bKRcFqyvqTKPBjuHG90PcXCHV+Y7oRaLgVzmSV/lFNgOaFnicrQvYSV5DVFxv1j820jGoVgDBPuLyxcnB4vot8R9T3FbRArdJ8NJgfKEVJwLE++Um7iXrM5Ngdlu/nAnu8h4uTaK8M9jmkyDDFY0dM+sYS0Gx65pWVrAkIhGPe74KeRCDXKcuYZ45PxkPTUAYBABmpSz3yXk7zcWQb81BRQl5HeLv2u9Pi/68yZnNulm/iVRIgobgVavhRxUYGmwp7yH1EDYMA3JoLANli16QeBFt86vP8eF4ofJzfwE+AytehVfQg+wgdsMuAwVoA9QLKfulHTw5umzookbcGE/5Dc7+vIpMXxY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_73D40388-9FAE-4DA3-A9BE-D7A35598BCD4_= Content-Type: text/plain On 30 Aug 2024, at 13:12, Luis Chamberlain wrote: > On Fri, Aug 30, 2024 at 04:59:57PM +0200, Pankaj Raghav wrote: >> It feels a bit weird to pass both folio and the page in `split_page_folio_to_list()`. > > Agreed.. > >> How about we extract the code that returns the min order so that we don't repeat. >> Something like this: > > Of all solutions I like this the most, Zi, do you have any preference? No preference, as long as Pankaj fixed the "if (ret)" issue I mentioned in the other email. -- Best Regards, Yan, Zi --=_MailMate_73D40388-9FAE-4DA3-A9BE-D7A35598BCD4_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmbTm4EPHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhU+nEP/AmoC/amXPqf6fwTC+5jxIXzhwon/NaukB3G ih427Yo78TD0ttF/oTleU61sHdVNaZBmlQfzDo5U6s1H+iN8/iSB+38I9VUvBr/H hcP3mJqVwC8C3y8DlAb1wTrymNVkjVbaOFqingwiyONBYAHXHOcnagTgW8yY44m3 awqczARKvgldZwSHtSSiHtXpC+pNZb7gIOfYr7vdoqwDTsJgwJfTyFlosfchMnd/ RRaYy3mJlqGVL3JQwKZlXDPlbH9T0V3bK7i8VNNwn0e9/CCcZjS3L4DvbdUY3D2E 0/ToG0g8ObnOXVCCHHIQTQC39Hy+iLodOqBW4KUFnVClcrNQUZ5yh1C2/I1Cim/s GZ8p/runk6ylsB92F/KRmM0eTp1Rg3i+wOGDpMGVtwmOkkUB8cENhgykKBKpvGRU H1lgZXzoNnyyR33bmV0vqtBNQQb1uII9liA9I90FG+J+w8qFyWTHZAxy6OvstFTL +ky1CZx//g1w7t101zE2qQSGtOyUbAzoyIY6pKCGqS1N3moNOnkyExqq3z+YwRI8 B5PK99GLMm3ZmI9p6X6p5SZY4ZvSZMmf6Z0Kty//NjGj41GkSb63RnKpSdA9aALw QgtD8v3KNPj2WfN9/nEHVghkDewkDdN4g2nEe42uXs2RThjdDfb4cguGnmtwgV3f 5jJ5YXPA =iGsz -----END PGP SIGNATURE----- --=_MailMate_73D40388-9FAE-4DA3-A9BE-D7A35598BCD4_=--