From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A4CC47086 for ; Tue, 25 May 2021 20:35:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A8F526140B for ; Tue, 25 May 2021 20:35:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8F526140B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 02F0D6B0036; Tue, 25 May 2021 16:35:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F21BC6B006C; Tue, 25 May 2021 16:35:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4D0A6B006E; Tue, 25 May 2021 16:35:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id A32506B0036 for ; Tue, 25 May 2021 16:35:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 317AC181AEF3C for ; Tue, 25 May 2021 20:35:40 +0000 (UTC) X-FDA: 78180909240.25.EE7AF6F Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2053.outbound.protection.outlook.com [40.107.236.53]) by imf10.hostedemail.com (Postfix) with ESMTP id 8B3A040081D4 for ; Tue, 25 May 2021 20:35:33 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KLiHDWNGW0pi/YCnvNuR016rfDbM0RqrImfQQf51dN4YDkuJt6SIX1Wqp0+jAJS4REiSMNcYCpJAWuuu5ZLrKmIzhTXdLW2TiKgE6Lz3Mcbt1X7lZKlNfv8C129ciJipwWQ0dWgE1d8MHyNWCrmhuEYVWJc9q8F1KNUZY6Hseq55W2ZFsXuNzT/btqJAnpEzPjLq55UBaJtXuuSfQgH+4sTKD39FA4YJhViDxH+BL+pm9qvruC3wRCbuNZ/IhAw1dDfV5VLbDcMJQx3FR4SOlyK+WwnZMJqIPfnbYpBJuYD2L8vnIc/3RqZo73MEhKM65Fegu/lBfof70S6O/Krv6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MyIlcjAF/KXn1Ycw02DC6gRHVU1ZOTRceyRp5JVsuro=; b=FEthkEulsHPHvhHJk8CM1mCWkNYgvhTY0/tPeTnZMGwikW8rMK/JxHV33YL7KCyH0lcERwrBDEF640xWarFDpfnT49Fx+KNUXQGlnj2o9x1TcanNWivMlEq9oZC3dhvLGnMo0pSig7/HZw9STrd5CfRLywDcrcD08jJLQqSu4OGwddd3PxMrSpuKBUtUqENwerfuJeGLWAylkFIigBIkE2VxQ4h0hwvBP/3kjTZqB+AkYOpANp+eer97m79ds0j25mhxblOXSWe3BxYF3RszqGzX0Lkx0x6iXMqess/HAP+2JlqqoH8s/qzJdNJ2ghlAW2ONzGgA96RLAgamNwF2Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MyIlcjAF/KXn1Ycw02DC6gRHVU1ZOTRceyRp5JVsuro=; b=QM0e88D+NDQkDyG1/BiDHV9o5IckCOUskYH+pbPOCcZ8mUHFRpXYSb4++MjCac2bpHaPkYEIBJK618QrMpMb574w7lEb1iBQM8FrLh2wtQmPfr/prY2Q32E/zvRDkG7ALWM50LoUN0chDC5smBBSFiWkyOmg3tqkvHVSqjoaABWsSH9JTZolvfReskoDJAo/2m/sPZoKgenpM5C0u5X9kDRf66hDYrEuYEjPnW8EyIq3ghvjWb9MJpXR5e+L6PU7vGdRxFydgMnzOOxc8saZRouO5Fq2AL07NAjEvP9pp3A9sZK6FsGroY8K2tmGm+a9jPlZloveudWB98BqANeR4g== Received: from BYAPR12MB3416.namprd12.prod.outlook.com (2603:10b6:a03:ac::10) by BY5PR12MB4068.namprd12.prod.outlook.com (2603:10b6:a03:203::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Tue, 25 May 2021 20:35:37 +0000 Received: from BYAPR12MB3416.namprd12.prod.outlook.com ([fe80::e9aa:71fa:d0fd:1a7f]) by BYAPR12MB3416.namprd12.prod.outlook.com ([fe80::e9aa:71fa:d0fd:1a7f%6]) with mapi id 15.20.4150.027; Tue, 25 May 2021 20:35:37 +0000 From: Nitin Gupta To: Charan Teja Reddy , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "keescook@chromium.org" , "yzaikin@google.com" , "vbabka@suse.cz" , "bhe@redhat.com" , "mateusznosek0@gmail.com" , "sh_def@163.com" , "iamjoonsoo.kim@lge.com" , "vinmenon@codeaurora.org" CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" Subject: RE: [PATCH V2] mm: compaction: support triggering of proactive compaction by user Thread-Topic: [PATCH V2] mm: compaction: support triggering of proactive compaction by user Thread-Index: AQHXS+sbP7JG2jAKA0uVYnCsOKlt46r0sTFQ Date: Tue, 25 May 2021 20:35:37 +0000 Message-ID: References: <1621345058-26676-1-git-send-email-charante@codeaurora.org> In-Reply-To: <1621345058-26676-1-git-send-email-charante@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [216.228.112.22] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2459213f-bdf5-4a5a-4092-08d91fbca7a8 x-ms-traffictypediagnostic: BY5PR12MB4068: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /0aVg1IJp1zk2Gq6JtKYra2JequUGu+n0k2guup25oCzA8D52ea/9htXXsVXcDfln2evlPdsWBT0xZXkaw73xCS6Df0iAf8o6pS1ZS60ATsRM0aTxU7C96NDdDt4bS+/8LLssZkysbnCpQKdKnKkrdsoBmWV+P667iXnNBphvsdnnsHO6rGS5QpWBmYyjMOqB4QChc8qk+k/Y5+UNz7XwAq1a6LIfRrnK8XZZfEFYkT1+0DmDw+71rrMU05TB3yesQQMalObRExGUV/xSTuPnJccoLmcoXzW24eDvsNAy5BsjxRVAH55ggUSNUuxgf8B3vheR+cWNYK/bJyYUHM5ubX7CJK610dXVtRLLSWOYwY6FVTEkpUdvihrQTcZOY+69ccaYksN2BF0k7qlOWckVPiyfAYy3QpBOk513g/im7EQQ4H/IYn8Cc8INMmAgi4aUwToW7aAF+pQkYzuT99vFGtrQFlIHeczF8NlQHgfgPCMP/ZW8mg6oZW2FqDteW18NKRdhbgJg8P5TWalUpD1uLcCLwaEsEgXKESmh0hrfttFtOE1TZtcUEXxs0ZDqNthc8JEg5reexQ1ewvS80O0uzcuH5Uigss7wxxnWysHIzeUhieJH5SmHdrCEcbtBM9V3a01Vdyd+hVaqjVfjp4kKA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB3416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(376002)(346002)(396003)(136003)(71200400001)(5660300002)(52536014)(33656002)(7696005)(83380400001)(478600001)(38100700002)(7416002)(76116006)(66476007)(186003)(9686003)(2906002)(66446008)(26005)(4326008)(86362001)(122000001)(66946007)(66556008)(6506007)(110136005)(64756008)(55016002)(54906003)(8676002)(8936002)(53546011)(316002)(921005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?H2Uko9VZluZDXbtj9xtJSXMnh1U1GA3NbZzGvZ+jz1pKxlY3D4sKqnbb2cyf?= =?us-ascii?Q?xavHHVm5tlEbsPCBXkr3i6cTBMamqST3RfvOSjBkLLjzMv7OEu92P+Msdysi?= =?us-ascii?Q?wwIpghmAVuMfBnIOPs3n0rGHZtu4G6P9BG4BokrtKpJVcYNLiSw0vKZyFkre?= =?us-ascii?Q?9v4oPOwkA6dEhA3K4gYPJJJwALtoHena9+8ZpoE90q20zoxNheZWV7tx+jrz?= =?us-ascii?Q?LzmRiTueFrWZrzKdmiz4QQT341xnrrPjYdals87Axx8GeDnbh42wG+Tk51TM?= =?us-ascii?Q?YXaKpzTUq/zfcs2P3Fex/CVhYVELGPFa6nTURI12IMhVZDYn0YRRwNYN3uxO?= =?us-ascii?Q?sKMuRs4w0r6aMbD/zi91eIIqPblRrPKQLu9at+/LK8Sj+jlmBGjkCm68iplk?= =?us-ascii?Q?wmjoknacE9dI5CUGEGyER+7GEegsGnNuuTFc9YWlSegffpE6DXKuCMnnKRW8?= =?us-ascii?Q?w8Lra57/bF1PLZtMecPJmEbdQ2rs6wXEZiUOoqCqSJ07ARUKImliDppNg8Sg?= =?us-ascii?Q?Q+OwIIWZBRh/JU5BY0jWbQewCCyXe+TR5obkuJUOdOgnIDYpqVoJGrANu0Uo?= =?us-ascii?Q?fyVtvuxo3FJ2m9OKyJnpirhFw6eqv6qDy+fKN19EJbyyfrO+rwDXu1Kx8Y+x?= =?us-ascii?Q?fE6GObeU6xvyKdyHd4V5kqf8L9AMk9zcpEdF1hePMiv6nxeSI5aEIkrEHGxd?= =?us-ascii?Q?5PcVDwF5lwGijUSTNF8k0chw+z4le22w4WC5AUHBzOXHlo8IPLet2+593B+k?= =?us-ascii?Q?fM4A8Jhnog0XukBNVvqYdv0/ZsUi7Ci5EKCtMC5YGgToffPpWuK5wWBQgvs4?= =?us-ascii?Q?JZjDQumTjgmiyBkcoIi3uAVCetqS0EpvXKG/NRAXyBdN33LzS11L8Lu5muw2?= =?us-ascii?Q?3Ct5PaWZG0SvfEZNRs/jLWyVX176ctcAii42+TVMNsV8J06cLdErKpm1cGh2?= =?us-ascii?Q?dGTtSKQcUcox/f2hvZbxrITshGhfh+GZSU16d7iJnBcWwZpheILvRnB/1+rT?= =?us-ascii?Q?Zx8GZXFPIjzt3OrlXeyDj90gRgQu27RD/thexoKGrA0KGWZT/hknOawgPaI6?= =?us-ascii?Q?WgpMc1c8ErYpy3fIhrb+sD/ao59faVeFju/Xcw8Vr61SP0fcMjliVD00rXJF?= =?us-ascii?Q?03s5hGA/Do+qTPLiKxGkpfiPWFesHygnnN5wJA+MvvRHN9Oy98buXFBYGSoQ?= =?us-ascii?Q?2ng/F02+ieBe8PVr73zFT/Le/FXSqVvni6yGMsG42qXqIGOdfnFlDWoeUeKO?= =?us-ascii?Q?nqJTSOijr3gangHnw0Zjk0BcTqoXRAlR7/vV7SP3+A3uyS7gIzW7yv40VZFd?= =?us-ascii?Q?JS4=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2459213f-bdf5-4a5a-4092-08d91fbca7a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2021 20:35:37.4871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /Ihzdb1WvtHS7N6oh5ASA+sVSPQ3M5gb1+HG9pOTI+KjIuDk++6MqePTd+PanKA7GjYgccqrghoXcFC99P0Xqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4068 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=QM0e88D+; dmarc=pass (policy=none) header.from=nvidia.com; spf=none (imf10.hostedemail.com: domain of nigupta@nvidia.com has no SPF policy when checking 40.107.236.53) smtp.mailfrom=nigupta@nvidia.com X-Stat-Signature: 9hjk39a9dhx1cgz7rofbe31eb4ige97i X-Rspamd-Queue-Id: 8B3A040081D4 X-Rspamd-Server: rspam02 X-HE-Tag: 1621974933-626166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: charante=3Dcodeaurora.org@mg.codeaurora.org > On Behalf Of Charan Teja > Reddy > Sent: Tuesday, May 18, 2021 6:38 AM > To: akpm@linux-foundation.org; mcgrof@kernel.org; > keescook@chromium.org; yzaikin@google.com; vbabka@suse.cz; Nitin > Gupta ; bhe@redhat.com; > mateusznosek0@gmail.com; sh_def@163.com; iamjoonsoo.kim@lge.com; > vinmenon@codeaurora.org > Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; linux- > fsdevel@vger.kernel.org; Charan Teja Reddy > Subject: [PATCH V2] mm: compaction: support triggering of proactive > compaction by user >=20 > External email: Use caution opening links or attachments >=20 >=20 > The proactive compaction[1] gets triggered for every 500msec and run > compaction on the node for COMPACTION_HPAGE_ORDER (usually order-9) > pages based on the value set to sysctl.compaction_proactiveness. > Triggering the compaction for every 500msec in search of > COMPACTION_HPAGE_ORDER pages is not needed for all applications, > especially on the embedded system usecases which may have few MB's of > RAM. Enabling the proactive compaction in its state will endup in running > almost always on such systems. >=20 You can disable proactive compaction by setting sysctl.compaction_proactive= ness to 0. > Other side, proactive compaction can still be very much useful for gettin= g a > set of higher order pages in some controllable manner(controlled by using > the sysctl.compaction_proactiveness). Thus on systems where enabling the > proactive compaction always may proove not required, can trigger the same > from user space on write to its sysctl interface. As an example, say app > launcher decide to launch the memory heavy application which can be > launched fast if it gets more higher order pages thus launcher can prepar= e > the system in advance by triggering the proactive compaction from > userspace. >=20 You can always do: echo 1 > /proc/sys/vm/compact_memory On a small system, this should not take much time. Hijacking proactive compaction for one-off compaction (say, before a large = app launch) does not sound right to me. Thanks, Nitin