From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"david@redhat.com" <david@redhat.com>,
"linmiaohe@huawei.com" <linmiaohe@huawei.com>,
"Huang, Ying" <ying.huang@intel.com>,
"songmuchun@bytedance.com" <songmuchun@bytedance.com>,
"naoya.horiguchi@linux.dev" <naoya.horiguchi@linux.dev>
Subject: RE: [PATCH v1] mm: migration: fix the FOLL_GET failure on following huge page
Date: Sun, 14 Aug 2022 06:49:24 +0000 [thread overview]
Message-ID: <BYAPR11MB3495AC9B3F989A3462053C24F7699@BYAPR11MB3495.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB349546A36F2AE9C82E85EF71F7699@BYAPR11MB3495.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Wang, Haiyue
> Sent: Sunday, August 14, 2022 14:20
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; david@redhat.com; linmiaohe@huawei.com; Huang,
> Ying <ying.huang@intel.com>; songmuchun@bytedance.com; naoya.horiguchi@linux.dev
> Subject: RE: [PATCH v1] mm: migration: fix the FOLL_GET failure on following huge page
>
> > -----Original Message-----
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Sent: Sunday, August 14, 2022 07:29
> > To: Wang, Haiyue <haiyue.wang@intel.com>
> > Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; david@redhat.com; linmiaohe@huawei.com; Huang,
> > Ying <ying.huang@intel.com>; songmuchun@bytedance.com; naoya.horiguchi@linux.dev
> > Subject: Re: [PATCH v1] mm: migration: fix the FOLL_GET failure on following huge page
> >
> > On Fri, 12 Aug 2022 16:49:21 +0800 Haiyue Wang <haiyue.wang@intel.com> wrote:
> >
> > > Not all huge page APIs support FOLL_GET option, so the __NR_move_pages
> > > will fail to get the page node information for huge page.
> >
> > Is a -stable backport warranted?
>
> Yes.
>
> Since the mainline has introduced the new patch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3218f8712d6bb
>
Looks like 'is_zone_device_page' will cause 'FOLL_GET' page reference count issue, which should
call 'put_page' before call branch jump.
try_grab_page -->
if (flags & FOLL_GET)
folio_ref_inc(folio);
Or I misunderstood the 'is_zone_device_page' ? ;-)
> The backported needs to rebase like for 5.19:
>
> - if (page && !is_zone_device_page(page)) {
> + if (page) {
>
> >
> > >
next prev parent reply other threads:[~2022-08-14 6:49 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 8:49 Haiyue Wang
2022-08-13 23:28 ` Andrew Morton
2022-08-14 6:20 ` Wang, Haiyue
2022-08-14 6:49 ` Wang, Haiyue [this message]
2022-08-14 14:05 ` [PATCH v2 0/3] fix follow_page related issues Haiyue Wang
2022-08-14 14:05 ` [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-14 16:30 ` David Hildenbrand
2022-08-15 1:02 ` Wang, Haiyue
2022-08-14 14:05 ` [PATCH v2 2/3] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-14 14:05 ` [PATCH v2 3/3] mm: handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-14 16:34 ` David Hildenbrand
2022-08-15 1:03 ` Wang, Haiyue
2022-08-15 1:03 ` [PATCH v3 0/2] fix follow_page related issues Haiyue Wang
2022-08-15 1:03 ` [PATCH v3 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-15 1:59 ` Huang, Ying
2022-08-15 2:10 ` Wang, Haiyue
2022-08-15 2:15 ` Wang, Haiyue
2022-08-15 2:51 ` Huang, Ying
2022-08-15 1:03 ` [PATCH v3 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-15 1:39 ` Huang, Ying
2022-08-15 1:46 ` Wang, Haiyue
2022-08-15 1:59 ` [PATCH v4 0/2] fix follow_page related issues Haiyue Wang
2022-08-15 1:59 ` [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-15 4:28 ` Alistair Popple
2022-08-15 4:40 ` Wang, Haiyue
2022-08-15 5:16 ` Alistair Popple
2022-08-15 5:20 ` Wang, Haiyue
2022-08-15 5:35 ` Alistair Popple
2022-08-15 5:37 ` Wang, Haiyue
2022-08-15 1:59 ` [PATCH v4 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-15 7:02 ` [PATCH v5 0/2] fix follow_page related issues Haiyue Wang
2022-08-15 7:02 ` [PATCH v5 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-15 7:40 ` Huang, Ying
2022-08-15 7:02 ` [PATCH v5 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-15 7:50 ` Huang, Ying
2022-08-15 14:28 ` Felix Kuehling
2022-08-16 0:00 ` Alistair Popple
2022-08-16 1:12 ` Wang, Haiyue
2022-08-16 2:45 ` Alistair Popple
2022-08-16 2:20 ` [PATCH v6 0/2] fix follow_page related issues Haiyue Wang
2022-08-16 2:21 ` [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-16 8:54 ` Baolin Wang
2022-08-17 0:58 ` Andrew Morton
2022-08-17 3:31 ` Wang, Haiyue
2022-08-17 5:43 ` Andrew Morton
2022-08-17 5:47 ` Wang, Haiyue
2022-08-17 17:26 ` Mike Kravetz
2022-08-17 21:58 ` Mike Kravetz
2022-08-18 0:32 ` Wang, Haiyue
2022-08-19 11:22 ` Michael Ellerman
2022-08-19 16:55 ` Mike Kravetz
2022-08-26 13:07 ` Michael Ellerman
2022-08-18 11:51 ` Gerald Schaefer
2022-08-18 11:57 ` Gerald Schaefer
2022-08-17 2:12 ` Miaohe Lin
2022-08-16 2:21 ` [PATCH v6 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-16 4:42 ` Alistair Popple
2022-08-17 2:34 ` Miaohe Lin
2022-08-23 10:07 ` David Hildenbrand
2022-08-23 13:26 ` Wang, Haiyue
2022-08-23 13:27 ` David Hildenbrand
2022-08-23 13:29 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3495AC9B3F989A3462053C24F7699@BYAPR11MB3495.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@linux.dev \
--cc=songmuchun@bytedance.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox